From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
libvir-list@redhat.com,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2 1/3] ui: Remove deprecated parameters of the "-display sdl" option
Date: Wed, 18 May 2022 17:04:05 +0200 [thread overview]
Message-ID: <87tu9mkhlm.fsf@pond.sub.org> (raw)
In-Reply-To: <20220518134446.211632-2-thuth@redhat.com> (Thomas Huth's message of "Wed, 18 May 2022 15:44:44 +0200")
Thomas Huth <thuth@redhat.com> writes:
> These parameters are in the way for further refactoring (since they
> use an underscore in the name which is forbidden in QAPI), so let's
> remove these now that their deprecation period is over.
Forbidden, but there's an exception mechanism, so this reason isn't
compelling. I believe the actual reason is they are "too ugly and
inflexible to drag them along into the QAPI world" (your words).
Suggest:
Dropping these deprecated parameters now simplifies further
refactoring.
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Patch looks good to me, so
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2022-05-18 15:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 13:44 [PATCH v2 0/3] ui: Remove deprecated sdl parameters and switch to QAPI parser Thomas Huth
2022-05-18 13:44 ` [PATCH v2 1/3] ui: Remove deprecated parameters of the "-display sdl" option Thomas Huth
2022-05-18 15:04 ` Markus Armbruster [this message]
2022-05-18 13:44 ` [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser Thomas Huth
2022-05-18 15:08 ` Markus Armbruster
2022-05-19 6:39 ` Thomas Huth
2022-05-19 7:08 ` Thomas Huth
2022-05-19 7:27 ` Thomas Huth
2022-05-19 7:51 ` Daniel P. Berrangé
2022-05-19 8:57 ` Markus Armbruster
2022-05-19 9:09 ` Thomas Huth
2022-05-19 9:13 ` Thomas Huth
2022-05-19 10:48 ` Gerd Hoffmann
2022-05-19 11:00 ` Thomas Huth
2022-05-19 11:19 ` Gerd Hoffmann
2022-05-19 7:33 ` Markus Armbruster
2022-05-18 15:41 ` Eric Blake
2022-05-19 6:41 ` Thomas Huth
2022-05-18 13:44 ` [PATCH v2 3/3] ui: Remove deprecated options "-sdl" and "-curses" Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu9mkhlm.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.