From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C80B0C433F5 for ; Thu, 16 Dec 2021 08:51:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235006AbhLPIvz (ORCPT ); Thu, 16 Dec 2021 03:51:55 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:56616 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbhLPIvz (ORCPT ); Thu, 16 Dec 2021 03:51:55 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AEBB3B82273; Thu, 16 Dec 2021 08:51:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D6A2C36AE2; Thu, 16 Dec 2021 08:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639644712; bh=JPhSWycjfzHEYZAeL8Z+Ay7PDuPFKwvup/dAJX0d5FQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K0o94V/VyH+RZZ1Rh05/eX/2jfvpNpS6Pdsjk84V+ijmq2yaDcfOfK8gGw8gyjVVM 8A7MjMpdmGdkQUu9F4C5GfQVm5XwQvq661kcUIyV3ZsMv1cXNRx4zeQAY/+vcfdEc8 dSkNABV64mzpXiMX6+Q11jiDB1NX6c8wTvZM8vhnxFcTi/F3c1pJ370YWLOdJlEvnX rSRDKPjayBPsp6uRUZWkoA06UK+2/yNzJa/huhSOC7mVp++9l4fQc3CkNYTYK4KJpg bmvbTSA0eNdRGWqkRIcEv2JZNKZp3nzhfwkDfXajZXndE1SQtuL5gCDspqackP3fBR hffer19QF4hGg== Received: from cfbb000407.r.cam.camfibre.uk ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mxmUQ-00CTDn-HD; Thu, 16 Dec 2021 08:51:50 +0000 Date: Thu, 16 Dec 2021 08:51:40 +0000 Message-ID: <87tuf9vso3.wl-maz@kernel.org> From: Marc Zyngier To: Qin Jian Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, p.zabel@pengutronix.de, linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de, stefan.wahren@i2se.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, wells.lu@sunplus.com Subject: Re: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver In-Reply-To: <677ce3dd9b4650521968d6cb50999608b5136ddd.1639560427.git.qinjian@cqplus1.com> References: <677ce3dd9b4650521968d6cb50999608b5136ddd.1639560427.git.qinjian@cqplus1.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: qinjian@cqplus1.com, robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, p.zabel@pengutronix.de, linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de, stefan.wahren@i2se.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, wells.lu@sunplus.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, 16 Dec 2021 07:08:10 +0000, Qin Jian wrote: > > Add interrupt controller driver for Sunplus SP7021 SoC. > > This is the interrupt controller in P-chip which collects all interrupt > sources in P-chip and routes them to parent interrupt controller in C-chip. > > Signed-off-by: Qin Jian > --- > Fix the comments from Marc. No, you didn't. > +void sp_intc_set_ext(u32 hwirq, int ext_num) > +{ > + sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num); > +} > +EXPORT_SYMBOL_GPL(sp_intc_set_ext); I already commented on this. In case it wasn't clear, this is a strong NAK to random low-level hacks like this. M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB937C433F5 for ; Thu, 16 Dec 2021 08:53:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dLJtZ/2HSjfz8PFQRaGyTyLouDaD4S1sfny4Cl4dX9Q=; b=OKrwOZNblj2rXB lNG0pt9p/IKX4AfEC+7lB+gJK3V9xcHW1v/2iWvsSssTzKa17+SrO9Zts+52DrWkq1yyN9EHxZgcb O7BIEdBZmLvt31WboHjgAWLf2LfuKrismEsNMo35fbByIgG54FvrDF/NzKyEwk7YZODUvcgSdXdmA 9IrE6+vW0LDKjingTgoE6mHtXoqhGlTlp5OCoO/MllUwoVh/0F5Z1Aljw6mbiFGSpKPFL9VPxd1O/ cSvaEJBpX2vzDSwb0B+MIKfyPbzLKrBXLraw1As6K4sZF9v6B7yIIHfQ+1lJy0A2kCTan7ynlmCrI 2qmdXGvjLqjdpSrJdbrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxmUZ-004CGy-7N; Thu, 16 Dec 2021 08:51:59 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxmUV-004CG5-MK for linux-arm-kernel@lists.infradead.org; Thu, 16 Dec 2021 08:51:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19BF861C9C; Thu, 16 Dec 2021 08:51:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D6A2C36AE2; Thu, 16 Dec 2021 08:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639644712; bh=JPhSWycjfzHEYZAeL8Z+Ay7PDuPFKwvup/dAJX0d5FQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K0o94V/VyH+RZZ1Rh05/eX/2jfvpNpS6Pdsjk84V+ijmq2yaDcfOfK8gGw8gyjVVM 8A7MjMpdmGdkQUu9F4C5GfQVm5XwQvq661kcUIyV3ZsMv1cXNRx4zeQAY/+vcfdEc8 dSkNABV64mzpXiMX6+Q11jiDB1NX6c8wTvZM8vhnxFcTi/F3c1pJ370YWLOdJlEvnX rSRDKPjayBPsp6uRUZWkoA06UK+2/yNzJa/huhSOC7mVp++9l4fQc3CkNYTYK4KJpg bmvbTSA0eNdRGWqkRIcEv2JZNKZp3nzhfwkDfXajZXndE1SQtuL5gCDspqackP3fBR hffer19QF4hGg== Received: from cfbb000407.r.cam.camfibre.uk ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mxmUQ-00CTDn-HD; Thu, 16 Dec 2021 08:51:50 +0000 Date: Thu, 16 Dec 2021 08:51:40 +0000 Message-ID: <87tuf9vso3.wl-maz@kernel.org> From: Marc Zyngier To: Qin Jian Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, p.zabel@pengutronix.de, linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de, stefan.wahren@i2se.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, wells.lu@sunplus.com Subject: Re: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver In-Reply-To: <677ce3dd9b4650521968d6cb50999608b5136ddd.1639560427.git.qinjian@cqplus1.com> References: <677ce3dd9b4650521968d6cb50999608b5136ddd.1639560427.git.qinjian@cqplus1.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: qinjian@cqplus1.com, robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, p.zabel@pengutronix.de, linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de, stefan.wahren@i2se.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, wells.lu@sunplus.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211216_005155_817429_17EC973D X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Dec 2021 07:08:10 +0000, Qin Jian wrote: > > Add interrupt controller driver for Sunplus SP7021 SoC. > > This is the interrupt controller in P-chip which collects all interrupt > sources in P-chip and routes them to parent interrupt controller in C-chip. > > Signed-off-by: Qin Jian > --- > Fix the comments from Marc. No, you didn't. > +void sp_intc_set_ext(u32 hwirq, int ext_num) > +{ > + sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num); > +} > +EXPORT_SYMBOL_GPL(sp_intc_set_ext); I already commented on this. In case it wasn't clear, this is a strong NAK to random low-level hacks like this. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel