From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C309C07E95 for ; Tue, 20 Jul 2021 09:02:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9756661209 for ; Tue, 20 Jul 2021 09:02:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9756661209 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5le8-00051Q-9R for qemu-devel@archiver.kernel.org; Tue, 20 Jul 2021 05:02:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5lcj-0003W5-Rm for qemu-devel@nongnu.org; Tue, 20 Jul 2021 05:01:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5lcf-0004aO-5q for qemu-devel@nongnu.org; Tue, 20 Jul 2021 05:01:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626771663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iX/f0IV9djLKRteOLpR2DXXQmAR0rsTQhDW0L9Mo6dE=; b=IE75bpVaulylOVcryjEzZYBaORhU7kJDOuRmYibA3FdW4LcQL1g0iikH0OyXRVxNG/rdm/ OQkYdpE0DgjcGv3138M6L+ZAlZlPA+kTd09rNVF+b3vGTxiMic+1ypVKokUSIJwkr81omy 4oq9JG2Zd7NQ2MtX3bpSGtzL7AkF5zY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-fThHQk05PFamGmCtrK-xEw-1; Tue, 20 Jul 2021 05:01:02 -0400 X-MC-Unique: fThHQk05PFamGmCtrK-xEw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A0F2802C87; Tue, 20 Jul 2021 09:01:00 +0000 (UTC) Received: from localhost (ovpn-112-105.ams2.redhat.com [10.36.112.105]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 350DD5D9DC; Tue, 20 Jul 2021 09:00:55 +0000 (UTC) From: Cornelia Huck To: Pierre Morel , =?utf-8?Q?Daniel_P=2E_Berrang?= =?utf-8?Q?=C3=A9?= Subject: Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing In-Reply-To: <49614371-1357-47dd-c000-c8ff6ff845b1@linux.ibm.com> Organization: Red Hat GmbH References: <1626281596-31061-1-git-send-email-pmorel@linux.ibm.com> <1626281596-31061-3-git-send-email-pmorel@linux.ibm.com> <87y2a8cda7.fsf@dusky.pond.sub.org> <0801e122-0e9c-e266-42e8-d5cddb16c237@linux.ibm.com> <87bl73df9y.fsf@dusky.pond.sub.org> <87y2a6bp5f.fsf@redhat.com> <87pmvibkri.fsf@redhat.com> <87czre9uar.fsf@redhat.com> <87wnpl8kgy.fsf@redhat.com> <49614371-1357-47dd-c000-c8ff6ff845b1@linux.ibm.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 20 Jul 2021 11:00:54 +0200 Message-ID: <87tukp8im1.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.469, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, ehabkost@redhat.com, david@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, Markus Armbruster , pasic@linux.ibm.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, pbonzini@redhat.com, eblake@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 20 2021, Pierre Morel wrote: > On 7/20/21 10:20 AM, Cornelia Huck wrote: >> On Tue, Jul 20 2021, Pierre Morel wrote: >>=20 >>> On 7/19/21 5:50 PM, Cornelia Huck wrote: >>>> On Fri, Jul 16 2021, Daniel P. Berrang=C3=A9 wro= te: >>>>> Is the book/drawer thing architecture specific, or is it machine >>>>> type / CPU specific. ie do /all/ the s390x machine types / CPUS >>>>> QEMU support the book/drawer concept, or only a subset. >>>> >>>> Should not be by machine type, but might be by cpu model (e.g. older >>>> hardware lacking the needed support for exposing this to the guest.) I= BM >>>> folks, please correct me if I'm wrong. >>> >>> >>> Looks correct to me this is an information indicated by a facility >>> introduced with Z10 if I do not make an error. >>=20 >> Hm. Would that become a problem if we made availability of parameters >> dependent upon a value in the machine (see the other thread I cc:ed you >> on?) >>=20 > > Why? > The parameter can always be there, it is just that with older cpu model= =20 > we will not report the topology information to the guest. If we are fine with a configuration like that, sure. > > The discussion on dies and on smp_dies_supported in this thread will be= =20 > interesting to follow because in my opinion dies for X or books/drawers= =20 > for Z are to be treated equally. Agreed. There was also talk of "clusters" in that thread, which I assume are yet anothor machine specific parameter.