All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Aravinda Prasad <arawinda.p@gmail.com>,
	Ganesh Goudar <ganeshgr@linux.ibm.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	qemu-devel@nongnu.org
Subject: spapr_events: Sure we may ignore migrate_add_blocker() failure?
Date: Thu, 15 Jul 2021 15:32:06 +0200	[thread overview]
Message-ID: <87tukvaejt.fsf@dusky.pond.sub.org> (raw)

Commit 2500fb423a "migration: Include migration support for machine
check handling" adds this:

    ret = migrate_add_blocker(spapr->fwnmi_migration_blocker, &local_err);
    if (ret == -EBUSY) {
        /*
         * We don't want to abort so we let the migration to continue.
         * In a rare case, the machine check handler will run on the target.
         * Though this is not preferable, it is better than aborting
         * the migration or killing the VM.
         */
        warn_report("Received a fwnmi while migration was in progress");
    }

migrate_add_blocker() can fail in two ways:

1. -EBUSY: migration is already in progress

   Ignoring this one is clearly intentional.  The comment explains why.
   I'm taking it at face value (I'm a spapr ignoramus).  Aside: I doubt
   the warning is going to help users.

2. -EACCES: we're running with -only-migratable

   Why may we ignore -only-migratable here?

By the way, we leak @local_err on failure.  I'll post a patch, but I'd
like my question answered first.



             reply	other threads:[~2021-07-15 13:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15 13:32 Markus Armbruster [this message]
2021-07-19  2:31 ` spapr_events: Sure we may ignore migrate_add_blocker() failure? David Gibson
2021-07-19  7:18   ` Markus Armbruster
2021-07-19  7:20     ` David Gibson
2021-07-19 10:41       ` Markus Armbruster
2021-07-19 11:00         ` -only-migrate and the two different uses of migration blockers (was: spapr_events: Sure we may ignore migrate_add_blocker() failure?) Markus Armbruster
2021-07-19 12:42           ` Dr. David Alan Gilbert
2021-07-20  5:30             ` -only-migrate and the two different uses of migration blockers Markus Armbruster
2021-07-21  6:32               ` David Gibson
2021-07-22 18:00                 ` Dr. David Alan Gilbert
2021-07-25  6:25                   ` David Gibson
2021-11-02 14:32                 ` Juan Quintela
2021-11-02 14:30           ` Juan Quintela
2021-07-21  6:26         ` spapr_events: Sure we may ignore migrate_add_blocker() failure? David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tukvaejt.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=arawinda.p@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ganeshgr@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.