From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2 1/2] tests: migration-test: Still run the rest even if uffd missing
Date: Wed, 16 Jun 2021 14:49:42 +0200 [thread overview]
Message-ID: <87tuly0yah.fsf@secure.mitica> (raw)
In-Reply-To: <20210615175523.439830-2-peterx@redhat.com> (Peter Xu's message of "Tue, 15 Jun 2021 13:55:22 -0400")
Peter Xu <peterx@redhat.com> wrote:
> Currently we'll skip the whole migration-test if uffd missing.
>
> It's a bit harsh - we can still run the rest besides postcopy! Enable them
> when we still can.
>
> It'll happen more frequently now after kernel UFFD_USER_MODE_ONLY introduced in
> commit 37cd0575b8510159, as qemu test normally requires kernel faults. One
> alternative is we disable kvm and create the uffd with UFFD_USER_MODE_ONLY for
> all postcopy tests, however to be simple for now just skip postcopy tests only
> by default. If we wanna run them use "sudo" or root, they'll still work. In
> all cases, it's still better than running nothing for migration-test.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
A shame we can't check postcopy without being run.
next prev parent reply other threads:[~2021-06-16 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 17:55 [PATCH v2 0/2] tests: migration-test: Fix agressive test skip, add dirty ring test Peter Xu
2021-06-15 17:55 ` [PATCH v2 1/2] tests: migration-test: Still run the rest even if uffd missing Peter Xu
2021-06-16 12:49 ` Juan Quintela [this message]
2021-06-15 17:55 ` [PATCH v2 2/2] tests: migration-test: Add dirty ring test Peter Xu
2021-06-16 12:55 ` Juan Quintela
2021-06-16 13:29 ` Peter Xu
2021-07-28 19:37 ` Richard Henderson
2021-07-28 20:37 ` Peter Xu
2021-07-28 21:11 ` Richard Henderson
2021-07-28 21:39 ` Peter Xu
2021-06-30 17:01 ` [PATCH v2 0/2] tests: migration-test: Fix agressive test skip, add " Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuly0yah.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.