From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 57CD96F3E3
 for <igt-dev@lists.freedesktop.org>; Fri, 11 Jun 2021 21:43:35 +0000 (UTC)
Date: Fri, 11 Jun 2021 14:28:06 -0700
Message-ID: <87tum4m6qh.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <CAOFGe95pMGM5k60wEEkqJz1u3Vq8NgrjxyDHwv91+7ffHbT1GA@mail.gmail.com>
References: <20210609043035.102359-1-jason@jlekstrand.net>
 <20210609043035.102359-19-jason@jlekstrand.net>
 <20210609071839.GK6228@zkempczy-mobl2>
 <CAOFGe95pMGM5k60wEEkqJz1u3Vq8NgrjxyDHwv91+7ffHbT1GA@mail.gmail.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Subject: Re: [igt-dev] [PATCH i-g-t 18/93] tests/i915/gem_exec_fence: Move
 the engine data into inter_engine_context
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Jason Ekstrand <jason@jlekstrand.net>
Cc: IGT GPU Tools <igt-dev@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Wed, 09 Jun 2021 08:02:04 -0700, Jason Ekstrand wrote:
> On Wed, Jun 9, 2021 at 2:18 AM Zbigniew Kempczy=F1ski
> <zbigniew.kempczynski@intel.com> wrote:
> > On Tue, Jun 08, 2021 at 11:30:04PM -0500, Jason Ekstrand wrote:
> > > -static void setup_timeline_chain_engines(struct inter_engine_context=
 *context, int fd, struct intel_engine_data *engines)
> > > +static void setup_timeline_chain_engines(struct inter_engine_context=
 *context, int fd)
> > >  {
> > >       memset(context, 0, sizeof(*context));
> > >
> > >       context->fd =3D fd;
> > > -     context->engines =3D engines;
> > > +     context->engines =3D intel_init_engine_list(fd, 0);
> >
> > Original code verifies there's nengines > 0. I would keep this igt_requ=
ire().
>
> I'm not seeing that in the diff or the code.  Mind pointing me at it?
> In any case, I'm fine with the igt_require(); it should always be true
> anyway.

Note that original code has "igt_require(engines.nengines > 1)" not >
0. Still always true but probably there just to show the intent of the
test.

>
> > With that minor nit:
> >
> > Reviewed-by: Zbigniew Kempczy=F1ski <zbigniew.kempczynski@intel.com>
>
> Thanks!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev