From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53D29C433FE for ; Wed, 9 Dec 2020 15:25:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AD9B23AAC for ; Wed, 9 Dec 2020 15:25:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AD9B23AAC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 811156EA8D; Wed, 9 Dec 2020 15:25:56 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D44A6EA8B for ; Wed, 9 Dec 2020 15:25:55 +0000 (UTC) IronPort-SDR: 6bYvJ85c6fCbC2rqjGjWCDaQ5qSBYLx6jLVqINORD4oNLifV8lkTiM1gxgAVloUOigCLxmsrPD amvLIEQo3NyA== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="161143510" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="161143510" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 07:25:54 -0800 IronPort-SDR: 56XDVUeHp7VdkK7AfU89rukmPBa5QHhmklTwen/8Fr6Aa2C1jg/BQ8ZPQ4qg91Aw1+BWPt90om 3DC0F//Oe+AQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="370863612" Received: from gaia.fi.intel.com ([10.237.72.192]) by fmsmga002.fm.intel.com with ESMTP; 09 Dec 2020 07:25:53 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 1C9475C2003; Wed, 9 Dec 2020 17:23:38 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20201208231834.24812-3-chris@chris-wilson.co.uk> References: <20201208231834.24812-1-chris@chris-wilson.co.uk> <20201208231834.24812-3-chris@chris-wilson.co.uk> Date: Wed, 09 Dec 2020 17:23:38 +0200 Message-ID: <87tusvknph.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: Remove uninterruptible parameter from intel_gt_wait_for_idle X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > Now that the only user of the uninterruptible wait was eliminated, > remove the support. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_gt_requests.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_requests.c b/drivers/gpu/drm/i915/gt/intel_gt_requests.c > index 66fcbf9d0fdd..dc06c78c9eeb 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_requests.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt_requests.c > @@ -135,13 +135,8 @@ long intel_gt_retire_requests_timeout(struct intel_gt *gt, long timeout) > struct intel_gt_timelines *timelines = >->timelines; > struct intel_timeline *tl, *tn; > unsigned long active_count = 0; > - bool interruptible; > LIST_HEAD(free); > > - interruptible = true; > - if (unlikely(timeout < 0)) > - timeout = -timeout, interruptible = false; > - > flush_submission(gt, timeout); /* kick the ksoftirqd tasklets */ > spin_lock(&timelines->lock); > list_for_each_entry_safe(tl, tn, &timelines->active_list, link) { > @@ -163,7 +158,7 @@ long intel_gt_retire_requests_timeout(struct intel_gt *gt, long timeout) > mutex_unlock(&tl->mutex); > > timeout = dma_fence_wait_timeout(fence, > - interruptible, > + true, > timeout); > dma_fence_put(fence); > > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx