From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1799C63697 for ; Sun, 22 Nov 2020 04:56:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 491E9208B3 for ; Sun, 22 Nov 2020 04:56:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727286AbgKVEzn (ORCPT ); Sat, 21 Nov 2020 23:55:43 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:50974 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727236AbgKVEzn (ORCPT ); Sat, 21 Nov 2020 23:55:43 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 8363F1F45BFE From: Gabriel Krisman Bertazi To: Daniel Rosenberg Cc: "Theodore Y . Ts'o" , Jaegeuk Kim , Eric Biggers , Andreas Dilger , Chao Yu , Alexander Viro , Richard Weinberger , linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, kernel-team@android.com, Eric Biggers Subject: Re: [PATCH v4 1/3] libfs: Add generic function for setting dentry_ops Organization: Collabora References: <20201119060904.463807-1-drosen@google.com> <20201119060904.463807-2-drosen@google.com> Date: Sat, 21 Nov 2020 23:55:37 -0500 In-Reply-To: <20201119060904.463807-2-drosen@google.com> (Daniel Rosenberg's message of "Thu, 19 Nov 2020 06:09:02 +0000") Message-ID: <87tutij8hi.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Daniel Rosenberg writes: > This adds a function to set dentry operations at lookup time that will > work for both encrypted filenames and casefolded filenames. > > A filesystem that supports both features simultaneously can use this > function during lookup preparations to set up its dentry operations once > fscrypt no longer does that itself. > > Currently the casefolding dentry operation are always set if the > filesystem defines an encoding because the features is toggleable on > empty directories. Unlike in the encryption case, the dentry operations > used come from the parent. Since we don't know what set of functions > we'll eventually need, and cannot change them later, we enable the > casefolding operations if the filesystem supports them at all. > > By splitting out the various cases, we support as few dentry operations > as we can get away with, maximizing compatibility with overlayfs, which > will not function if a filesystem supports certain dentry_operations. > > Signed-off-by: Daniel Rosenberg > Reviewed-by: Eric Biggers Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisman Bertazi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEE9C56201 for ; Sun, 22 Nov 2020 05:01:55 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E39432078D for ; Sun, 22 Nov 2020 05:01:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="F/oSErUG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="ksSquFCN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E39432078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kghVa-0002P5-KX; Sun, 22 Nov 2020 05:01:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kghVY-0002Ox-Qv for linux-f2fs-devel@lists.sourceforge.net; Sun, 22 Nov 2020 05:01:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wFsi3ix9hTLUgdW/yNyQEjY9QMbtg6sdmsm/0sRxjqk=; b=F/oSErUGI5rdTBbiO4CgZbUHaH u6WCB+xurHY82OdeCW7/80pkFSUo6dc/Urmf40gM0j5CGc8JNiniJtaT2ASdy1lpIJ/BWZITKCr/O n3rIP8thjyWEREu5JZD52Ggwef9ggXzvLjbwRsFWBy7189gqeYWDA9v3UoAjCfXx1KoE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject: Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wFsi3ix9hTLUgdW/yNyQEjY9QMbtg6sdmsm/0sRxjqk=; b=ksSquFCN2IVzdsoZX5Kx25CGuc drrkbIIrMPdhsMwxUaurTLLOCzpg5qUnB/rtho0N9DOpL/qG5u8oRCLU9Q/1fU5VkmooDxRLQcS/K quT3oSM94Or+kOi+xspe+/M81pYuz5PqM5E2whTYw9uOYLPmAc5BUwnrjoNacnyyUZQI=; Received: from bhuna.collabora.co.uk ([46.235.227.227]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kghVO-007T5R-Ts for linux-f2fs-devel@lists.sourceforge.net; Sun, 22 Nov 2020 05:01:52 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 8363F1F45BFE From: Gabriel Krisman Bertazi To: Daniel Rosenberg Organization: Collabora References: <20201119060904.463807-1-drosen@google.com> <20201119060904.463807-2-drosen@google.com> Date: Sat, 21 Nov 2020 23:55:37 -0500 In-Reply-To: <20201119060904.463807-2-drosen@google.com> (Daniel Rosenberg's message of "Thu, 19 Nov 2020 06:09:02 +0000") Message-ID: <87tutij8hi.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1kghVO-007T5R-Ts Subject: Re: [f2fs-dev] [PATCH v4 1/3] libfs: Add generic function for setting dentry_ops X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Theodore Y . Ts'o" , Eric Biggers , Richard Weinberger , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, Andreas Dilger , Alexander Viro , linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Daniel Rosenberg writes: > This adds a function to set dentry operations at lookup time that will > work for both encrypted filenames and casefolded filenames. > > A filesystem that supports both features simultaneously can use this > function during lookup preparations to set up its dentry operations once > fscrypt no longer does that itself. > > Currently the casefolding dentry operation are always set if the > filesystem defines an encoding because the features is toggleable on > empty directories. Unlike in the encryption case, the dentry operations > used come from the parent. Since we don't know what set of functions > we'll eventually need, and cannot change them later, we enable the > casefolding operations if the filesystem supports them at all. > > By splitting out the various cases, we support as few dentry operations > as we can get away with, maximizing compatibility with overlayfs, which > will not function if a filesystem supports certain dentry_operations. > > Signed-off-by: Daniel Rosenberg > Reviewed-by: Eric Biggers Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisman Bertazi _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CC1C56201 for ; Sun, 22 Nov 2020 04:56:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF98A2078D for ; Sun, 22 Nov 2020 04:56:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0GLWT22V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF98A2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0OqlC4rzbVsnpmFVB+DrhsafRsjaCjf6Q+RclP/kdAo=; b=0GLWT22Vcmf0zttWvZ4FI66Hm QOAK1JCBpCivmYk+JzyYzxqOxd15GTyFj7JVazsmbxkYVXzZzVcuxwhr45119YsxN7jQWm7mxR/0F l18EZgG6qsSDmy5v0HGLK5CsQDPdgXKDUH0MSoXwQ4GRSKswx8W8D8+ECJi/jdEh/iWS/7BLjzS+C kFMyqk4blrFdjyFOoJsWfThrmTbAYOMCqMmiPXLAXplir54CtVvf3jxZPD+FELU34ElKoucTVojzU YIPXwP4hbEFlkr0O+XJcFYRTsPMySmaeX+Oh/aFP84pA5f5y+5aJKv3nuzvC+wZSfkwGZf3EK44lo l6OSgkkfA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kghPd-0003Om-NX; Sun, 22 Nov 2020 04:55:45 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kghPa-0003Nx-JF for linux-mtd@lists.infradead.org; Sun, 22 Nov 2020 04:55:43 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 8363F1F45BFE From: Gabriel Krisman Bertazi To: Daniel Rosenberg Subject: Re: [PATCH v4 1/3] libfs: Add generic function for setting dentry_ops Organization: Collabora References: <20201119060904.463807-1-drosen@google.com> <20201119060904.463807-2-drosen@google.com> Date: Sat, 21 Nov 2020 23:55:37 -0500 In-Reply-To: <20201119060904.463807-2-drosen@google.com> (Daniel Rosenberg's message of "Thu, 19 Nov 2020 06:09:02 +0000") Message-ID: <87tutij8hi.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201121_235542_766528_08613A26 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Theodore Y . Ts'o" , Eric Biggers , Richard Weinberger , Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, Andreas Dilger , Alexander Viro , linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Daniel Rosenberg writes: > This adds a function to set dentry operations at lookup time that will > work for both encrypted filenames and casefolded filenames. > > A filesystem that supports both features simultaneously can use this > function during lookup preparations to set up its dentry operations once > fscrypt no longer does that itself. > > Currently the casefolding dentry operation are always set if the > filesystem defines an encoding because the features is toggleable on > empty directories. Unlike in the encryption case, the dentry operations > used come from the parent. Since we don't know what set of functions > we'll eventually need, and cannot change them later, we enable the > casefolding operations if the filesystem supports them at all. > > By splitting out the various cases, we support as few dentry operations > as we can get away with, maximizing compatibility with overlayfs, which > will not function if a filesystem supports certain dentry_operations. > > Signed-off-by: Daniel Rosenberg > Reviewed-by: Eric Biggers Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisman Bertazi ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/