From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A37C47095 for ; Wed, 7 Oct 2020 13:22:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7A6921548 for ; Wed, 7 Oct 2020 13:22:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hXgNQ3TJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7A6921548 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ9Ov-0004wL-Kp for qemu-devel@archiver.kernel.org; Wed, 07 Oct 2020 09:22:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ9Ni-000449-Py for qemu-devel@nongnu.org; Wed, 07 Oct 2020 09:21:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:27383) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQ9Nb-000409-KN for qemu-devel@nongnu.org; Wed, 07 Oct 2020 09:21:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602076873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gjChceSm+R2EM26/f1k5OZlxGqPtRm/W65rMMn28ew4=; b=hXgNQ3TJK9gW7laudj4QLjSTokj9b+DQkvBNOukxglguGel2JuKYe0op15kIL/dtVY1CmK ffy4vr8nBEBPQ8CLdOOhedq7RWJF3k+xwPJK5qOiURB03ZcMdpzByB9linkpHl6/vuc+h/ qK7lVEELPXE+CLr/cFLjaLGNjhjHRXU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-JS0eJIQdMFyMBvrUaZULyg-1; Wed, 07 Oct 2020 09:21:11 -0400 X-MC-Unique: JS0eJIQdMFyMBvrUaZULyg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 71D50801FD7 for ; Wed, 7 Oct 2020 13:20:59 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1C0C85D9DD; Wed, 7 Oct 2020 13:20:59 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 88B7111329C1; Wed, 7 Oct 2020 15:20:57 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: [PATCH v5 27/36] qapi/gen.py: add type hint annotations References: <20201005195158.2348217-1-jsnow@redhat.com> <20201005195158.2348217-28-jsnow@redhat.com> Date: Wed, 07 Oct 2020 15:20:57 +0200 In-Reply-To: <20201005195158.2348217-28-jsnow@redhat.com> (John Snow's message of "Mon, 5 Oct 2020 15:51:49 -0400") Message-ID: <87tuv68952.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/07 00:44:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.742, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > --- > scripts/qapi/gen.py | 104 ++++++++++++++++++++++++-------------------- > 1 file changed, 57 insertions(+), 47 deletions(-) > > diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py > index 1bad37fc06b..d0391cd8718 100644 > --- a/scripts/qapi/gen.py > +++ b/scripts/qapi/gen.py > @@ -17,7 +17,13 @@ > import errno > import os > import re > -from typing import Optional > +from typing import ( > + Dict, > + Iterator, > + List, > + Optional, > + Tuple, > +) > > from .common import ( > c_fname, > @@ -29,31 +35,31 @@ > mcgen, > ) > from .schema import QAPISchemaObjectType, QAPISchemaVisitor > +from .source import QAPISourceInfo PATCH 03 has a similar cleanup. Are there more? Perhaps a separate patch doing just this kind of cleanup would make sense. Up to you. [...]