From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E60C433E1 for ; Mon, 24 Aug 2020 09:48:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC0AB2075B for ; Mon, 24 Aug 2020 09:48:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HMOAEhYW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC0AB2075B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a/VOFA+YRSKTE5VTaJojou+1YVkpuSn85oRdbFskKRY=; b=HMOAEhYWr9nw2E91bXWm4WCH+ hgMMrTs2sZzb83iSgruDKcb6aqyOlTCXi5Bp5dquaDva0oPqCgkd8CgD2aUzjT1+n9oadkjGqAy2B icaSX2qzlI5eQFQVkOlRqaHcTgyEh6sIBdJDMeflxqlx8ZEcfy1z5IDVz0NyAN40H8NV1glJ8Yafr yGNKjQii5UQIwFBDzkCqAj3qfSK5ZazqYkHEpnHbZaMZjs22bj+F7TbcGuZtX0k/L5gvU7bZbm5// ZnNQQHK9LXVQCLNanVGxbXBfDWfehPE6wnpfoWRRk5QR8mKM3ZpVwazEyqCgGvzl2K2m573f+jj8t 3ULrod6rA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA945-0004h1-54; Mon, 24 Aug 2020 09:46:57 +0000 Received: from metis.ext.pengutronix.de ([85.220.165.71]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA942-0004gT-Hx for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 09:46:55 +0000 Received: from [2001:67c:670:201:5054:ff:fe8d:eefb] (helo=leviathan.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kA93z-0007UB-Ky; Mon, 24 Aug 2020 11:46:51 +0200 References: <20200714051140.8090-1-s.trumtrar@pengutronix.de> <20200817072423.GB16951@dragon> User-agent: mu4e 1.4.12; emacs 28.0.50 From: Steffen Trumtrar To: Shawn Guo Subject: Re: [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel In-reply-to: <20200817072423.GB16951@dragon> Date: Mon, 24 Aug 2020 11:46:47 +0200 Message-ID: <87tuwsz88o.fsf@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_054654_645187_E15B7C25 X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fugang Duan , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! Shawn Guo writes: > On Tue, Jul 14, 2020 at 07:11:37AM +0200, Steffen Trumtrar > wrote: >> Add clock source init for the second ethernet port. >> This changes the clock direction and clock selection in a way >> that the >> ethernet phy reference clock is routed as an output. >> >> Signed-off-by: Steffen Trumtrar >> --- >> arch/arm/mach-imx/mach-imx7d.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm/mach-imx/mach-imx7d.c >> b/arch/arm/mach-imx/mach-imx7d.c >> index 879c35929a13..7a203f660721 100644 >> --- a/arch/arm/mach-imx/mach-imx7d.c >> +++ b/arch/arm/mach-imx/mach-imx7d.c >> @@ -65,6 +65,9 @@ static void __init imx7d_enet_clk_sel(void) >> if (!IS_ERR(gpr)) { >> regmap_update_bits(gpr, IOMUXC_GPR1, >> IMX7D_GPR1_ENET_TX_CLK_SEL_MASK, 0); >> regmap_update_bits(gpr, IOMUXC_GPR1, >> IMX7D_GPR1_ENET_CLK_DIR_MASK, 0); >> + regmap_update_bits(gpr, IOMUXC_GPR1, >> IMX7D_GPR1_ENET2_TX_CLK_SEL_MASK, 0); >> + regmap_update_bits(gpr, IOMUXC_GPR1, >> IMX7D_GPR1_ENET2_CLK_DIR_MASK, >> + IMX7D_GPR1_ENET2_CLK_DIR_MASK); > > I would like to see such code get removed from machine code > rather than > added. Can we deal with these IOMUXC_GPR bits in some driver > code? > My comment got lost in the v2: I know, that this is not a "good solution", but I don't know how we can handle this in a better way. Open for suggestions. Of course, putting it in the machine code is suboptimal. If anyone has a good idea where the 4 gpr1 calls should go without producing a massive complexity overhead, please share. Best regards, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel