From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C974C433DF for ; Mon, 10 Aug 2020 08:20:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03804206B5 for ; Mon, 10 Aug 2020 08:20:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03804206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A9CD89FE6; Mon, 10 Aug 2020 08:20:52 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A97289FE6 for ; Mon, 10 Aug 2020 08:20:51 +0000 (UTC) IronPort-SDR: /c9+qmspEv2X0EeUedTq6iMEWWJCrg+iyxV4XZSfpfxs9t1BXuSeowbNxzcveJQ86MRiX6DmOF n6uMJcn0AZPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9708"; a="154624753" X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="154624753" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 01:20:49 -0700 IronPort-SDR: WvpZDOMWzYWGf+fT0WgbLG/tj2t0mDpbX/dcZ77WSwnbgHBmAO1HpylnapqyTiku2cXGwAMka8 yw+bBK2dTpBg== X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="494719354" Received: from unknown (HELO localhost) ([10.249.44.171]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 01:20:45 -0700 From: Jani Nikula To: Sam Ravnborg , Daniel Vetter Subject: Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree? In-Reply-To: <20200808093708.GA14702@ravnborg.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <159680700523135@kroah.com> <20200808093708.GA14702@ravnborg.org> Date: Mon, 10 Aug 2020 11:20:42 +0300 Message-ID: <87tuxaj4it.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg KH , dri-devel , armijn@tjaldur.nl, Krzysztof Kozlowski , Thomas Zimmermann , Alex Deucher , Dave Airlie , stable , Emil Velikov , Thomas Gleixner , Gerd Hoffmann Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gU2F0LCAwOCBBdWcgMjAyMCwgU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJvcmcub3JnPiB3cm90 ZToKPiBIaSBEYW5pZWwuCj4KPiBPbiBTYXQsIEF1ZyAwOCwgMjAyMCBhdCAxMToxMzo1NEFNICsw MjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+PiBPbiBGcmksIEF1ZyA3LCAyMDIwIGF0IDM6NTQg UE0gVGhvbWFzIFppbW1lcm1hbm4gPHR6aW1tZXJtYW5uQHN1c2UuZGU+IHdyb3RlOgo+PiA+Cj4+ ID4gSGkKPj4gPgo+PiA+IEFtIDA3LjA4LjIwIHVtIDE1OjMwIHNjaHJpZWIgZ3JlZ2toQGxpbnV4 Zm91bmRhdGlvbi5vcmc6Cj4+ID4gPiBUaGUgcGF0Y2ggYmVsb3cgd2FzIHN1Ym1pdHRlZCB0byBi ZSBhcHBsaWVkIHRvIHRoZSA1Ljgtc3RhYmxlIHRyZWUuCj4+ID4gPgo+PiA+ID4gSSBmYWlsIHRv IHNlZSBob3cgdGhpcyBwYXRjaCBtZWV0cyB0aGUgc3RhYmxlIGtlcm5lbCBydWxlcyBhcyBmb3Vu ZCBhdAo+PiA+ID4gRG9jdW1lbnRhdGlvbi9wcm9jZXNzL3N0YWJsZS1rZXJuZWwtcnVsZXMucnN0 Lgo+PiA+ID4KPj4gPiA+IEkgY291bGQgYmUgdG90YWxseSB3cm9uZywgYW5kIGlmIHNvLCBwbGVh c2UgcmVzcG9uZCB0bwo+PiA+ID4gPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+IGFuZCBsZXQgbWUg a25vdyB3aHkgdGhpcyBwYXRjaCBzaG91bGQgYmUKPj4gPiA+IGFwcGxpZWQuICBPdGhlcndpc2Us IGl0IGlzIG5vdyBkcm9wcGVkIGZyb20gbXkgcGF0Y2ggcXVldWVzLCBuZXZlciB0byBiZQo+PiA+ ID4gc2VlbiBhZ2Fpbi4KPj4gPgo+PiA+IFNvcnJ5IGZvciB0aGUgbm9pc2UuIFRoZXJlJ3Mgbm8g cmVhc29uIHRoaXMgc2hvdWxkIGdvIGludG8gc3RhYmxlLgo+PiAKPj4gV2UgaGF2ZSBhIGxpdHRs ZSBzY3JpcHQgaW4gb3VyIG1haW50YWluZXIgdG9vbGJveCBmb3IgYnVnZml4ZXMsIHdoaWNoCj4+ IGdlbmVyYXRlcyB0aGUgRml4ZXM6IGxpbmUsIGFkZHMgZXZlcnlvbmUgZnJvbSB0aGUgb3JpZ2lu YWwgY29tbWl0IHRvCj4+IHRoZSBjYzogbGlzdCBhbmQgYWxzbyBhZGRzIENjOiBzdGFibGUgaWYg dGhhdCBzaGExIHRoZSBwYXRjaCBmaXhlcyBpcwo+PiBpbiBhIHJlbGVhc2UgYWxyZWFkeS4KPj4g Cj4+IEkgZ3Vlc3Mgd2UgdHJhaW5lZCBwZW9wbGUgYSBiaXQgdG9vIG11Y2ggb24gdXNpbmcgRml4 ZXM6IHRhZ3MgbGlrZQo+PiB0aGF0IHdpdGggdGhlIHRvb2xpbmcsIHNpbmNlIHRoZXkgb2Z0ZW4g ZG8gdGhhdCBmb3IgY2hlY2twYXRjaCBzdHVmZgo+PiBhbmQgc3BlbGxpbmcgZml4ZXMgbGlrZSB0 aGlzIGhlcmUgdG9vLiBJIHRoaW5rIHRoZSBhdXRvc2VsZWN0IGJvdCBhbHNvCj4+IGxvdmVzIEZp eGVzOiB0YWdzIGEgYml0IHRvbyBtdWNoIGZvciBpdHMgb3duIGdvb2QuCj4+IAo+PiBOb3Qgc3Vy ZSB3aGF0IHRvIGRvLCBzaW5jZSB0ZWxsaW5nIHBlb3BsZSB0byAicGxlYXNlIHNwcmlua2xlIGxl c3MKPj4gRml4ZXM6IHRhZ3MiIGRvZXNuJ3Qgc291bmQgZ3JlYXQgZWl0aGVyLgo+Cj4gV2Uga25v dyB0aGF0IGF0IGxvdCBvZiB0aGUgZHJtIHBlb3BsZSB1c2VzICJkaW0gZml4ZXMiLgo+IFNvIG1h eWJlIHRlYWNoIHRoZW0gYSBsaXR0ZSBoZXJlPwo+Cj4gZGlmZiAtLWdpdCBhL2RpbSBiL2RpbQo+ IGluZGV4IGU0ZjRkMmUuLmQ0ZmQzMTAgMTAwNzU1Cj4gLS0tIGEvZGltCj4gKysrIGIvZGltCj4g QEAgLTI0MjgsNiArMjQyOCwxMCBAQCBmdW5jdGlvbiBkaW1fZml4ZXMKPiAgCj4gIAlzaGExPSR7 MTo/JHVzYWdlfQo+ICAKPiArCWVjaG8gIiIKPiArCWVjaG8gIk5vdGU6IFBhdGNoIG11c3QgbWVl dCB0aGUgc3RhYmxlLWtlcm5lbC1ydWxlcyBjcml0ZXJpYXMgKERvY3VtZW50YXRpb24vcHJvY2Vz cy9zdGFibGUta2VybmVsLXJ1bGVzLnJzdCkiCj4gKwllY2hvICIiCj4gKwoKSSBkb24ndCB0aGlu ayB0aGlzIGlzIHJpZ2h0LCBiZWNhdXNlIHdlIGFsc28gdXNlIEZpeGVzOiB0byByZWZlciB0bwpj b21taXRzIHRoYXQgaGF2ZW4ndCBldmVuIGJlZW4gbWVyZ2VkIHVwc3RyZWFtIHlldCwgaS5lLiBj b21taXRzIHRoYXQKYXJlIGluIHRoZSAtbmV4dCBmZWF0dXJlIGJyYW5jaGVzLCBhbmQgdGhlIHN0 YWJsZSBrZXJuZWwgcnVsZXMgZG8gbm90CmFwcGx5LgoKQlIsCkphbmkuCgoKCgoKPiAgCWNkICRE SU1fUFJFRklYLyRESU1fUkVQTwo+ICAJZWNobyAiRml4ZXM6ICQoZGltX2NpdGUgJHNoYTEpIgo+ ICAKPgo+IE91dHB1dCB3b3VsZCB0aGVuIGxvb2sgbGlrZSB0aGlzOgo+Cj4gJCBkaW0gZml4ZXMg MWQ4ZDQyYmEzNjUxMDFmYTY4ZDIxMGMwZTJlZDJiYzk1ODJmZGE2Ywo+Cj4gTm90ZTogUGF0Y2gg bXVzdCBtZWV0IHRoZSBzdGFibGUta2VybmVsLXJ1bGVzIGNyaXRlcmlhcyAoRG9jdW1lbnRhdGlv bi9wcm9jZXNzL3N0YWJsZS1rZXJuZWwtcnVsZXMucnN0KQo+Cj4gRml4ZXM6IDFkOGQ0MmJhMzY1 MSAoImRybS9tZ2FnMjAwOiBSZW1vdmUgZGVjbGFyYXRpb24gb2YgbWdhZzIwMF9tbWFwKCkgZnJv bSBoZWFkZXIgZmlsZSIpCj4gQ2M6IFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNl LmRlPgo+IENjOiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cj4gQ2M6IEdlcmQgSG9m Zm1hbm4gPGtyYXhlbEByZWRoYXQuY29tPgo+IENjOiBEYXZlIEFpcmxpZSA8YWlybGllZEByZWRo YXQuY29tPgo+IENjOiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+Cj4gQ2M6 IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IEdyZWcgS3JvYWgt SGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gQ2M6IFRob21hcyBHbGVpeG5l ciA8dGdseEBsaW51dHJvbml4LmRlPgo+IENjOiAiTm9yYWxmIFRyw7hubmVzIiA8bm9yYWxmQHRy b25uZXMub3JnPgo+IENjOiBBcm1pam4gSGVtZWwgPGFybWlqbkB0amFsZHVyLm5sPgo+IENjOiBB bGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gQ2M6IEVtaWwgVmVsaWtv diA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwu b3JnPiAjIHY1LjMrCj4gQ2M6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+Cj4KPiBObyBn dWFyYW50ZWUgdGhhdCBwZW9wbGUgd2lsbCBsb29rIHVwIHRoZSBydWxlcyBvdXRsaW5lZCBpbgo+ IHN0YWJsZS1rZXJuZWwtcnVsZXMucnN0IC0gYnV0IGF0IGxlYXN0IGEgcmVtaW5kZXIuCj4KPiAJ U2FtCj4KPj4gSSBhbHNvIGRvbid0IHdhbnQgdG8gdGVsbAo+PiBwZW9wbGUgdG8gdXNlIHRoZSBt YWludGFpbmVyIHRvb2xib3ggbGVzcywgdGhlIGF1dG9nZW5lcmF0ZWQgY2M6IGxpc3QKPj4gaXMg Z2VuZXJhbGx5IHRoZSByaWdodCB0aGluZyB0byBkby4gTWF5YmUgYmVzdCBpZiB0aGUgc3RhYmxl IHRlYW0KPj4gY2F0Y2hlcyB0aGUgb2J2aW91cyBvbmVzIGJlZm9yZSBhZGRpbmcgdGhlbSB0byB0 aGUgc3RhYmxlIHF1ZXVlLCBpZgo+PiB5b3UncmUgb2sgd2l0aCB0aGF0IEdyZWc/Cj4+IAo+PiBB bHNvIGFkZGluZyBkcmktZGV2ZWwgaGVyZSBpbiBjYXNlIHRoaXMgYmVjb21lcyBhIGJpZ2dlciBk aXNjdXNzaW9uLgo+PiAKPj4gQ2hlZXJzLCBEYW5pZWwKPj4gCj4+ID4KPj4gPiBCZXN0IHJlZ2Fy ZHMKPj4gPiBUaG9tYXMKPj4gPgo+PiA+ID4KPj4gPiA+IHRoYW5rcywKPj4gPiA+Cj4+ID4gPiBn cmVnIGstaAo+PiA+ID4KPj4gPiA+IC0tLS0tLS0tLS0tLS0tLS0tLSBvcmlnaW5hbCBjb21taXQg aW4gTGludXMncyB0cmVlIC0tLS0tLS0tLS0tLS0tLS0tLQo+PiA+ID4KPj4gPiA+IEZyb20gMWQ4 ZDQyYmEzNjUxMDFmYTY4ZDIxMGMwZTJlZDJiYzk1ODJmZGE2YyBNb24gU2VwIDE3IDAwOjAwOjAw IDIwMDEKPj4gPiA+IEZyb206IFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRl Pgo+PiA+ID4gRGF0ZTogRnJpLCA1IEp1biAyMDIwIDE1OjU3OjUwICswMjAwCj4+ID4gPiBTdWJq ZWN0OiBbUEFUQ0hdIGRybS9tZ2FnMjAwOiBSZW1vdmUgZGVjbGFyYXRpb24gb2YgbWdhZzIwMF9t bWFwKCkgZnJvbSBoZWFkZXIKPj4gPiA+ICBmaWxlCj4+ID4gPiBNSU1FLVZlcnNpb246IDEuMAo+ PiA+ID4gQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04Cj4+ID4gPiBDb250 ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0Cj4+ID4gPgo+PiA+ID4gQ29tbWl0IDk0NjY4YWM3 OTZhNSAoImRybS9tZ2FnMjAwOiBDb252ZXJ0IG1nYWcyMDAgZHJpdmVyIHRvIFZSQU0gTU0iKQo+ PiA+ID4gcmVtb3ZlZCB0aGUgaW1wbGVtZW50YXRpb24gb2YgbWdhZzIwMF9tbWFwKCkuIEFsc28g cmVtb3ZlIHRoZSBkZWNsYXJhdGlvbi4KPj4gPiA+Cj4+ID4gPiBTaWduZWQtb2ZmLWJ5OiBUaG9t YXMgWmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KPj4gPiA+IEFja2VkLWJ5OiBTYW0g UmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cj4+ID4gPiBGaXhlczogOTQ2NjhhYzc5NmE1ICgi ZHJtL21nYWcyMDA6IENvbnZlcnQgbWdhZzIwMCBkcml2ZXIgdG8gVlJBTSBNTSIpCj4+ID4gPiBD YzogR2VyZCBIb2ZmbWFubiA8a3JheGVsQHJlZGhhdC5jb20+Cj4+ID4gPiBDYzogRGF2ZSBBaXJs aWUgPGFpcmxpZWRAcmVkaGF0LmNvbT4KPj4gPiA+IENjOiBLcnp5c3p0b2YgS296bG93c2tpIDxr cnprQGtlcm5lbC5vcmc+Cj4+ID4gPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm ZndsbC5jaD4KPj4gPiA+IENjOiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cj4+ID4g PiBDYzogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPj4g PiA+IENjOiBUaG9tYXMgR2xlaXhuZXIgPHRnbHhAbGludXRyb25peC5kZT4KPj4gPiA+IENjOiAi Tm9yYWxmIFRyw7hubmVzIiA8bm9yYWxmQHRyb25uZXMub3JnPgo+PiA+ID4gQ2M6IEFybWlqbiBI ZW1lbCA8YXJtaWpuQHRqYWxkdXIubmw+Cj4+ID4gPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5k ZXIuZGV1Y2hlckBhbWQuY29tPgo+PiA+ID4gQ2M6IEVtaWwgVmVsaWtvdiA8ZW1pbC52ZWxpa292 QGNvbGxhYm9yYS5jb20+Cj4+ID4gPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjUu MysKPj4gPiA+IExpbms6IGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9t c2dpZC8yMDIwMDYwNTEzNTgwMy4xOTgxMS0yLXR6aW1tZXJtYW5uQHN1c2UuZGUKPj4gPiA+Cj4+ ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9kcnYuaCBi L2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBfZHJ2LmgKPj4gPiA+IGluZGV4IDQ3ZGY2 MmIxYWQyOS4uOTJiNjY3OTAyOWZlIDEwMDY0NAo+PiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L21nYWcyMDAvbWdhZzIwMF9kcnYuaAo+PiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21nYWcy MDAvbWdhZzIwMF9kcnYuaAo+PiA+ID4gQEAgLTE5OCw2ICsxOTgsNSBAQCB2b2lkIG1nYWcyMDBf aTJjX2Rlc3Ryb3koc3RydWN0IG1nYV9pMmNfY2hhbiAqaTJjKTsKPj4gPiA+Cj4+ID4gPiAgaW50 IG1nYWcyMDBfbW1faW5pdChzdHJ1Y3QgbWdhX2RldmljZSAqbWRldik7Cj4+ID4gPiAgdm9pZCBt Z2FnMjAwX21tX2Zpbmkoc3RydWN0IG1nYV9kZXZpY2UgKm1kZXYpOwo+PiA+ID4gLWludCBtZ2Fn MjAwX21tYXAoc3RydWN0IGZpbGUgKmZpbHAsIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hKTsK Pj4gPiA+Cj4+ID4gPiAgI2VuZGlmICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8qIF9f TUdBRzIwMF9EUlZfSF9fICovCj4+ID4gPgo+PiA+Cj4+ID4gLS0KPj4gPiBUaG9tYXMgWmltbWVy bWFubgo+PiA+IEdyYXBoaWNzIERyaXZlciBEZXZlbG9wZXIKPj4gPiBTVVNFIFNvZnR3YXJlIFNv bHV0aW9ucyBHZXJtYW55IEdtYkgKPj4gPiBNYXhmZWxkc3RyLiA1LCA5MDQwOSBOw7xybmJlcmcs IEdlcm1hbnkKPj4gPiAoSFJCIDM2ODA5LCBBRyBOw7xybmJlcmcpCj4+ID4gR2VzY2jDpGZ0c2bD vGhyZXI6IEZlbGl4IEltZW5kw7ZyZmZlcgo+PiA+Cj4+IAo+PiAKPj4gLS0gCj4+IERhbmllbCBW ZXR0ZXIKPj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCj4+IGh0dHA6Ly9i bG9nLmZmd2xsLmNoCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENl bnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 375B3C433E0 for ; Mon, 10 Aug 2020 08:21:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D3B7206B5 for ; Mon, 10 Aug 2020 08:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725857AbgHJIVH convert rfc822-to-8bit (ORCPT ); Mon, 10 Aug 2020 04:21:07 -0400 Received: from mga07.intel.com ([134.134.136.100]:26236 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbgHJIVH (ORCPT ); Mon, 10 Aug 2020 04:21:07 -0400 IronPort-SDR: ypDB3n7jei/ZvesZ85Aa8R2rF9BvtiLHPEkJcdy7fpGlCp5+//ConiDHss0XdfeDpUmZbNKHX/ mjEmWJZqT28Q== X-IronPort-AV: E=McAfee;i="6000,8403,9708"; a="217835171" X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="217835171" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 01:20:49 -0700 IronPort-SDR: WvpZDOMWzYWGf+fT0WgbLG/tj2t0mDpbX/dcZ77WSwnbgHBmAO1HpylnapqyTiku2cXGwAMka8 yw+bBK2dTpBg== X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="494719354" Received: from unknown (HELO localhost) ([10.249.44.171]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 01:20:45 -0700 From: Jani Nikula To: Sam Ravnborg , Daniel Vetter Cc: Krzysztof Kozlowski , Greg KH , dri-devel , armijn@tjaldur.nl, Gerd Hoffmann , Thomas Zimmermann , Alex Deucher , Dave Airlie , stable , Thomas Gleixner , Emil Velikov Subject: Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree? In-Reply-To: <20200808093708.GA14702@ravnborg.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <159680700523135@kroah.com> <20200808093708.GA14702@ravnborg.org> Date: Mon, 10 Aug 2020 11:20:42 +0300 Message-ID: <87tuxaj4it.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sat, 08 Aug 2020, Sam Ravnborg wrote: > Hi Daniel. > > On Sat, Aug 08, 2020 at 11:13:54AM +0200, Daniel Vetter wrote: >> On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann wrote: >> > >> > Hi >> > >> > Am 07.08.20 um 15:30 schrieb gregkh@linuxfoundation.org: >> > > The patch below was submitted to be applied to the 5.8-stable tree. >> > > >> > > I fail to see how this patch meets the stable kernel rules as found at >> > > Documentation/process/stable-kernel-rules.rst. >> > > >> > > I could be totally wrong, and if so, please respond to >> > > and let me know why this patch should be >> > > applied. Otherwise, it is now dropped from my patch queues, never to be >> > > seen again. >> > >> > Sorry for the noise. There's no reason this should go into stable. >> >> We have a little script in our maintainer toolbox for bugfixes, which >> generates the Fixes: line, adds everyone from the original commit to >> the cc: list and also adds Cc: stable if that sha1 the patch fixes is >> in a release already. >> >> I guess we trained people a bit too much on using Fixes: tags like >> that with the tooling, since they often do that for checkpatch stuff >> and spelling fixes like this here too. I think the autoselect bot also >> loves Fixes: tags a bit too much for its own good. >> >> Not sure what to do, since telling people to "please sprinkle less >> Fixes: tags" doesn't sound great either. > > We know that at lot of the drm people uses "dim fixes". > So maybe teach them a litte here? > > diff --git a/dim b/dim > index e4f4d2e..d4fd310 100755 > --- a/dim > +++ b/dim > @@ -2428,6 +2428,10 @@ function dim_fixes > > sha1=${1:?$usage} > > + echo "" > + echo "Note: Patch must meet the stable-kernel-rules criterias (Documentation/process/stable-kernel-rules.rst)" > + echo "" > + I don't think this is right, because we also use Fixes: to refer to commits that haven't even been merged upstream yet, i.e. commits that are in the -next feature branches, and the stable kernel rules do not apply. BR, Jani. > cd $DIM_PREFIX/$DIM_REPO > echo "Fixes: $(dim_cite $sha1)" > > > Output would then look like this: > > $ dim fixes 1d8d42ba365101fa68d210c0e2ed2bc9582fda6c > > Note: Patch must meet the stable-kernel-rules criterias (Documentation/process/stable-kernel-rules.rst) > > Fixes: 1d8d42ba3651 ("drm/mgag200: Remove declaration of mgag200_mmap() from header file") > Cc: Thomas Zimmermann > Cc: Sam Ravnborg > Cc: Gerd Hoffmann > Cc: Dave Airlie > Cc: Krzysztof Kozlowski > Cc: Daniel Vetter > Cc: Greg Kroah-Hartman > Cc: Thomas Gleixner > Cc: "Noralf Trønnes" > Cc: Armijn Hemel > Cc: Alex Deucher > Cc: Emil Velikov > Cc: # v5.3+ > Cc: Lyude Paul > > No guarantee that people will look up the rules outlined in > stable-kernel-rules.rst - but at least a reminder. > > Sam > >> I also don't want to tell >> people to use the maintainer toolbox less, the autogenerated cc: list >> is generally the right thing to do. Maybe best if the stable team >> catches the obvious ones before adding them to the stable queue, if >> you're ok with that Greg? >> >> Also adding dri-devel here in case this becomes a bigger discussion. >> >> Cheers, Daniel >> >> > >> > Best regards >> > Thomas >> > >> > > >> > > thanks, >> > > >> > > greg k-h >> > > >> > > ------------------ original commit in Linus's tree ------------------ >> > > >> > > From 1d8d42ba365101fa68d210c0e2ed2bc9582fda6c Mon Sep 17 00:00:00 2001 >> > > From: Thomas Zimmermann >> > > Date: Fri, 5 Jun 2020 15:57:50 +0200 >> > > Subject: [PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header >> > > file >> > > MIME-Version: 1.0 >> > > Content-Type: text/plain; charset=UTF-8 >> > > Content-Transfer-Encoding: 8bit >> > > >> > > Commit 94668ac796a5 ("drm/mgag200: Convert mgag200 driver to VRAM MM") >> > > removed the implementation of mgag200_mmap(). Also remove the declaration. >> > > >> > > Signed-off-by: Thomas Zimmermann >> > > Acked-by: Sam Ravnborg >> > > Fixes: 94668ac796a5 ("drm/mgag200: Convert mgag200 driver to VRAM MM") >> > > Cc: Gerd Hoffmann >> > > Cc: Dave Airlie >> > > Cc: Krzysztof Kozlowski >> > > Cc: Daniel Vetter >> > > Cc: Sam Ravnborg >> > > Cc: Greg Kroah-Hartman >> > > Cc: Thomas Gleixner >> > > Cc: "Noralf Trønnes" >> > > Cc: Armijn Hemel >> > > Cc: Alex Deucher >> > > Cc: Emil Velikov >> > > Cc: # v5.3+ >> > > Link: https://patchwork.freedesktop.org/patch/msgid/20200605135803.19811-2-tzimmermann@suse.de >> > > >> > > diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h >> > > index 47df62b1ad29..92b6679029fe 100644 >> > > --- a/drivers/gpu/drm/mgag200/mgag200_drv.h >> > > +++ b/drivers/gpu/drm/mgag200/mgag200_drv.h >> > > @@ -198,6 +198,5 @@ void mgag200_i2c_destroy(struct mga_i2c_chan *i2c); >> > > >> > > int mgag200_mm_init(struct mga_device *mdev); >> > > void mgag200_mm_fini(struct mga_device *mdev); >> > > -int mgag200_mmap(struct file *filp, struct vm_area_struct *vma); >> > > >> > > #endif /* __MGAG200_DRV_H__ */ >> > > >> > >> > -- >> > Thomas Zimmermann >> > Graphics Driver Developer >> > SUSE Software Solutions Germany GmbH >> > Maxfeldstr. 5, 90409 Nürnberg, Germany >> > (HRB 36809, AG Nürnberg) >> > Geschäftsführer: Felix Imendörffer >> > >> >> >> -- >> Daniel Vetter >> Software Engineer, Intel Corporation >> http://blog.ffwll.ch > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center