From: Jani Nikula <jani.nikula@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: Benjamin Berg <bberg@redhat.com>,
Christian Kellner <ckellner@redhat.com>,
Javier Martinez Canillas <javierm@redhat.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Nitin Joshi1 <njoshi1@lenovo.com>,
Rajat Jain <rajatja@google.com>,
Mark Pearson <mpearson@lenovo.com>
Subject: Re: RFC: Drm-connector properties managed by another driver / privacy screen support
Date: Wed, 15 Apr 2020 18:28:21 +0300 [thread overview]
Message-ID: <87tv1k4vl6.fsf@intel.com> (raw)
In-Reply-To: <783240e9-e8d1-fc28-6c11-14c8f8e35cfa@redhat.com>
On Wed, 15 Apr 2020, Hans de Goede <hdegoede@redhat.com> wrote:
> ii. Currently the "privacy-screen" property added by Rajat's
> patch-set is an enum with 2 possible values:
> "Enabled"
> "Disabled"
>
> We could add a third value "Not Available", which would be the
> default and then for internal panels always add the property
> so that we avoid the problem that detecting if the laptop has
> an internal privacy screen needs to be done before the connector
> is registered. Then we can add some hooks which allow an
> lcdshadow-driver to register itself against a connector later
> (which is non trivial wrt probe order, but lets ignore that for now).
I regret dropping the ball on Rajat's series (sorry!).
I do think having the connector property for this is the way to go. Even
if we couldn't necessarily figure out all the details on the kernel
internal connections, can we settle on the property though, so we could
move forward with Rajat's series?
Moreover, do we actually need two properties, one which could indicate
userspace's desire for the property, and another that tells the hardware
state? I'd so very much like to have no in-kernel/in-firmware shortcuts
to enable/disable the privacy screen, and instead have any hardware
buttons just be events that the userspace could react to. However I
don't think that'll be the case unfortunately.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-15 15:28 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 9:42 RFC: Drm-connector properties managed by another driver / privacy screen support Hans de Goede
2020-04-15 9:52 ` Daniel Vetter
2020-04-15 10:11 ` Hans de Goede
2020-04-15 10:22 ` Daniel Vetter
2020-04-15 11:39 ` Hans de Goede
2020-04-15 11:56 ` Hans de Goede
2020-04-15 12:01 ` Daniel Vetter
2020-04-15 13:02 ` Hans de Goede
2020-04-15 17:54 ` Daniel Vetter
2020-04-15 18:19 ` Hans de Goede
2020-04-15 18:29 ` Daniel Vetter
2020-04-15 19:50 ` Hans de Goede
2020-04-16 6:46 ` Daniel Vetter
2020-04-15 15:28 ` Jani Nikula [this message]
2020-04-15 15:40 ` Hans de Goede
2020-04-15 17:14 ` [External] " Mark Pearson
2020-04-15 18:06 ` Hans de Goede
2020-04-15 19:20 ` Rajat Jain
2020-04-15 21:10 ` Jani Nikula
2020-04-15 21:21 ` Hans de Goede
2020-04-15 21:51 ` [External] " Mark Pearson
2020-04-17 9:05 ` Pekka Paalanen
2020-04-17 9:02 ` Pekka Paalanen
2020-04-17 11:55 ` Jani Nikula
2020-04-17 14:18 ` Daniel Vetter
2020-04-17 14:54 ` Benjamin Berg
2020-04-21 12:37 ` Hans de Goede
2020-04-21 12:40 ` Daniel Vetter
2020-04-21 14:46 ` Pekka Paalanen
2020-04-23 18:21 ` Rajat Jain
2020-04-24 7:40 ` Pekka Paalanen
2020-04-24 8:24 ` Hans de Goede
2020-04-24 9:08 ` Pekka Paalanen
2020-04-24 10:32 ` Hans de Goede
2020-04-17 14:17 ` Daniel Vetter
2020-04-20 8:27 ` Operating KMS UAPI (Re: RFC: Drm-connector properties managed by another driver / privacy screen support) Pekka Paalanen
2020-04-20 10:04 ` Pekka Paalanen
2020-04-20 10:18 ` Simon Ser
2020-04-21 12:15 ` Daniel Vetter
2020-04-21 14:33 ` Pekka Paalanen
2020-04-21 14:39 ` Simon Ser
2020-04-23 15:01 ` Daniel Vetter
2020-04-24 8:32 ` Pekka Paalanen
2020-04-28 14:51 ` Daniel Vetter
2020-04-29 10:07 ` Pekka Paalanen
2020-04-30 13:53 ` Daniel Vetter
2020-05-04 9:49 ` Pekka Paalanen
2020-05-04 11:00 ` Daniel Vetter
2020-05-04 12:22 ` Pekka Paalanen
2020-05-05 8:48 ` Daniel Vetter
2020-05-07 9:03 ` Pekka Paalanen
2020-04-20 10:15 ` Simon Ser
2020-04-20 12:22 ` Pekka Paalanen
2020-04-20 12:33 ` Simon Ser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv1k4vl6.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=bberg@redhat.com \
--cc=ckellner@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=javierm@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mpearson@lenovo.com \
--cc=mripard@kernel.org \
--cc=njoshi1@lenovo.com \
--cc=rajatja@google.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.