From: Kalle Valo <kvalo@codeaurora.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Wireless <linux-wireless@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
Date: Wed, 15 Apr 2020 07:45:06 +0300 [thread overview]
Message-ID: <87tv1ls6gd.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200415110649.39e26be3@canb.auug.org.au> (Stephen Rothwell's message of "Wed, 15 Apr 2020 11:06:49 +1000")
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi Larry,
>
> On Tue, 14 Apr 2020 19:36:28 -0500 Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>> On 4/14/20 5:08 PM, Stephen Rothwell wrote:
>> >
>> > In commit
>> >
>> > ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
>> >
>> > Fixes tag
>> >
>> > Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
>> >
>> > has these problem(s):
>> >
>> > - Subject does not match target commit subject
>> > Just use
>> > git log -1 --format='Fixes: %h ("%s")'
>>
>> I do not understand what you want here. The subject describes what was fixed.
>> The error has been in the driver since it was merged. The Fixes: line is a
>> description of the commit that introduced the driver file with the error.
>
> The subject I was referring to is the subject quoted in the Fixes tag,
> not the subject of the fixing commit. So:
>
> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for
> legacy BCM43xx devices")
>
> Its not very important, just a consistency thing - I wouldn't bother
> rebasing just to fix this, just for the future ...
Yeah, I don't normally rebase wireless-drivers-next so this has to be
like this. But hopefully some time in the future I'll end up adding a
check for this in my patchwork script.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-15 4:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 22:08 linux-next: Fixes tag needs some work in the wireless-drivers-next tree Stephen Rothwell
2020-04-15 0:36 ` Larry Finger
2020-04-15 1:06 ` Stephen Rothwell
2020-04-15 4:45 ` Kalle Valo [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-18 22:33 Stephen Rothwell
2020-08-19 6:52 ` Kalle Valo
2020-08-19 8:13 ` Stephen Rothwell
2020-09-24 16:11 ` Kalle Valo
2020-08-02 22:03 Stephen Rothwell
2020-08-04 13:17 ` Kalle Valo
2020-07-14 10:59 Stephen Rothwell
2020-07-14 17:49 ` Kalle Valo
2020-05-18 13:01 Stephen Rothwell
2020-05-19 8:50 ` Kalle Valo
2020-01-27 0:42 Stephen Rothwell
2020-01-29 14:05 ` Kalle Valo
2019-07-01 21:33 Stephen Rothwell
2019-07-02 4:26 ` dundi
2019-06-30 21:44 Stephen Rothwell
2019-07-01 10:35 ` Lorenzo Bianconi
2019-05-27 21:48 Stephen Rothwell
2019-05-27 21:48 ` Stephen Rothwell
2019-05-01 21:50 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv1ls6gd.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.