From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC4AC43331 for ; Thu, 26 Mar 2020 13:16:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64D062073E for ; Thu, 26 Mar 2020 13:16:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64D062073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 15E56898A4; Thu, 26 Mar 2020 13:16:25 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA380898A4 for ; Thu, 26 Mar 2020 13:16:23 +0000 (UTC) IronPort-SDR: eiIJ1TjU3GW75ph8S2lAtrI2HJwH38V+8RWywOayAtYGRLjnra53nCzJQo0mI+7ATZgQ+rriqu 2xUBNypDECCA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 06:16:23 -0700 IronPort-SDR: Klu7lS08ojMMqgMWZXY5FzwvbkPMwDjaeh4JLIt17976BVHHSB/ftukENiQ3YF3UCj4x4NUx0Z YF+ClxGRQ+eA== X-IronPort-AV: E=Sophos;i="5.72,308,1580803200"; d="scan'208";a="393976097" Received: from mschuste-mobl3.ger.corp.intel.com (HELO localhost) ([10.252.32.130]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 06:16:21 -0700 From: Jani Nikula To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200325140754.12636-1-chris@chris-wilson.co.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200325140754.12636-1-chris@chris-wilson.co.uk> Date: Thu, 26 Mar 2020 15:16:18 +0200 Message-ID: <87tv2bgst9.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 25 Mar 2020, Chris Wilson wrote: > Avoid using the uninitialised len along the impossible error path to > shut the compiler up: > > drivers/gpu/drm/i915/display/intel_dp.c:4928 intel_write_dp_sdp() error: uninitialized symbol 'len'. Why am I not seeing this? GCC 8.3.0 Reviewed-by: Jani Nikula Tpyo in the subject. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 7f1a4e55cda1..c33a39065704 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -4922,7 +4922,7 @@ static void intel_write_dp_sdp(struct intel_encoder *encoder, > break; > default: > MISSING_CASE(type); > - break; > + return; > } > > if (drm_WARN_ON(&dev_priv->drm, len < 0)) -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx