From: Jani Nikula <jani.nikula@linux.intel.com>
To: Kishore Kadiyala <kishore.kadiyala@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Kishore Kadiyala <kishore.kadiyala@intel.com>
Subject: Re: [Intel-gfx] [PATCH] Add support for Color encoding YCBCR_BT2020
Date: Fri, 14 Feb 2020 13:25:56 +0200 [thread overview]
Message-ID: <87tv3twgu3.fsf@intel.com> (raw)
In-Reply-To: <20200214105316.16076-1-kishore.kadiyala@intel.com>
On Fri, 14 Feb 2020, Kishore Kadiyala <kishore.kadiyala@intel.com> wrote:
> Currently the plane property doesn't have support for YCBCR_BT2020,
> which enables the corresponding color conversion mode on plane CSC.
Please prefix your patch subjects properly. "drm/i915: " at a minimum
for stuff touching i915.
No need to resend for this, but for future reference.
BR,
Jani.
>
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_sprite.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> index 7abeefe8dce5..5169a7260d7c 100644
> --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> @@ -3011,6 +3011,7 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
> struct intel_plane *plane;
> enum drm_plane_type plane_type;
> unsigned int supported_rotations;
> + unsigned int supported_csc;
> unsigned int possible_crtcs;
> const u64 *modifiers;
> const u32 *formats;
> @@ -3088,9 +3089,13 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
> DRM_MODE_ROTATE_0,
> supported_rotations);
>
> + supported_csc = BIT(DRM_COLOR_YCBCR_BT601) | BIT(DRM_COLOR_YCBCR_BT709);
> +
> + if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
> + supported_csc |= BIT(DRM_COLOR_YCBCR_BT2020);
> +
> drm_plane_create_color_properties(&plane->base,
> - BIT(DRM_COLOR_YCBCR_BT601) |
> - BIT(DRM_COLOR_YCBCR_BT709),
> + supported_csc,
> BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |
> BIT(DRM_COLOR_YCBCR_FULL_RANGE),
> DRM_COLOR_YCBCR_BT709,
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-14 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 10:53 [Intel-gfx] [PATCH] Add support for Color encoding YCBCR_BT2020 Kishore Kadiyala
2020-02-14 11:25 ` Jani Nikula [this message]
2020-02-17 3:09 ` Kadiyala, Kishore
2020-02-14 12:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-14 13:10 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2020-02-14 14:27 ` Shankar, Uma
2020-02-14 14:32 ` Ville Syrjälä
2020-02-14 14:57 ` Shankar, Uma
2020-02-17 18:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv3twgu3.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kishore.kadiyala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.