From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9B48C352A3 for ; Thu, 13 Feb 2020 21:03:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AF42206B6 for ; Thu, 13 Feb 2020 21:03:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AF42206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2394F6E40B; Thu, 13 Feb 2020 21:03:08 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFE8A6E40B for ; Thu, 13 Feb 2020 21:03:06 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 13:03:05 -0800 X-IronPort-AV: E=Sophos;i="5.70,438,1574150400"; d="scan'208";a="227373661" Received: from unknown (HELO localhost) ([10.252.53.8]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 13:03:03 -0800 From: Jani Nikula To: Matt Roper , Stanislav Lisovskiy In-Reply-To: <20200213205650.GJ2014153@mdroper-desk1.amr.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200213140412.32697-1-stanislav.lisovskiy@intel.com> <20200213140412.32697-3-stanislav.lisovskiy@intel.com> <20200213205650.GJ2014153@mdroper-desk1.amr.corp.intel.com> Date: Thu, 13 Feb 2020 23:03:29 +0200 Message-ID: <87tv3uw672.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v1 2/3] drm/i915/dsc: force full modeset whenever DSC is enabled at probe X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 13 Feb 2020, Matt Roper wrote: > On Thu, Feb 13, 2020 at 04:04:11PM +0200, Stanislav Lisovskiy wrote: >> From: Jani Nikula >> >> We lack full state readout of DSC config, which may lead to DSC enable >> using a config that's all zeros, failing spectacularly. Force full >> modeset and thus compute config at probe to get a sane state, until we >> implement DSC state readout. Any fastset that did appear to work with >> DSC at probe, worked by coincidence. [1] is an example of a change that >> triggered the issue on TGL DSI DSC. >> >> [1] http://patchwork.freedesktop.org/patch/msgid/20200212150102.7600-1-ville.syrjala@linux.intel.com >> >> Cc: Manasi Navare >> Cc: Vandita Kulkarni >> Cc: Ville Syrjala >> Cc: stable@vger.kernel.org >> Signed-off-by: Jani Nikula > > Should this be > > Fixes: fbacb15ea814 ("drm/i915/dsc: add basic hardware state readout support") > > since that's where we added the basic readout with a FIXME to add more > later? That added some readout and checks, but the problem existed before them too. BR, Jani. > > I don't know the specifics of DSC and what state we need, but the > approach here seems reasonable. > > Acked-by: Matt Roper > >> --- >> drivers/gpu/drm/i915/display/intel_display.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c >> index 61ba1f2256a0..1e3f2cc27db8 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display.c >> +++ b/drivers/gpu/drm/i915/display/intel_display.c >> @@ -17828,6 +17828,24 @@ static int intel_initial_commit(struct drm_device *dev) >> * have readout for pipe gamma enable. >> */ >> crtc_state->uapi.color_mgmt_changed = true; >> + >> + /* >> + * FIXME hack to force full modeset when DSC is being >> + * used. >> + * >> + * As long as we do not have full state readout and >> + * config comparison of crtc_state->dsc, we have no way >> + * to ensure reliable fastset. Remove once we have >> + * readout for DSC. >> + */ >> + if (crtc_state->dsc.compression_enable) { >> + ret = drm_atomic_add_affected_connectors(state, >> + &crtc->base); >> + if (ret) >> + goto out; >> + crtc_state->uapi.mode_changed = true; >> + drm_dbg_kms(dev, "Force full modeset for DSC\n"); >> + } >> } >> } >> >> -- >> 2.24.1.485.gad05a3d8e5 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx