Re: [PATCH] usb: dwc3: use proper initializers for property entries

[Felipe Balbi <balbi@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]


Hi,

Marek Szyprowski <m.szyprowski@samsung.com> writes:

> Hi All,
>
> On 15.12.2019 17:41, Hans de Goede wrote:
>> Hi,
>>
>> On 13-12-2019 18:46, Dmitry Torokhov wrote:
>>> We should not be reaching into property entries and initialize them by
>>> hand, but rather use proper initializer macros. This way we can alter
>>> internal representation of property entries with no visible changes to
>>> their users.
>>>
>>> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>> ---
>>>
>>> It would be good if this could go through Rafael's tree as it is needed
>>> for the rest of my software_node/property_entry rework patch series
>>> which I would love not to delay till 5.6.
>>
>> Patch looks good to me:
>>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
>
> This patch is instantly needed as the issue it fixes is again triggered 
> in current (20200107) linux-next by commit e6bff4665c59 "software node: 
> replace is_array with is_inline".
>
> Felipe: could You ack it, so it could be merged via Rafael's tree 
> together with related device property changes?

Here you go:

Acked-by: Felipe Balbi <balbi@kernel.org>

cheers

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]