From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A919C43603 for ; Thu, 5 Dec 2019 09:55:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E736324652 for ; Thu, 5 Dec 2019 09:55:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E736324652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 32BF56F637; Thu, 5 Dec 2019 09:55:56 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7364D6F637 for ; Thu, 5 Dec 2019 09:55:55 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 01:55:54 -0800 X-IronPort-AV: E=Sophos;i="5.69,281,1571727600"; d="scan'208";a="205719543" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 01:55:51 -0800 From: Jani Nikula To: Benjamin GAIGNARD , Thomas Zimmermann , "maarten.lankhorst\@linux.intel.com" , "mripard\@kernel.org" , "sean\@poorly.run" , "airlied\@linux.ie" , "daniel\@ffwll.ch" Subject: Re: [PATCH] drm/modes: remove unused variables In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191119134706.10893-1-benjamin.gaignard@st.com> <8056f838-3ebf-26db-f5be-3e78d61aa512@suse.de> Date: Thu, 05 Dec 2019 11:55:48 +0200 Message-ID: <87tv6fgkpn.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAwNCBEZWMgMjAxOSwgQmVuamFtaW4gR0FJR05BUkQgPGJlbmphbWluLmdhaWduYXJk QHN0LmNvbT4gd3JvdGU6Cj4gT24gMTIvNC8xOSAxMDozNSBBTSwgVGhvbWFzIFppbW1lcm1hbm4g d3JvdGU6Cj4+IEhpCj4+Cj4+IEFtIDE5LjExLjE5IHVtIDE0OjQ3IHNjaHJpZWIgQmVuamFtaW4g R2FpZ25hcmQ6Cj4+PiBXaGVuIGNvbXBpbGluZyB3aXRoIFc9MSBmZXcgd2FybmluZ3MgYWJvdXQg dW51c2VkIHZhcmlhYmxlcyBzaG93IHVwLgo+Pj4gVGhpcyBwYXRjaCByZW1vdmVzIGFsbCB0aGUg aW52b2x2ZWQgdmFyaWFibGVzLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEJlbmphbWluIEdhaWdu YXJkIDxiZW5qYW1pbi5nYWlnbmFyZEBzdC5jb20+Cj4+PiAtLS0KPj4+ICAgZHJpdmVycy9ncHUv ZHJtL2RybV9tb2Rlcy5jIHwgMjIgKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+Pj4gICAxIGZpbGUg Y2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9tb2Rlcy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9t b2Rlcy5jCj4+PiBpbmRleCA4ODIzMjY5OGQ3YTAuLmFjYTkwMWFmZjA0MiAxMDA2NDQKPj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fbW9kZXMuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2RybV9tb2Rlcy5jCj4+PiBAQCAtMjMzLDcgKzIzMyw3IEBAIHN0cnVjdCBkcm1fZGlzcGxheV9t b2RlICpkcm1fY3Z0X21vZGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IGhkaXNwbGF5LAo+ Pj4gICAJCS8qIDMpIE5vbWluYWwgSFN5bmMgd2lkdGggKCUgb2YgbGluZSBwZXJpb2QpIC0gZGVm YXVsdCA4ICovCj4+PiAgICNkZWZpbmUgQ1ZUX0hTWU5DX1BFUkNFTlRBR0UJOAo+Pj4gICAJCXVu c2lnbmVkIGludCBoYmxhbmtfcGVyY2VudGFnZTsKPj4+IC0JCWludCB2c3luY2FuZGJhY2tfcG9y Y2gsIHZiYWNrX3BvcmNoLCBoYmxhbms7Cj4+PiArCQlpbnQgdnN5bmNhbmRiYWNrX3BvcmNoLCBo Ymxhbms7Cj4+PiAgIAo+Pj4gICAJCS8qIGVzdGltYXRlZCB0aGUgaG9yaXpvbnRhbCBwZXJpb2Qg Ki8KPj4+ICAgCQl0bXAxID0gSFZfRkFDVE9SICogMTAwMDAwMCAgLQo+Pj4gQEAgLTI0OSw3ICsy NDksNiBAQCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqZHJtX2N2dF9tb2RlKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsIGludCBoZGlzcGxheSwKPj4+ICAgCQllbHNlCj4+PiAgIAkJCXZzeW5jYW5k YmFja19wb3JjaCA9IHRtcDE7Cj4+PiAgIAkJLyogMTAuIEZpbmQgbnVtYmVyIG9mIGxpbmVzIGlu IGJhY2sgcG9yY2ggKi8KPj4+IC0JCXZiYWNrX3BvcmNoID0gdnN5bmNhbmRiYWNrX3BvcmNoIC0g dnN5bmM7Cj4+PiAgIAkJZHJtX21vZGUtPnZ0b3RhbCA9IHZkaXNwbGF5X3JuZCArIDIgKiB2bWFy Z2luICsKPj4+ICAgCQkJCXZzeW5jYW5kYmFja19wb3JjaCArIENWVF9NSU5fVl9QT1JDSDsKPj4+ ICAgCQkvKiA1KSBEZWZpbml0aW9uIG9mIEhvcml6b250YWwgYmxhbmtpbmcgdGltZSBsaW1pdGF0 aW9uICovCj4+PiBAQCAtMzg2LDkgKzM4NSw4IEBAIGRybV9ndGZfbW9kZV9jb21wbGV4KHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIGludCBoZGlzcGxheSwgaW50IHZkaXNwbGF5LAo+Pj4gICAJaW50 IHRvcF9tYXJnaW4sIGJvdHRvbV9tYXJnaW47Cj4+PiAgIAlpbnQgaW50ZXJsYWNlOwo+Pj4gICAJ dW5zaWduZWQgaW50IGhmcmVxX2VzdDsKPj4+IC0JaW50IHZzeW5jX3BsdXNfYnAsIHZiYWNrX3Bv cmNoOwo+Pj4gLQl1bnNpZ25lZCBpbnQgdnRvdGFsX2xpbmVzLCB2ZmllbGRyYXRlX2VzdCwgaHBl cmlvZDsKPj4+IC0JdW5zaWduZWQgaW50IHZmaWVsZF9yYXRlLCB2ZnJhbWVfcmF0ZTsKPj4+ICsJ aW50IHZzeW5jX3BsdXNfYnA7Cj4+PiArCXVuc2lnbmVkIGludCB2dG90YWxfbGluZXM7Cj4+PiAg IAlpbnQgbGVmdF9tYXJnaW4sIHJpZ2h0X21hcmdpbjsKPj4+ICAgCXVuc2lnbmVkIGludCB0b3Rh bF9hY3RpdmVfcGl4ZWxzLCBpZGVhbF9kdXR5X2N5Y2xlOwo+Pj4gICAJdW5zaWduZWQgaW50IGhi bGFuaywgdG90YWxfcGl4ZWxzLCBwaXhlbF9mcmVxOwo+Pj4gQEAgLTQ1MSwyMyArNDQ5LDkgQEAg ZHJtX2d0Zl9tb2RlX2NvbXBsZXgoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IGhkaXNwbGF5 LCBpbnQgdmRpc3BsYXksCj4+PiAgIAkvKiBbViBTWU5DK0JQXSA9IFJJTlQoKFtNSU4gVlNZTkMr QlBdICogaGZyZXFfZXN0IC8gMTAwMDAwMCkpICovCj4+PiAgIAl2c3luY19wbHVzX2JwID0gTUlO X1ZTWU5DX1BMVVNfQlAgKiBoZnJlcV9lc3QgLyAxMDAwOwo+Pj4gICAJdnN5bmNfcGx1c19icCA9 ICh2c3luY19wbHVzX2JwICsgNTAwKSAvIDEwMDA7Cj4+PiAtCS8qICA5LiBGaW5kIHRoZSBudW1i ZXIgb2YgbGluZXMgaW4gViBiYWNrIHBvcmNoIGFsb25lOiAqLwo+Pj4gLQl2YmFja19wb3JjaCA9 IHZzeW5jX3BsdXNfYnAgLSBWX1NZTkNfUlFEOwo+Pj4gICAJLyogIDEwLiBGaW5kIHRoZSB0b3Rh bCBudW1iZXIgb2YgbGluZXMgaW4gVmVydGljYWwgZmllbGQgcGVyaW9kOiAqLwo+Pj4gICAJdnRv dGFsX2xpbmVzID0gdmRpc3BsYXlfcm5kICsgdG9wX21hcmdpbiArIGJvdHRvbV9tYXJnaW4gKwo+ Pj4gICAJCQl2c3luY19wbHVzX2JwICsgR1RGX01JTl9WX1BPUkNIOwo+Pj4gLQkvKiAgMTEuIEVz dGltYXRlIHRoZSBWZXJ0aWNhbCBmaWVsZCBmcmVxdWVuY3k6ICovCj4+PiAtCXZmaWVsZHJhdGVf ZXN0ID0gaGZyZXFfZXN0IC8gdnRvdGFsX2xpbmVzOwo+Pj4gLQkvKiAgMTIuIEZpbmQgdGhlIGFj dHVhbCBob3Jpem9udGFsIHBlcmlvZDogKi8KPj4+IC0JaHBlcmlvZCA9IDEwMDAwMDAgLyAodmZp ZWxkcmF0ZV9ycWQgKiB2dG90YWxfbGluZXMpOwo+Pj4gLQo+Pj4gLQkvKiAgMTMuIEZpbmQgdGhl IGFjdHVhbCBWZXJ0aWNhbCBmaWVsZCBmcmVxdWVuY3k6ICovCj4+PiAtCXZmaWVsZF9yYXRlID0g aGZyZXFfZXN0IC8gdnRvdGFsX2xpbmVzOwo+Pj4gLQkvKiAgMTQuIEZpbmQgdGhlIFZlcnRpY2Fs IGZyYW1lIGZyZXF1ZW5jeTogKi8KPj4+IC0JaWYgKGludGVybGFjZWQpCj4+PiAtCQl2ZnJhbWVf cmF0ZSA9IHZmaWVsZF9yYXRlIC8gMjsKPj4+IC0JZWxzZQo+Pj4gLQkJdmZyYW1lX3JhdGUgPSB2 ZmllbGRfcmF0ZTsKPj4gVGhlIGFtb3VudCBvZiB1bnVzZWQgY29kZSBpcyBxdWl0ZSBsYXJnZSwg d2hpY2ggbWFrZXMgbWUgd29uZGVyIGlmCj4+IHRoZXJlJ3Mgc29tZXRoaW5nIG1pc3NpbmcgYmVs b3cgd2hlcmUgdGhlc2UgdmFyaWFibGVzIGFyZSBzdXBwb3NlZCB0byBiZQo+PiB1c2VkLgo+Pgo+ PiBJZiB0aGVzZSB2YXJpYWJsZXMgY2FuIGJlIHJlbW92ZWQsIGNvbW1lbnRzIHNob3VsZCBtZW50 aW9uIHRoYXQgc3RlcHMgOQo+PiBhbmQgMTEgdG8gMTQgYXJlIGJlaW5nIGxlZnQgb3V0LiBBZnRl ciBhbGwsIHRoZSBmdW5jdGlvbiBpcyBmYWlybHkKPj4gZXhwbGljaXQgYWJvdXQgaW1wbGVtZW50 aW5nIHRoZSBHVEYgYWxnb3JpdGhtIHN0ZXAgYnkgc3RlcC4KPj4KPj4gQmVzdCByZWdhcmRzCj4+ IFRob21hcwo+Cj4gSWYgdGhlIGdvYWwgaXMgdG8ga2VlcCBhbGwgdGhlIHN0ZXBzIHRoZW4gSSBj b3VsZCBwcmVmaXggYWxsIHByb2JsZW1hdGljIAo+IHZhcmlhYmxlcyB3aXRoIF9fbWF5YmVfdW51 c2VkIG1hY3JvLgoKVGhlIGVmZmVjdCBpcyB0aGUgc2FtZTsgaXQgaGlkZXMgYSBwb3RlbnRpYWwg YnVnIHRoYXQgc2hvdWxkIGJlIGFuYWx5emVkCmFuZCBmaXhlZC4gSWYgeW91IGhhdmUgdGhlIHRp bWUsIHBsZWFzZSBsb29rIGF0IHRoZSBjb2RlIGFuZCBmaWd1cmUgb3V0CndoYXQgaXQncyBzdXBw b3NlZCB0byBkbywgYW5kIHdoeSBpc24ndCBpdCB1c2luZyB0aGUgaW5mb3JtYXRpb24uIExvb2sK YXQgZ2l0IGJsYW1lIGFuZCBsb2csIHdhcyBpdCBhbHdheXMgc28sIG9yIGRpZCBzb21ldGhpbmcg Y2hhbmdlPwoKVGhlIHdhcm5pbmdzIGFyZSBhYm91dCBwb3RlbnRpYWwgYnVncy4gVGhlIG9iamVj dGl2ZSBvciBlbmQgZ29hbCBpcyB0bwpmaXggdGhlIGJ1Z3MsIG5vdCB0byBzaWxlbmNlIHRoZSB3 YXJuaW5ncy4KCgpCUiwKSmFuaS4KCgo+Cj4gQmVuamFtaW4KPgo+Pgo+Pj4gICAJLyogIDE1LiBG aW5kIG51bWJlciBvZiBwaXhlbHMgaW4gbGVmdCBtYXJnaW46ICovCj4+PiAgIAlpZiAobWFyZ2lu cykKPj4+ICAgCQlsZWZ0X21hcmdpbiA9IChoZGlzcGxheV9ybmQgKiBHVEZfTUFSR0lOX1BFUkNF TlRBR0UgKyA1MDApIC8KPj4+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBo aWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2220FC2D0BF for ; Thu, 5 Dec 2019 09:55:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 018162465E for ; Thu, 5 Dec 2019 09:55:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729377AbfLEJzz (ORCPT ); Thu, 5 Dec 2019 04:55:55 -0500 Received: from mga06.intel.com ([134.134.136.31]:20429 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbfLEJzz (ORCPT ); Thu, 5 Dec 2019 04:55:55 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 01:55:54 -0800 X-IronPort-AV: E=Sophos;i="5.69,281,1571727600"; d="scan'208";a="205719543" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 01:55:51 -0800 From: Jani Nikula To: Benjamin GAIGNARD , Thomas Zimmermann , "maarten.lankhorst\@linux.intel.com" , "mripard\@kernel.org" , "sean\@poorly.run" , "airlied\@linux.ie" , "daniel\@ffwll.ch" Cc: "linux-kernel\@vger.kernel.org" , "dri-devel\@lists.freedesktop.org" Subject: Re: [PATCH] drm/modes: remove unused variables In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191119134706.10893-1-benjamin.gaignard@st.com> <8056f838-3ebf-26db-f5be-3e78d61aa512@suse.de> Date: Thu, 05 Dec 2019 11:55:48 +0200 Message-ID: <87tv6fgkpn.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Dec 2019, Benjamin GAIGNARD wrote: > On 12/4/19 10:35 AM, Thomas Zimmermann wrote: >> Hi >> >> Am 19.11.19 um 14:47 schrieb Benjamin Gaignard: >>> When compiling with W=1 few warnings about unused variables show up. >>> This patch removes all the involved variables. >>> >>> Signed-off-by: Benjamin Gaignard >>> --- >>> drivers/gpu/drm/drm_modes.c | 22 +++------------------- >>> 1 file changed, 3 insertions(+), 19 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c >>> index 88232698d7a0..aca901aff042 100644 >>> --- a/drivers/gpu/drm/drm_modes.c >>> +++ b/drivers/gpu/drm/drm_modes.c >>> @@ -233,7 +233,7 @@ struct drm_display_mode *drm_cvt_mode(struct drm_device *dev, int hdisplay, >>> /* 3) Nominal HSync width (% of line period) - default 8 */ >>> #define CVT_HSYNC_PERCENTAGE 8 >>> unsigned int hblank_percentage; >>> - int vsyncandback_porch, vback_porch, hblank; >>> + int vsyncandback_porch, hblank; >>> >>> /* estimated the horizontal period */ >>> tmp1 = HV_FACTOR * 1000000 - >>> @@ -249,7 +249,6 @@ struct drm_display_mode *drm_cvt_mode(struct drm_device *dev, int hdisplay, >>> else >>> vsyncandback_porch = tmp1; >>> /* 10. Find number of lines in back porch */ >>> - vback_porch = vsyncandback_porch - vsync; >>> drm_mode->vtotal = vdisplay_rnd + 2 * vmargin + >>> vsyncandback_porch + CVT_MIN_V_PORCH; >>> /* 5) Definition of Horizontal blanking time limitation */ >>> @@ -386,9 +385,8 @@ drm_gtf_mode_complex(struct drm_device *dev, int hdisplay, int vdisplay, >>> int top_margin, bottom_margin; >>> int interlace; >>> unsigned int hfreq_est; >>> - int vsync_plus_bp, vback_porch; >>> - unsigned int vtotal_lines, vfieldrate_est, hperiod; >>> - unsigned int vfield_rate, vframe_rate; >>> + int vsync_plus_bp; >>> + unsigned int vtotal_lines; >>> int left_margin, right_margin; >>> unsigned int total_active_pixels, ideal_duty_cycle; >>> unsigned int hblank, total_pixels, pixel_freq; >>> @@ -451,23 +449,9 @@ drm_gtf_mode_complex(struct drm_device *dev, int hdisplay, int vdisplay, >>> /* [V SYNC+BP] = RINT(([MIN VSYNC+BP] * hfreq_est / 1000000)) */ >>> vsync_plus_bp = MIN_VSYNC_PLUS_BP * hfreq_est / 1000; >>> vsync_plus_bp = (vsync_plus_bp + 500) / 1000; >>> - /* 9. Find the number of lines in V back porch alone: */ >>> - vback_porch = vsync_plus_bp - V_SYNC_RQD; >>> /* 10. Find the total number of lines in Vertical field period: */ >>> vtotal_lines = vdisplay_rnd + top_margin + bottom_margin + >>> vsync_plus_bp + GTF_MIN_V_PORCH; >>> - /* 11. Estimate the Vertical field frequency: */ >>> - vfieldrate_est = hfreq_est / vtotal_lines; >>> - /* 12. Find the actual horizontal period: */ >>> - hperiod = 1000000 / (vfieldrate_rqd * vtotal_lines); >>> - >>> - /* 13. Find the actual Vertical field frequency: */ >>> - vfield_rate = hfreq_est / vtotal_lines; >>> - /* 14. Find the Vertical frame frequency: */ >>> - if (interlaced) >>> - vframe_rate = vfield_rate / 2; >>> - else >>> - vframe_rate = vfield_rate; >> The amount of unused code is quite large, which makes me wonder if >> there's something missing below where these variables are supposed to be >> used. >> >> If these variables can be removed, comments should mention that steps 9 >> and 11 to 14 are being left out. After all, the function is fairly >> explicit about implementing the GTF algorithm step by step. >> >> Best regards >> Thomas > > If the goal is to keep all the steps then I could prefix all problematic > variables with __maybe_unused macro. The effect is the same; it hides a potential bug that should be analyzed and fixed. If you have the time, please look at the code and figure out what it's supposed to do, and why isn't it using the information. Look at git blame and log, was it always so, or did something change? The warnings are about potential bugs. The objective or end goal is to fix the bugs, not to silence the warnings. BR, Jani. > > Benjamin > >> >>> /* 15. Find number of pixels in left margin: */ >>> if (margins) >>> left_margin = (hdisplay_rnd * GTF_MARGIN_PERCENTAGE + 500) / >>> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center