From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F49C432C0 for ; Tue, 3 Dec 2019 12:40:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E1412073C for ; Tue, 3 Dec 2019 12:40:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E1412073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 84A796E31A; Tue, 3 Dec 2019 12:40:27 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0EE946E31A; Tue, 3 Dec 2019 12:40:25 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:40:25 -0800 X-IronPort-AV: E=Sophos;i="5.69,273,1571727600"; d="scan'208";a="204961932" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:40:21 -0800 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode In-Reply-To: <20191122231616.2574-3-lyude@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191122231616.2574-1-lyude@redhat.com> <20191122231616.2574-3-lyude@redhat.com> Date: Tue, 03 Dec 2019 14:40:18 +0200 Message-ID: <87tv6hinv1.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , Lee Shawn C Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCAyMiBOb3YgMjAxOSwgTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gQ3VycmVudGx5IHdlIGFsd2F5cyBkZXRlcm1pbmUgdGhlIGluaXRpYWwgcGFuZWwgYnJpZ2h0 bmVzcyBsZXZlbCBieQo+IHNpbXBseSByZWFkaW5nIHRoZSB2YWx1ZSBmcm9tIERQX0VEUF9CQUNL TElHSFRfQlJJR0hUTkVTU19NU0IvTFNCLiBUaGlzCj4gc2VlbXMgd3JvbmcgdGhvdWdoLCBiZWNh dXNlIGlmIHRoZSBwYW5lbCBpcyBub3QgY3VycmVudGx5IGluIERQQ0QKPiBjb250cm9sIG1vZGUg dGhlcmUncyBub3QgcmVhbGx5IGFueSByZWFzb24gd2h5IHRoZXJlIHdvdWxkIGJlIGFueQo+IGJy aWdodG5lc3MgdmFsdWUgcHJvZ3JhbW1lZCBpbiB0aGUgZmlyc3QgcGxhY2UuCj4KPiBUaGlzIGFw cGVhcnMgdG8gYmUgdGhlIGNhc2Ugb24gdGhlIExlbm92byBUaGlua1BhZCBYMSBFeHRyZW1lIDJu ZAo+IEdlbmVyYXRpb24sIHdoZXJlIHRoZSBkZWZhdWx0IHZhbHVlIGluIHRoZXNlIHJlZ2lzdGVy cyBpcyBhbHdheXMgMCBvbgo+IGJvb3QgZGVzcGl0ZSB0aGUgZmFjdCB0aGUgcGFuZWwgcnVucyBh dCBtYXggYnJpZ2h0bmVzcyBieSBkZWZhdWx0Lgo+IEdldHRpbmcgdGhlIGluaXRpYWwgYnJpZ2h0 bmVzcyB2YWx1ZSBjb3JyZWN0IGhlcmUgaXMgaW1wb3J0YW50IGFzIHdlbGwsCj4gc2luY2UgdGhl IHBhbmVsIG9uIHRoaXMgbGFwdG9wIGRvZXNuJ3QgYmVoYXZlIHdlbGwgaWYgaXQncyBldmVyIHB1 dCBpbnRvCj4gRFBDRCBjb250cm9sIG1vZGUgd2hpbGUgdGhlIGJyaWdodG5lc3MgbGV2ZWwgaXMg cHJvZ3JhbW1lZCB0byAwLgo+Cj4gU28sIGxldCdzIGZpeCB0aGlzIGJ5IGNoZWNraW5nIHdoYXQg dGhlIGN1cnJlbnQgYmFja2xpZ2h0IGNvbnRyb2wgbW9kZQo+IGlzIGJlZm9yZSByZWFkaW5nIHRo ZSBicmlnaHRuZXNzIGxldmVsLiBJZiBpdCdzIGluIERQQ0QgY29udHJvbCBtb2RlLCB3ZQo+IHJl dHVybiB0aGUgcHJvZ3JhbW1lZCBicmlnaHRuZXNzIGxldmVsLiBPdGhlcndpc2Ugd2UgYXNzdW1l IDEwMCUKPiBicmlnaHRuZXNzIGFuZCByZXR1cm4gdGhlIGhpZ2hlc3QgcG9zc2libGUgYnJpZ2h0 bmVzcyBsZXZlbC4gVGhpcyBhbHNvCj4gcHJldmVudHMgdXMgZnJvbSBhY2NpZGVudGFsbHkgcHJv Z3JhbW1pbmcgYSBicmlnaHRuZXNzIGxldmVsIG9mIDAuCj4KPiBUaGlzIGlzIG9uZSBvZiB0aGUg bWFueSBmaXhlcyB0aGF0IGdldHMgYmFja2xpZ2h0IGNvbnRyb2xzIHdvcmtpbmcgb24KPiB0aGUg VGhpbmtQYWQgWDEgRXh0cmVtZSAybmQgR2VuZXJhdGlvbiB3aXRoIG9wdGlvbmFsIDRLIEFNT0xF RCBzY3JlZW4uCj4KPiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29t Pgo+IC0tLQo+ICAuLi4vZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBfYXV4X2JhY2tsaWdo dC5jIHwgMTUgKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25z KCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9k cF9hdXhfYmFja2xpZ2h0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rw X2F1eF9iYWNrbGlnaHQuYwo+IGluZGV4IGZhZDQ3MDU1M2NmOS4uMGJmODc3MmJjN2JiIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBfYXV4X2JhY2ts aWdodC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcF9hdXhf YmFja2xpZ2h0LmMKPiBAQCAtNTksOCArNTksMjMgQEAgc3RhdGljIHUzMiBpbnRlbF9kcF9hdXhf Z2V0X2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIHsKPiAg CXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSBlbmNfdG9faW50ZWxfZHAoJmNvbm5lY3Rvci0+ ZW5jb2Rlci0+YmFzZSk7Cj4gIAl1OCByZWFkX3ZhbFsyXSA9IHsgMHgwIH07Cj4gKwl1OCBjb250 cm9sX3JlZzsKPiAgCXUxNiBsZXZlbCA9IDA7Cj4gIAo+ICsJaWYgKGRybV9kcF9kcGNkX3JlYWRi KCZpbnRlbF9kcC0+YXV4LCBEUF9FRFBfRElTUExBWV9DT05UUk9MX1JFR0lTVEVSLAoKU2hvdWxk bid0IHRoYXQgYmUgRFBfRURQX0JBQ0tMSUdIVF9NT0RFX1NFVF9SRUdJU1RFUiBpbnN0ZWFkPwoK PiArCQkJICAgICAgJmNvbnRyb2xfcmVnKSAhPSAxKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiRmFp bGVkIHRvIHJlYWQgdGhlIERQQ0QgcmVnaXN0ZXIgMHgleFxuIiwKPiArCQkJICAgICAgRFBfRURQ X0RJU1BMQVlfQ09OVFJPTF9SRUdJU1RFUik7Cj4gKwkJcmV0dXJuIDA7Cj4gKwl9Cj4gKwo+ICsJ LyoKPiArCSAqIElmIHdlJ3JlIG5vdCBpbiBEUENEIGNvbnRyb2wgbW9kZSB5ZXQsIHRoZSBwcm9n cmFtbWVkIGJyaWdodG5lc3MKPiArCSAqIHZhbHVlIGlzIG1lYW5pbmdsZXNzIGFuZCB3ZSBzaG91 bGQgYXNzdW1lIG1heCBicmlnaHRuZXNzCj4gKwkgKi8KPiArCWlmICghKGNvbnRyb2xfcmVnICYg RFBfRURQX0JBQ0tMSUdIVF9DT05UUk9MX01PREVfRFBDRCkpCj4gKwkJcmV0dXJuIGNvbm5lY3Rv ci0+cGFuZWwuYmFja2xpZ2h0Lm1heDsKCkl0J3Mgbm90IGp1c3QgYSBiaXQsIEkgdGhpbmsgeW91 IG5lZWQgdG8gY2hlY2sgKGNvbnRyb2xfcmVnICYgbWFzaykgPT0KdmFsdWUuCgpCUiwKSmFuaS4K Cj4gKwo+ICAJaWYgKGRybV9kcF9kcGNkX3JlYWQoJmludGVsX2RwLT5hdXgsIERQX0VEUF9CQUNL TElHSFRfQlJJR0hUTkVTU19NU0IsCj4gIAkJCSAgICAgJnJlYWRfdmFsLCBzaXplb2YocmVhZF92 YWwpKSA8IDApIHsKPiAgCQlEUk1fREVCVUdfS01TKCJGYWlsZWQgdG8gcmVhZCBEUENEIHJlZ2lz dGVyIDB4JXhcbiIsCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNz IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C4DC43215 for ; Tue, 3 Dec 2019 12:40:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45C7B2073F for ; Tue, 3 Dec 2019 12:40:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45C7B2073F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A3C86E4AA; Tue, 3 Dec 2019 12:40:28 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0EE946E31A; Tue, 3 Dec 2019 12:40:25 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:40:25 -0800 X-IronPort-AV: E=Sophos;i="5.69,273,1571727600"; d="scan'208";a="204961932" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:40:21 -0800 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org In-Reply-To: <20191122231616.2574-3-lyude@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191122231616.2574-1-lyude@redhat.com> <20191122231616.2574-3-lyude@redhat.com> Date: Tue, 03 Dec 2019 14:40:18 +0200 Message-ID: <87tv6hinv1.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gRnJpLCAyMiBOb3YgMjAxOSwgTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gQ3VycmVudGx5IHdlIGFsd2F5cyBkZXRlcm1pbmUgdGhlIGluaXRpYWwgcGFuZWwgYnJpZ2h0 bmVzcyBsZXZlbCBieQo+IHNpbXBseSByZWFkaW5nIHRoZSB2YWx1ZSBmcm9tIERQX0VEUF9CQUNL TElHSFRfQlJJR0hUTkVTU19NU0IvTFNCLiBUaGlzCj4gc2VlbXMgd3JvbmcgdGhvdWdoLCBiZWNh dXNlIGlmIHRoZSBwYW5lbCBpcyBub3QgY3VycmVudGx5IGluIERQQ0QKPiBjb250cm9sIG1vZGUg dGhlcmUncyBub3QgcmVhbGx5IGFueSByZWFzb24gd2h5IHRoZXJlIHdvdWxkIGJlIGFueQo+IGJy aWdodG5lc3MgdmFsdWUgcHJvZ3JhbW1lZCBpbiB0aGUgZmlyc3QgcGxhY2UuCj4KPiBUaGlzIGFw cGVhcnMgdG8gYmUgdGhlIGNhc2Ugb24gdGhlIExlbm92byBUaGlua1BhZCBYMSBFeHRyZW1lIDJu ZAo+IEdlbmVyYXRpb24sIHdoZXJlIHRoZSBkZWZhdWx0IHZhbHVlIGluIHRoZXNlIHJlZ2lzdGVy cyBpcyBhbHdheXMgMCBvbgo+IGJvb3QgZGVzcGl0ZSB0aGUgZmFjdCB0aGUgcGFuZWwgcnVucyBh dCBtYXggYnJpZ2h0bmVzcyBieSBkZWZhdWx0Lgo+IEdldHRpbmcgdGhlIGluaXRpYWwgYnJpZ2h0 bmVzcyB2YWx1ZSBjb3JyZWN0IGhlcmUgaXMgaW1wb3J0YW50IGFzIHdlbGwsCj4gc2luY2UgdGhl IHBhbmVsIG9uIHRoaXMgbGFwdG9wIGRvZXNuJ3QgYmVoYXZlIHdlbGwgaWYgaXQncyBldmVyIHB1 dCBpbnRvCj4gRFBDRCBjb250cm9sIG1vZGUgd2hpbGUgdGhlIGJyaWdodG5lc3MgbGV2ZWwgaXMg cHJvZ3JhbW1lZCB0byAwLgo+Cj4gU28sIGxldCdzIGZpeCB0aGlzIGJ5IGNoZWNraW5nIHdoYXQg dGhlIGN1cnJlbnQgYmFja2xpZ2h0IGNvbnRyb2wgbW9kZQo+IGlzIGJlZm9yZSByZWFkaW5nIHRo ZSBicmlnaHRuZXNzIGxldmVsLiBJZiBpdCdzIGluIERQQ0QgY29udHJvbCBtb2RlLCB3ZQo+IHJl dHVybiB0aGUgcHJvZ3JhbW1lZCBicmlnaHRuZXNzIGxldmVsLiBPdGhlcndpc2Ugd2UgYXNzdW1l IDEwMCUKPiBicmlnaHRuZXNzIGFuZCByZXR1cm4gdGhlIGhpZ2hlc3QgcG9zc2libGUgYnJpZ2h0 bmVzcyBsZXZlbC4gVGhpcyBhbHNvCj4gcHJldmVudHMgdXMgZnJvbSBhY2NpZGVudGFsbHkgcHJv Z3JhbW1pbmcgYSBicmlnaHRuZXNzIGxldmVsIG9mIDAuCj4KPiBUaGlzIGlzIG9uZSBvZiB0aGUg bWFueSBmaXhlcyB0aGF0IGdldHMgYmFja2xpZ2h0IGNvbnRyb2xzIHdvcmtpbmcgb24KPiB0aGUg VGhpbmtQYWQgWDEgRXh0cmVtZSAybmQgR2VuZXJhdGlvbiB3aXRoIG9wdGlvbmFsIDRLIEFNT0xF RCBzY3JlZW4uCj4KPiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29t Pgo+IC0tLQo+ICAuLi4vZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBfYXV4X2JhY2tsaWdo dC5jIHwgMTUgKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25z KCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9k cF9hdXhfYmFja2xpZ2h0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rw X2F1eF9iYWNrbGlnaHQuYwo+IGluZGV4IGZhZDQ3MDU1M2NmOS4uMGJmODc3MmJjN2JiIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBfYXV4X2JhY2ts aWdodC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcF9hdXhf YmFja2xpZ2h0LmMKPiBAQCAtNTksOCArNTksMjMgQEAgc3RhdGljIHUzMiBpbnRlbF9kcF9hdXhf Z2V0X2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIHsKPiAg CXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSBlbmNfdG9faW50ZWxfZHAoJmNvbm5lY3Rvci0+ ZW5jb2Rlci0+YmFzZSk7Cj4gIAl1OCByZWFkX3ZhbFsyXSA9IHsgMHgwIH07Cj4gKwl1OCBjb250 cm9sX3JlZzsKPiAgCXUxNiBsZXZlbCA9IDA7Cj4gIAo+ICsJaWYgKGRybV9kcF9kcGNkX3JlYWRi KCZpbnRlbF9kcC0+YXV4LCBEUF9FRFBfRElTUExBWV9DT05UUk9MX1JFR0lTVEVSLAoKU2hvdWxk bid0IHRoYXQgYmUgRFBfRURQX0JBQ0tMSUdIVF9NT0RFX1NFVF9SRUdJU1RFUiBpbnN0ZWFkPwoK PiArCQkJICAgICAgJmNvbnRyb2xfcmVnKSAhPSAxKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiRmFp bGVkIHRvIHJlYWQgdGhlIERQQ0QgcmVnaXN0ZXIgMHgleFxuIiwKPiArCQkJICAgICAgRFBfRURQ X0RJU1BMQVlfQ09OVFJPTF9SRUdJU1RFUik7Cj4gKwkJcmV0dXJuIDA7Cj4gKwl9Cj4gKwo+ICsJ LyoKPiArCSAqIElmIHdlJ3JlIG5vdCBpbiBEUENEIGNvbnRyb2wgbW9kZSB5ZXQsIHRoZSBwcm9n cmFtbWVkIGJyaWdodG5lc3MKPiArCSAqIHZhbHVlIGlzIG1lYW5pbmdsZXNzIGFuZCB3ZSBzaG91 bGQgYXNzdW1lIG1heCBicmlnaHRuZXNzCj4gKwkgKi8KPiArCWlmICghKGNvbnRyb2xfcmVnICYg RFBfRURQX0JBQ0tMSUdIVF9DT05UUk9MX01PREVfRFBDRCkpCj4gKwkJcmV0dXJuIGNvbm5lY3Rv ci0+cGFuZWwuYmFja2xpZ2h0Lm1heDsKCkl0J3Mgbm90IGp1c3QgYSBiaXQsIEkgdGhpbmsgeW91 IG5lZWQgdG8gY2hlY2sgKGNvbnRyb2xfcmVnICYgbWFzaykgPT0KdmFsdWUuCgpCUiwKSmFuaS4K Cj4gKwo+ICAJaWYgKGRybV9kcF9kcGNkX3JlYWQoJmludGVsX2RwLT5hdXgsIERQX0VEUF9CQUNL TElHSFRfQlJJR0hUTkVTU19NU0IsCj4gIAkJCSAgICAgJnJlYWRfdmFsLCBzaXplb2YocmVhZF92 YWwpKSA8IDApIHsKPiAgCQlEUk1fREVCVUdfS01TKCJGYWlsZWQgdG8gcmVhZCBEUENEIHJlZ2lz dGVyIDB4JXhcbiIsCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNz IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4BF3C432C0 for ; Tue, 3 Dec 2019 12:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6BEF2073F for ; Tue, 3 Dec 2019 12:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726186AbfLCMk1 (ORCPT ); Tue, 3 Dec 2019 07:40:27 -0500 Received: from mga18.intel.com ([134.134.136.126]:30336 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbfLCMk1 (ORCPT ); Tue, 3 Dec 2019 07:40:27 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:40:26 -0800 X-IronPort-AV: E=Sophos;i="5.69,273,1571727600"; d="scan'208";a="204961932" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:40:21 -0800 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org Cc: Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Chris Wilson , Ville =?utf-8?B?U3lyasOkbMOk?= , Lee Shawn C , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode In-Reply-To: <20191122231616.2574-3-lyude@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191122231616.2574-1-lyude@redhat.com> <20191122231616.2574-3-lyude@redhat.com> Date: Tue, 03 Dec 2019 14:40:18 +0200 Message-ID: <87tv6hinv1.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Nov 2019, Lyude Paul wrote: > Currently we always determine the initial panel brightness level by > simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This > seems wrong though, because if the panel is not currently in DPCD > control mode there's not really any reason why there would be any > brightness value programmed in the first place. > > This appears to be the case on the Lenovo ThinkPad X1 Extreme 2nd > Generation, where the default value in these registers is always 0 on > boot despite the fact the panel runs at max brightness by default. > Getting the initial brightness value correct here is important as well, > since the panel on this laptop doesn't behave well if it's ever put into > DPCD control mode while the brightness level is programmed to 0. > > So, let's fix this by checking what the current backlight control mode > is before reading the brightness level. If it's in DPCD control mode, we > return the programmed brightness level. Otherwise we assume 100% > brightness and return the highest possible brightness level. This also > prevents us from accidentally programming a brightness level of 0. > > This is one of the many fixes that gets backlight controls working on > the ThinkPad X1 Extreme 2nd Generation with optional 4K AMOLED screen. > > Signed-off-by: Lyude Paul > --- > .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index fad470553cf9..0bf8772bc7bb 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -59,8 +59,23 @@ static u32 intel_dp_aux_get_backlight(struct intel_connector *connector) > { > struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base); > u8 read_val[2] = { 0x0 }; > + u8 control_reg; > u16 level = 0; > > + if (drm_dp_dpcd_readb(&intel_dp->aux, DP_EDP_DISPLAY_CONTROL_REGISTER, Shouldn't that be DP_EDP_BACKLIGHT_MODE_SET_REGISTER instead? > + &control_reg) != 1) { > + DRM_DEBUG_KMS("Failed to read the DPCD register 0x%x\n", > + DP_EDP_DISPLAY_CONTROL_REGISTER); > + return 0; > + } > + > + /* > + * If we're not in DPCD control mode yet, the programmed brightness > + * value is meaningless and we should assume max brightness > + */ > + if (!(control_reg & DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD)) > + return connector->panel.backlight.max; It's not just a bit, I think you need to check (control_reg & mask) == value. BR, Jani. > + > if (drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB, > &read_val, sizeof(read_val)) < 0) { > DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n", -- Jani Nikula, Intel Open Source Graphics Center