From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA001C432C0 for ; Mon, 2 Dec 2019 14:13:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85E4E20717 for ; Mon, 2 Dec 2019 14:13:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727386AbfLBONb (ORCPT ); Mon, 2 Dec 2019 09:13:31 -0500 Received: from mga11.intel.com ([192.55.52.93]:20950 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727362AbfLBONa (ORCPT ); Mon, 2 Dec 2019 09:13:30 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 06:13:30 -0800 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204572503" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 06:13:26 -0800 From: Jani Nikula To: Chandan Uddaraju , freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, seanpaul@chromium.org Cc: abhinavk@codeaurora.org, hoegsberg@google.com, dri-devel@lists.freedesktop.org, Chandan Uddaraju Subject: Re: [DPU PATCH v3 2/5] drm: add constant N value in helper file In-Reply-To: <0101016ec6ddf2ce-8548e076-2347-49be-a9be-4d81a14ad8f7-000000@us-west-2.amazonses.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1575294437-6129-1-git-send-email-chandanu@codeaurora.org> <0101016ec6ddf2ce-8548e076-2347-49be-a9be-4d81a14ad8f7-000000@us-west-2.amazonses.com> Date: Mon, 02 Dec 2019 16:13:24 +0200 Message-ID: <87tv6ike7v.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 02 Dec 2019, Chandan Uddaraju wrote: > The constant N value (0x8000) is used by multiple DP > drivers. Define this value in header file and use this > in the existing i915 display driver. > > Signed-off-by: Chandan Uddaraju Reviewed-by: Jani Nikula and ack for merging via drm-misc or whichever tree you find suitable. > --- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > include/drm/drm_dp_helper.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index ce05e80..1a4ccfd 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -7496,7 +7496,7 @@ static void compute_m_n(unsigned int m, unsigned int n, > * which the devices expect also in synchronous clock mode. > */ > if (constant_n) > - *ret_n = 0x8000; > + *ret_n = DP_LINK_CONSTANT_N_VALUE; > else > *ret_n = min_t(unsigned int, roundup_pow_of_two(n), DATA_LINK_N_MAX); > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index 8364502..69b8251 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -1357,6 +1357,7 @@ int drm_dp_dpcd_read_link_status(struct drm_dp_aux *aux, > * DisplayPort link > */ > #define DP_LINK_CAP_ENHANCED_FRAMING (1 << 0) > +#define DP_LINK_CONSTANT_N_VALUE 0x8000 > > struct drm_dp_link { > unsigned char revision; -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [DPU PATCH v3 2/5] drm: add constant N value in helper file Date: Mon, 02 Dec 2019 16:13:24 +0200 Message-ID: <87tv6ike7v.fsf@intel.com> References: <1575294437-6129-1-git-send-email-chandanu@codeaurora.org> <0101016ec6ddf2ce-8548e076-2347-49be-a9be-4d81a14ad8f7-000000@us-west-2.amazonses.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <0101016ec6ddf2ce-8548e076-2347-49be-a9be-4d81a14ad8f7-000000-j0qUFrXf9azQVAzzCBYphlNw9kRHFGba@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org Cc: Chandan Uddaraju , hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAwMiBEZWMgMjAxOSwgQ2hhbmRhbiBVZGRhcmFqdSA8Y2hhbmRhbnVAY29kZWF1cm9y YS5vcmc+IHdyb3RlOgo+IFRoZSBjb25zdGFudCBOIHZhbHVlICgweDgwMDApIGlzIHVzZWQgYnkg bXVsdGlwbGUgRFAKPiBkcml2ZXJzLiBEZWZpbmUgdGhpcyB2YWx1ZSBpbiBoZWFkZXIgZmlsZSBh bmQgdXNlIHRoaXMKPiBpbiB0aGUgZXhpc3RpbmcgaTkxNSBkaXNwbGF5IGRyaXZlci4KPgo+IFNp Z25lZC1vZmYtYnk6IENoYW5kYW4gVWRkYXJhanUgPGNoYW5kYW51QGNvZGVhdXJvcmEub3JnPgoK UmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgphbmQgYWNr IGZvciBtZXJnaW5nIHZpYSBkcm0tbWlzYyBvciB3aGljaGV2ZXIgdHJlZSB5b3UgZmluZCBzdWl0 YWJsZS4KCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3Bs YXkuYyB8IDIgKy0KPiAgaW5jbHVkZS9kcm0vZHJtX2RwX2hlbHBlci5oICAgICAgICAgICAgICAg ICAgfCAxICsKPiAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rp c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4g aW5kZXggY2UwNWU4MC4uMWE0Y2NmZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTc0OTYsNyArNzQ5Niw3IEBAIHN0YXRpYyB2b2lk IGNvbXB1dGVfbV9uKHVuc2lnbmVkIGludCBtLCB1bnNpZ25lZCBpbnQgbiwKPiAgCSAqIHdoaWNo IHRoZSBkZXZpY2VzIGV4cGVjdCBhbHNvIGluIHN5bmNocm9ub3VzIGNsb2NrIG1vZGUuCj4gIAkg Ki8KPiAgCWlmIChjb25zdGFudF9uKQo+IC0JCSpyZXRfbiA9IDB4ODAwMDsKPiArCQkqcmV0X24g PSBEUF9MSU5LX0NPTlNUQU5UX05fVkFMVUU7Cj4gIAllbHNlCj4gIAkJKnJldF9uID0gbWluX3Qo dW5zaWduZWQgaW50LCByb3VuZHVwX3Bvd19vZl90d28obiksIERBVEFfTElOS19OX01BWCk7Cj4g IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZHBfaGVscGVyLmggYi9pbmNsdWRlL2Ry bS9kcm1fZHBfaGVscGVyLmgKPiBpbmRleCA4MzY0NTAyLi42OWI4MjUxIDEwMDY0NAo+IC0tLSBh L2luY2x1ZGUvZHJtL2RybV9kcF9oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9kcF9o ZWxwZXIuaAo+IEBAIC0xMzU3LDYgKzEzNTcsNyBAQCBpbnQgZHJtX2RwX2RwY2RfcmVhZF9saW5r X3N0YXR1cyhzdHJ1Y3QgZHJtX2RwX2F1eCAqYXV4LAo+ICAgKiBEaXNwbGF5UG9ydCBsaW5rCj4g ICAqLwo+ICAjZGVmaW5lIERQX0xJTktfQ0FQX0VOSEFOQ0VEX0ZSQU1JTkcgKDEgPDwgMCkKPiAr I2RlZmluZSBEUF9MSU5LX0NPTlNUQU5UX05fVkFMVUUgMHg4MDAwCj4gIAo+ICBzdHJ1Y3QgZHJt X2RwX2xpbmsgewo+ICAJdW5zaWduZWQgY2hhciByZXZpc2lvbjsKCi0tIApKYW5pIE5pa3VsYSwg SW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBtYWlsaW5nIGxpc3QKRnJlZWRyZW5v QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ZyZWVkcmVubw== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5288FC432C3 for ; Mon, 2 Dec 2019 14:13:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3337020833 for ; Mon, 2 Dec 2019 14:13:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3337020833 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B3A889862; Mon, 2 Dec 2019 14:13:31 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 708DD89862; Mon, 2 Dec 2019 14:13:30 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 06:13:29 -0800 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204572503" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 06:13:26 -0800 From: Jani Nikula To: Chandan Uddaraju , freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, seanpaul@chromium.org Subject: Re: [DPU PATCH v3 2/5] drm: add constant N value in helper file In-Reply-To: <0101016ec6ddf2ce-8548e076-2347-49be-a9be-4d81a14ad8f7-000000@us-west-2.amazonses.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1575294437-6129-1-git-send-email-chandanu@codeaurora.org> <0101016ec6ddf2ce-8548e076-2347-49be-a9be-4d81a14ad8f7-000000@us-west-2.amazonses.com> Date: Mon, 02 Dec 2019 16:13:24 +0200 Message-ID: <87tv6ike7v.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chandan Uddaraju , hoegsberg@google.com, dri-devel@lists.freedesktop.org, abhinavk@codeaurora.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191202141324.e0aBCOKK4LfFvzpJjy8VOU5QCrjJbdZyjuZmt3wCLZg@z> T24gTW9uLCAwMiBEZWMgMjAxOSwgQ2hhbmRhbiBVZGRhcmFqdSA8Y2hhbmRhbnVAY29kZWF1cm9y YS5vcmc+IHdyb3RlOgo+IFRoZSBjb25zdGFudCBOIHZhbHVlICgweDgwMDApIGlzIHVzZWQgYnkg bXVsdGlwbGUgRFAKPiBkcml2ZXJzLiBEZWZpbmUgdGhpcyB2YWx1ZSBpbiBoZWFkZXIgZmlsZSBh bmQgdXNlIHRoaXMKPiBpbiB0aGUgZXhpc3RpbmcgaTkxNSBkaXNwbGF5IGRyaXZlci4KPgo+IFNp Z25lZC1vZmYtYnk6IENoYW5kYW4gVWRkYXJhanUgPGNoYW5kYW51QGNvZGVhdXJvcmEub3JnPgoK UmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgphbmQgYWNr IGZvciBtZXJnaW5nIHZpYSBkcm0tbWlzYyBvciB3aGljaGV2ZXIgdHJlZSB5b3UgZmluZCBzdWl0 YWJsZS4KCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3Bs YXkuYyB8IDIgKy0KPiAgaW5jbHVkZS9kcm0vZHJtX2RwX2hlbHBlci5oICAgICAgICAgICAgICAg ICAgfCAxICsKPiAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rp c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4g aW5kZXggY2UwNWU4MC4uMWE0Y2NmZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTc0OTYsNyArNzQ5Niw3IEBAIHN0YXRpYyB2b2lk IGNvbXB1dGVfbV9uKHVuc2lnbmVkIGludCBtLCB1bnNpZ25lZCBpbnQgbiwKPiAgCSAqIHdoaWNo IHRoZSBkZXZpY2VzIGV4cGVjdCBhbHNvIGluIHN5bmNocm9ub3VzIGNsb2NrIG1vZGUuCj4gIAkg Ki8KPiAgCWlmIChjb25zdGFudF9uKQo+IC0JCSpyZXRfbiA9IDB4ODAwMDsKPiArCQkqcmV0X24g PSBEUF9MSU5LX0NPTlNUQU5UX05fVkFMVUU7Cj4gIAllbHNlCj4gIAkJKnJldF9uID0gbWluX3Qo dW5zaWduZWQgaW50LCByb3VuZHVwX3Bvd19vZl90d28obiksIERBVEFfTElOS19OX01BWCk7Cj4g IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZHBfaGVscGVyLmggYi9pbmNsdWRlL2Ry bS9kcm1fZHBfaGVscGVyLmgKPiBpbmRleCA4MzY0NTAyLi42OWI4MjUxIDEwMDY0NAo+IC0tLSBh L2luY2x1ZGUvZHJtL2RybV9kcF9oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9kcF9o ZWxwZXIuaAo+IEBAIC0xMzU3LDYgKzEzNTcsNyBAQCBpbnQgZHJtX2RwX2RwY2RfcmVhZF9saW5r X3N0YXR1cyhzdHJ1Y3QgZHJtX2RwX2F1eCAqYXV4LAo+ICAgKiBEaXNwbGF5UG9ydCBsaW5rCj4g ICAqLwo+ICAjZGVmaW5lIERQX0xJTktfQ0FQX0VOSEFOQ0VEX0ZSQU1JTkcgKDEgPDwgMCkKPiAr I2RlZmluZSBEUF9MSU5LX0NPTlNUQU5UX05fVkFMVUUgMHg4MDAwCj4gIAo+ICBzdHJ1Y3QgZHJt X2RwX2xpbmsgewo+ICAJdW5zaWduZWQgY2hhciByZXZpc2lvbjsKCi0tIApKYW5pIE5pa3VsYSwg SW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==