Re: [PATCH] mm: hugetlb controller for cgroups v2

[Giuseppe Scrivano <gscrivan@redhat.com>]

Hi Mina,

Mina Almasry <almasrymina@google.com> writes:

> On Thu, Nov 21, 2019 at 1:14 PM Giuseppe Scrivano <gscrivan@redhat.com> wrote:
>>
>> In the effort of supporting cgroups v2 into Kubernetes, I stumped on
>> the lack of the hugetlb controller.
>>
>> When the controller is enabled, it exposes three new files for each
>> hugetlb size on non-root cgroups:
>>
>> - hugetlb.<hugepagesize>.current
>> - hugetlb.<hugepagesize>.max
>> - hugetlb.<hugepagesize>.stat
>>
>> The differences with the legacy hierarchy are in the file names and
>> using the value "max" instead of "-1" to disable a limit.
>>
>> The file .limit_in_bytes is renamed to .max.
>>
>> The file .usage_in_bytes is renamed to .usage.
>>
>
> I could be wrong here but I think the memcg files are not renamed, so
> the same file names exist in v1 and v2. Can we follow that example?

I've enabled all the controllers, but I don't see files under
/sys/fs/cgroup that have the .limit_in_bytes or .usage_in_bytes suffix.

To what files are you referring to?

Thanks,
Giuseppe