From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 2/3] drm/i915: Lookup and attach ACPI device node for connectors Date: Wed, 20 Nov 2019 16:50:46 +0200 Message-ID: <87tv6ywqih.fsf@intel.com> References: <20191023001206.15741-1-rajatja@google.com> <20191104194147.185642-1-rajatja@google.com> <20191104194147.185642-2-rajatja@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191104194147.185642-2-rajatja@google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , Joonas Lahtinen , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= , Chris Wilson , Imre Deak , =?utf-8?Q?Jos=C3=A9?= Roberto de Souza , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, gregkh@linuxfoundation.org, mathewk@google.com, Daniel Thompson , Jonathan Corbet , Pavel Machek , seanpaul@google.com, Duncan Laurie , jsbarnes@google.com, Thierry Reding Cc: Rajat Jain , rajatxjain@gmail.com List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAwNCBOb3YgMjAxOSwgUmFqYXQgSmFpbiA8cmFqYXRqYUBnb29nbGUuY29tPiB3cm90 ZToKPiBMb29rdXAgYW5kIGF0dGFjaCBBQ1BJIG5vZGVzIGZvciBpbnRlbCBjb25uZWN0b3JzLiBU aGUgbG9va3VwIGlzIGRvbmUKPiBpbiBjb21wbGlhbmNlIHdpdGggQUNQSSBTcGVjIDYuMwo+IGh0 dHBzOi8vdWVmaS5vcmcvc2l0ZXMvZGVmYXVsdC9maWxlcy9yZXNvdXJjZXMvQUNQSV82XzNfZmlu YWxfSmFuMzAucGRmCj4gKFJlZjogUGFnZXMgMTExOSAtIDExMjMpLgo+Cj4gVGhpcyBjYW4gYmUg dXNlZnVsIGZvciBhbnkgY29ubmVjdG9yIHNwZWNpZmljIHBsYXRmb3JtIHByb3BlcnRpZXMuIChU aGlzCj4gd2lsbCBiZSB1c2VkIGZvciBwcml2YWN5IHNjcmVlbiBpbiBuZXh0IHBhdGNoKS4KPgo+ IFNpZ25lZC1vZmYtYnk6IFJhamF0IEphaW4gPHJhamF0amFAZ29vZ2xlLmNvbT4KPiBDaGFuZ2Ut SWQ6IEk3OThlNzA3MTRhNDQwMjU1NGM4Y2QyYThlNTgyNjgzNTNmNzU4MTRmCj4gLS0tCj4gdjI6 IGZvcm1lZCBieSBzcGxpdHRpbmcgdGhlIG9yaWdpbmFsIHBhdGNoIGludG8gQUNQSSBsb29rdXAs IGFuZCBwcml2YWN5Cj4gICAgIHNjcmVlbiBwcm9wZXJ0eS4gQWxzbyBtb3ZlIGl0IGludG8gaTkx NSBub3cgdGhhdCBJIGZvdW5kIGV4aXN0aW5nIGNvZGUKPiAgICAgaW4gaTkxNSB0aGF0IGNhbiBi ZSByZS11c2VkLgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5j ICAgICB8IDUwICsrKysrKysrKysrKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9hY3BpLmggICAgIHwgIDQgKy0KPiAgLi4uL2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfZGlzcGxheV90eXBlcy5oICAgIHwgIDMgKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kcC5jICAgICAgIHwgIDQgKysKPiAgNCBmaWxlcyBjaGFuZ2VkLCA2MCBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5 L2ludGVsX2FjcGkuYwo+IGluZGV4IDc0OGQ5YjMxMjVkZC4uMGMxMDUxNjQzMGIxIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMKPiBAQCAtMjQzLDMgKzI0 Myw1MyBAQCB2b2lkIGludGVsX3BvcHVsYXRlX2FjcGlfaWRzX2Zvcl9hbGxfY29ubmVjdG9ycyhz dHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldikKPiAgCX0KPiAgCWRybV9jb25uZWN0b3JfbGlzdF9p dGVyX2VuZCgmY29ubl9pdGVyKTsKPiAgfQo+ICsKPiArLyoKPiArICogUmVmOiBBQ1BJIFNwZWMg Ni4zCj4gKyAqIGh0dHBzOi8vdWVmaS5vcmcvc2l0ZXMvZGVmYXVsdC9maWxlcy9yZXNvdXJjZXMv QUNQSV82XzNfZmluYWxfSmFuMzAucGRmCj4gKyAqIFBhZ2VzIDExMTkgLSAxMTIzIGRlc2NyaWJl LCB3aGF0IEkgYmVsaWV2ZSwgYSBzdGFuZGFyZCB3YXkgb2YKPiArICogaWRlbnRpZnlpbmcgLyBh ZGRyZXNzaW5nICJkaXNwbGF5IHBhbmVscyIgaW4gdGhlIEFDUEkuIEl0IHByb3ZpZGVzCj4gKyAq IGEgd2F5IGZvciB0aGUgQUNQSSB0byBkZWZpbmUgZGV2aWNlcyBmb3IgdGhlIGRpc3BsYXkgcGFu ZWxzIGF0dGFjaGVkCj4gKyAqIHRvIHRoZSBzeXN0ZW0uIEl0IHRodXMgcHJvdmlkZXMgYSB3YXkg Zm9yIHRoZSBCSU9TIHRvIGV4cG9ydCBhbnkgcGFuZWwKPiArICogc3BlY2lmaWMgcHJvcGVydGll cyB0byB0aGUgc3lzdGVtIHZpYSBBQ1BJIChsaWtlIGRldmljZSB0cmVlcykuCj4gKyAqCj4gKyAq IFRoZSBmb2xsb3dpbmcgZnVuY3Rpb25zIGxvb2tzIHVwIHRoZSBBQ1BJIG5vZGUgZm9yIGEgY29u bmVjdG9yIGFuZCByZXR1cm5zCj4gKyAqIGl0LiBUZWNobmljYWxseSBpdCBpcyBpbmRlcGVuZGVu dCBmcm9tIHRoZSBpOTE1IGNvZGUsIGFuZAo+ICsgKiBpZGVhbGx5IG1heSBiZSBjYWxsZWQgZm9y IGFsbCBjb25uZWN0b3JzLiBJdCBpcyBnZW5lcmFsbHkgYSBnb29kIGlkZWEgdG8KPiArICogYmUg YWJsZSB0byBhdHRhY2ggYW4gQUNQSSBub2RlIHRvIGRlc2NyaWJlIGFueXRoaW5nIGlmIG5lZWRl ZC4gKFRoaXMgY2FuCj4gKyAqIGhlbHAgaW4gZnV0dXJlIGZvciBvdGhlciBwYW5lbCBzcGVjaWZp YyBmZWF0dXJlcyBtYXliZSkuIEhvd2V2ZXIsIGl0Cj4gKyAqIG5lZWRzIGFuIGFjcGkgZGV2aWNl IElEIHdoaWNoIGlzIGJ1aWxkIHVzaW5nIGFuIGluZGV4IHdpdGhpbiBhIHBhcnRpY3VsYXIKPiAr ICogdHlwZSBvZiBwb3J0IChSZWYgdG8gdGhlIHBhZ2VzIG9mIHNwZWMgbWVudGlvbmVkIGFib3Zl LCBhbmQgdG8gY29kZSBpbgo+ICsgKiBpbnRlbF9wb3B1bGF0ZV9hY3BpX2lkc19mb3JfYWxsX2Nv bm5lY3RvcnMoKSkuIFRoaXMgZGV2aWNlIGluZGV4Cj4gKyAqIHVuZm9ydHVuYXRlbHkgaXMgbm90 IGF2YWlsYWJsZSBpbiBEUk0gY29kZSwgc28gY3VycmVudGx5IGl0cyBjYWxsIGlzCj4gKyAqIG9y aWdpbmF0ZWQgZnJvbSBpOTE1IGRyaXZlci4gSWYgaW4gZnV0dXJlIHRoaXMgaXMgdXNlZnVsIGZv ciBvdGhlciBkcml2ZXJzCj4gKyAqIGFuZCB3ZSBjYW4gZmluZCBhIGdlbmVyaWMgd2F5IG9mIGdl dHRpbmcgYSBkZXZpY2UgaW5kZXgsIHdlIHNob3VsZCBtb3ZlIHRoaXMKPiArICogZnVuY3Rpb24g dG8gZHJtIGNvZGUsIG1heWJlLgo+ICsgKi8KPiArdm9pZCBpbnRlbF9jb25uZWN0b3JfbG9va3Vw X2FjcGlfbm9kZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICppbnRlbF9jb25uZWN0b3IpCgpOaXRw aWNrLCBJJ2QgZXhwZWN0IGEgImxvb2t1cCIgZnVuY3Rpb24gdG8gcmV0dXJuIHdoYXRldmVyIGl0 IGlzIGxvb2tpbmcKdXAsIG5vdCBtb2RpZnkgaXRzIGFyZ3VtZW50LgoKPiArewo+ICsJc3RydWN0 IGRybV9kZXZpY2UgKmRybV9kZXYgPSBpbnRlbF9jb25uZWN0b3ItPmJhc2UuZGV2Owo+ICsJc3Ry dWN0IGRldmljZSAqZGV2ID0gJmRybV9kZXYtPnBkZXYtPmRldjsKPiArCXN0cnVjdCBhY3BpX2Rl dmljZSAqY29ubl9kZXY7Cj4gKwl1NjQgY29ubl9hZGRyOwo+ICsKPiArCS8qCj4gKwkgKiBSZXBv cHVsYXRlIEFDUEkgSURzIGZvciBhbGwgY29ubmVjdG9ycyBpcyBuZWVkZWQgYmVjYXVzZSB0aGUg ZGlzcGxheQo+ICsJICogaW5kZXggbWF5IGhhdmUgY2hhbmdlZCBhcyBhIHJlc3VsdCBvZiBob3Rw bHVnZ2luZyBhbmQgdW5wbHVnZ2luZwo+ICsJICogY29ubmVjdG9ycwo+ICsJICovCgpJIHRoaW5r IHRoYXQgY2FuIG9ubHkgYmUgdHJ1ZSBmb3IgRFAgTVNULiBGb3IgZXZlcnl0aGluZyBlbHNlLCBJ IGRvbid0CnRoaW5rIHNvLiBBbnl3YXksIHdoeSBhcmUgd2UgZG9pbmcgaXQgaGVyZSB0aGVuLCBk ZXBlbmRpbmcgb24gd2hldGhlcgpzb21lb25lIGNhbGxzIHRoaXMgZnVuY3Rpb24gb3Igbm90PyBJ ZiBpdCBtYXR0ZXJzLCB3ZSBzaG91bGQgYmUgZG9pbmcKdGhpcyB3aGVuZXZlciB0aGVyZSdzIGEg Y2hhbmNlIHRoZXkndmUgY2hhbmdlZCwgcmlnaHQ/Cgo+ICsJaW50ZWxfcG9wdWxhdGVfYWNwaV9p ZHNfZm9yX2FsbF9jb25uZWN0b3JzKGRybV9kZXYpOwo+ICsKPiArCS8qIEJ1aWxkIHRoZSBfQURS IHRvIGxvb2sgZm9yICovCj4gKwljb25uX2FkZHIgPSBpbnRlbF9jb25uZWN0b3ItPmFjcGlfZGV2 aWNlX2lkOwo+ICsJY29ubl9hZGRyIHw9IEFDUElfREVWSUNFX0lEX1NDSEVNRTsKPiArCWNvbm5f YWRkciB8PSBBQ1BJX0JJT1NfQ0FOX0RFVEVDVDsKPiArCj4gKwlEUk1fREVWX0lORk8oZGV2LCAi TG9va2luZyBmb3IgY29ubmVjdG9yIEFDUEkgbm9kZSBhdCBfQURSPSVsbFhcbiIsCj4gKwkJICAg ICBjb25uX2FkZHIpOwo+ICsKPiArCS8qIExvb2sgdXAgdGhlIGNvbm5lY3RvciBkZXZpY2UsIHVu ZGVyIHRoZSBQQ0kgZGV2aWNlICovCj4gKwljb25uX2RldiA9IGFjcGlfZmluZF9jaGlsZF9kZXZp Y2UoQUNQSV9DT01QQU5JT04oZGV2KSwgY29ubl9hZGRyLAo+ICsJCQkJCSAgZmFsc2UpOwo+ICsJ aW50ZWxfY29ubmVjdG9yLT5hY3BpX2hhbmRsZSA9IGNvbm5fZGV2ID8gY29ubl9kZXYtPmhhbmRs ZSA6IE5VTEw7CgpXaHkgZG9uJ3Qgd2UgZG8gdGhpcyBhcyBwYXJ0IG9mCmludGVsX3BvcHVsYXRl X2FjcGlfaWRzX2Zvcl9hbGxfY29ubmVjdG9ycygpIG9yIHdoYXRldmVyIGl0J2xsIGJlCmNhbGxl ZD8KCj4gK30KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9hY3BpLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2FjcGkuaAo+IGlu ZGV4IDhmNmQ4NTBkZjZmYS4uNjFhNDM5MmZhYzRhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZGlzcGxheS9pbnRlbF9hY3BpLmgKPiBAQCAtOSwxNCArOSwxNiBAQAo+ICAjaW5jbHVkZSAi aW50ZWxfZGlzcGxheV90eXBlcy5oIgo+ICAKPiAgI2lmZGVmIENPTkZJR19BQ1BJCj4gK3ZvaWQg aW50ZWxfY29ubmVjdG9yX2xvb2t1cF9hY3BpX25vZGUoc3RydWN0IGludGVsX2Nvbm5lY3RvciAq Y29ubmVjdG9yKTsKPiAgdm9pZCBpbnRlbF9yZWdpc3Rlcl9kc21faGFuZGxlcih2b2lkKTsKPiAg dm9pZCBpbnRlbF91bnJlZ2lzdGVyX2RzbV9oYW5kbGVyKHZvaWQpOwo+ICB2b2lkIGludGVsX3Bv cHVsYXRlX2FjcGlfaWRzX2Zvcl9hbGxfY29ubmVjdG9ycyhzdHJ1Y3QgZHJtX2RldmljZSAqZHJt X2Rldik7Cj4gICNlbHNlCj4gK3N0YXRpYyBpbmxpbmUgdm9pZAo+ICtpbnRlbF9jb25uZWN0b3Jf bG9va3VwX2FjcGlfbm9kZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpIHsgcmV0 dXJuOyB9Cj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBpbnRlbF9yZWdpc3Rlcl9kc21faGFuZGxlcih2 b2lkKSB7IHJldHVybjsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQgaW50ZWxfdW5yZWdpc3Rlcl9k c21faGFuZGxlcih2b2lkKSB7IHJldHVybjsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQKPiAtc3Rh dGljIGlubGluZSB2b2lkCgpXaG9vcHMuCgo+ICBpbnRlbF9wb3B1bGF0ZV9hY3BpX2lkc19mb3Jf YWxsX2Nvbm5lY3RvcnMoc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXYpIHsgfQo+ICAjZW5kaWYg LyogQ09ORklHX0FDUEkgKi8KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2Rpc3BsYXkvaW50ZWxfZGlzcGxheV90eXBlcy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kaXNwbGF5X3R5cGVzLmgKPiBpbmRleCA0NDlhYmFlYTYxOWYuLmMyNzA2YWZj MDY5YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rp c3BsYXlfdHlwZXMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf ZGlzcGxheV90eXBlcy5oCj4gQEAgLTQwMCw2ICs0MDAsOSBAQCBzdHJ1Y3QgaW50ZWxfY29ubmVj dG9yIHsKPiAgCS8qIEFDUEkgZGV2aWNlIGlkIGZvciBBQ1BJIGFuZCBkcml2ZXIgY29vcGVyYXRp b24gKi8KPiAgCXUzMiBhY3BpX2RldmljZV9pZDsKPiAgCj4gKwkvKiBBQ1BJIGhhbmRsZSBjb3Jy ZXNwb25kaW5nIHRvIHRoaXMgY29ubmVjdG9yIGRpc3BsYXksIGlmIGZvdW5kICovCj4gKwl2b2lk ICphY3BpX2hhbmRsZTsKPiArCj4gIAkvKiBSZWFkcyBvdXQgdGhlIGN1cnJlbnQgaHcsIHJldHVy bmluZyB0cnVlIGlmIHRoZSBjb25uZWN0b3IgaXMgZW5hYmxlZAo+ICAJICogYW5kIGFjdGl2ZSAo aS5lLiBkcG1zIE9OIHN0YXRlKS4gKi8KPiAgCWJvb2wgKCpnZXRfaHdfc3RhdGUpKHN0cnVjdCBp bnRlbF9jb25uZWN0b3IgKik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHAu Ywo+IGluZGV4IGY4NjU2MTUxNzJhNS4uNGZhYzQwOGE0Mjk5IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHAuYwo+IEBAIC00NSw2ICs0NSw3IEBACj4gICNpbmNsdWRl ICJpOTE1X2RlYnVnZnMuaCIKPiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4gICNpbmNsdWRlICJp OTE1X3RyYWNlLmgiCj4gKyNpbmNsdWRlICJpbnRlbF9hY3BpLmgiCj4gICNpbmNsdWRlICJpbnRl bF9hdG9taWMuaCIKPiAgI2luY2x1ZGUgImludGVsX2F1ZGlvLmgiCj4gICNpbmNsdWRlICJpbnRl bF9jb25uZWN0b3IuaCIKPiBAQCAtNjMzMyw2ICs2MzM0LDcgQEAgaW50ZWxfZHBfYWRkX3Byb3Bl cnRpZXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgc3RydWN0IGRybV9jb25uZWN0b3IgKmNv bm5lY3QKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShjb25uZWN0b3ItPmRldik7Cj4gIAllbnVtIHBvcnQgcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGlu dGVsX2RwKS0+YmFzZS5wb3J0Owo+ICsJc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxfY29u bmVjdG9yID0gdG9faW50ZWxfY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gIAo+ICAJaWYgKCFJU19H NFgoZGV2X3ByaXYpICYmIHBvcnQgIT0gUE9SVF9BKQo+ICAJCWludGVsX2F0dGFjaF9mb3JjZV9h dWRpb19wcm9wZXJ0eShjb25uZWN0b3IpOwo+IEBAIC02MzU0LDYgKzYzNTYsOCBAQCBpbnRlbF9k cF9hZGRfcHJvcGVydGllcyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBzdHJ1Y3QgZHJtX2Nv bm5lY3RvciAqY29ubmVjdAo+ICAKPiAgCQljb25uZWN0b3ItPnN0YXRlLT5zY2FsaW5nX21vZGUg PSBEUk1fTU9ERV9TQ0FMRV9BU1BFQ1Q7Cj4gIAo+ICsJCS8qIExvb2t1cCB0aGUgQUNQSSBub2Rl IGNvcnJlc3BvbmRpbmcgdG8gdGhlIGNvbm5lY3RvciAqLwo+ICsJCWludGVsX2Nvbm5lY3Rvcl9s b29rdXBfYWNwaV9ub2RlKGludGVsX2Nvbm5lY3Rvcik7CgpUaGlzIGlzIGFuIG9kZCBwbGFjZSB0 byBkbyB0aGlzLCBpc24ndCBpdD8gSXQncyBvbmx5IGNhbGxlZCBvbmNlLCBidXQKeW91IHNheSB0 aGUgYWNwaSBpZCBtYXkgY2hhbmdlIGF0IGhvdHBsdWcuCgpCUiwKSmFuaS4KCj4gIAl9Cj4gIH0K Ci0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08DA9C432C0 for ; Wed, 20 Nov 2019 14:51:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9F4320714 for ; Wed, 20 Nov 2019 14:51:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9F4320714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 075596EA6B; Wed, 20 Nov 2019 14:51:00 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AA986EA5C; Wed, 20 Nov 2019 14:50:58 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 06:50:57 -0800 X-IronPort-AV: E=Sophos;i="5.69,222,1571727600"; d="scan'208";a="200739584" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 06:50:49 -0800 From: Jani Nikula To: Rajat Jain , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , Joonas Lahtinen , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= , Chris Wilson , Imre Deak , =?utf-8?Q?Jos=C3=A9?= Roberto de Souza , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, gregkh@linuxfoundation.org, mathewk@google.com, Daniel Thompson , Jonathan Corbet , Pavel Machek , seanpaul@google.com, Duncan Laurie , jsbarnes@google.com, Thierry Reding Subject: Re: [PATCH v2 2/3] drm/i915: Lookup and attach ACPI device node for connectors In-Reply-To: <20191104194147.185642-2-rajatja@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191023001206.15741-1-rajatja@google.com> <20191104194147.185642-1-rajatja@google.com> <20191104194147.185642-2-rajatja@google.com> Date: Wed, 20 Nov 2019 16:50:46 +0200 Message-ID: <87tv6ywqih.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rajat Jain , rajatxjain@gmail.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191120145046.2uq7IhvOCAevQqaOke3CrVcDW_DGTM17KUt-skDxSZY@z> T24gTW9uLCAwNCBOb3YgMjAxOSwgUmFqYXQgSmFpbiA8cmFqYXRqYUBnb29nbGUuY29tPiB3cm90 ZToKPiBMb29rdXAgYW5kIGF0dGFjaCBBQ1BJIG5vZGVzIGZvciBpbnRlbCBjb25uZWN0b3JzLiBU aGUgbG9va3VwIGlzIGRvbmUKPiBpbiBjb21wbGlhbmNlIHdpdGggQUNQSSBTcGVjIDYuMwo+IGh0 dHBzOi8vdWVmaS5vcmcvc2l0ZXMvZGVmYXVsdC9maWxlcy9yZXNvdXJjZXMvQUNQSV82XzNfZmlu YWxfSmFuMzAucGRmCj4gKFJlZjogUGFnZXMgMTExOSAtIDExMjMpLgo+Cj4gVGhpcyBjYW4gYmUg dXNlZnVsIGZvciBhbnkgY29ubmVjdG9yIHNwZWNpZmljIHBsYXRmb3JtIHByb3BlcnRpZXMuIChU aGlzCj4gd2lsbCBiZSB1c2VkIGZvciBwcml2YWN5IHNjcmVlbiBpbiBuZXh0IHBhdGNoKS4KPgo+ IFNpZ25lZC1vZmYtYnk6IFJhamF0IEphaW4gPHJhamF0amFAZ29vZ2xlLmNvbT4KPiBDaGFuZ2Ut SWQ6IEk3OThlNzA3MTRhNDQwMjU1NGM4Y2QyYThlNTgyNjgzNTNmNzU4MTRmCj4gLS0tCj4gdjI6 IGZvcm1lZCBieSBzcGxpdHRpbmcgdGhlIG9yaWdpbmFsIHBhdGNoIGludG8gQUNQSSBsb29rdXAs IGFuZCBwcml2YWN5Cj4gICAgIHNjcmVlbiBwcm9wZXJ0eS4gQWxzbyBtb3ZlIGl0IGludG8gaTkx NSBub3cgdGhhdCBJIGZvdW5kIGV4aXN0aW5nIGNvZGUKPiAgICAgaW4gaTkxNSB0aGF0IGNhbiBi ZSByZS11c2VkLgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5j ICAgICB8IDUwICsrKysrKysrKysrKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9hY3BpLmggICAgIHwgIDQgKy0KPiAgLi4uL2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfZGlzcGxheV90eXBlcy5oICAgIHwgIDMgKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kcC5jICAgICAgIHwgIDQgKysKPiAgNCBmaWxlcyBjaGFuZ2VkLCA2MCBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5 L2ludGVsX2FjcGkuYwo+IGluZGV4IDc0OGQ5YjMxMjVkZC4uMGMxMDUxNjQzMGIxIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMKPiBAQCAtMjQzLDMgKzI0 Myw1MyBAQCB2b2lkIGludGVsX3BvcHVsYXRlX2FjcGlfaWRzX2Zvcl9hbGxfY29ubmVjdG9ycyhz dHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldikKPiAgCX0KPiAgCWRybV9jb25uZWN0b3JfbGlzdF9p dGVyX2VuZCgmY29ubl9pdGVyKTsKPiAgfQo+ICsKPiArLyoKPiArICogUmVmOiBBQ1BJIFNwZWMg Ni4zCj4gKyAqIGh0dHBzOi8vdWVmaS5vcmcvc2l0ZXMvZGVmYXVsdC9maWxlcy9yZXNvdXJjZXMv QUNQSV82XzNfZmluYWxfSmFuMzAucGRmCj4gKyAqIFBhZ2VzIDExMTkgLSAxMTIzIGRlc2NyaWJl LCB3aGF0IEkgYmVsaWV2ZSwgYSBzdGFuZGFyZCB3YXkgb2YKPiArICogaWRlbnRpZnlpbmcgLyBh ZGRyZXNzaW5nICJkaXNwbGF5IHBhbmVscyIgaW4gdGhlIEFDUEkuIEl0IHByb3ZpZGVzCj4gKyAq IGEgd2F5IGZvciB0aGUgQUNQSSB0byBkZWZpbmUgZGV2aWNlcyBmb3IgdGhlIGRpc3BsYXkgcGFu ZWxzIGF0dGFjaGVkCj4gKyAqIHRvIHRoZSBzeXN0ZW0uIEl0IHRodXMgcHJvdmlkZXMgYSB3YXkg Zm9yIHRoZSBCSU9TIHRvIGV4cG9ydCBhbnkgcGFuZWwKPiArICogc3BlY2lmaWMgcHJvcGVydGll cyB0byB0aGUgc3lzdGVtIHZpYSBBQ1BJIChsaWtlIGRldmljZSB0cmVlcykuCj4gKyAqCj4gKyAq IFRoZSBmb2xsb3dpbmcgZnVuY3Rpb25zIGxvb2tzIHVwIHRoZSBBQ1BJIG5vZGUgZm9yIGEgY29u bmVjdG9yIGFuZCByZXR1cm5zCj4gKyAqIGl0LiBUZWNobmljYWxseSBpdCBpcyBpbmRlcGVuZGVu dCBmcm9tIHRoZSBpOTE1IGNvZGUsIGFuZAo+ICsgKiBpZGVhbGx5IG1heSBiZSBjYWxsZWQgZm9y IGFsbCBjb25uZWN0b3JzLiBJdCBpcyBnZW5lcmFsbHkgYSBnb29kIGlkZWEgdG8KPiArICogYmUg YWJsZSB0byBhdHRhY2ggYW4gQUNQSSBub2RlIHRvIGRlc2NyaWJlIGFueXRoaW5nIGlmIG5lZWRl ZC4gKFRoaXMgY2FuCj4gKyAqIGhlbHAgaW4gZnV0dXJlIGZvciBvdGhlciBwYW5lbCBzcGVjaWZp YyBmZWF0dXJlcyBtYXliZSkuIEhvd2V2ZXIsIGl0Cj4gKyAqIG5lZWRzIGFuIGFjcGkgZGV2aWNl IElEIHdoaWNoIGlzIGJ1aWxkIHVzaW5nIGFuIGluZGV4IHdpdGhpbiBhIHBhcnRpY3VsYXIKPiAr ICogdHlwZSBvZiBwb3J0IChSZWYgdG8gdGhlIHBhZ2VzIG9mIHNwZWMgbWVudGlvbmVkIGFib3Zl LCBhbmQgdG8gY29kZSBpbgo+ICsgKiBpbnRlbF9wb3B1bGF0ZV9hY3BpX2lkc19mb3JfYWxsX2Nv bm5lY3RvcnMoKSkuIFRoaXMgZGV2aWNlIGluZGV4Cj4gKyAqIHVuZm9ydHVuYXRlbHkgaXMgbm90 IGF2YWlsYWJsZSBpbiBEUk0gY29kZSwgc28gY3VycmVudGx5IGl0cyBjYWxsIGlzCj4gKyAqIG9y aWdpbmF0ZWQgZnJvbSBpOTE1IGRyaXZlci4gSWYgaW4gZnV0dXJlIHRoaXMgaXMgdXNlZnVsIGZv ciBvdGhlciBkcml2ZXJzCj4gKyAqIGFuZCB3ZSBjYW4gZmluZCBhIGdlbmVyaWMgd2F5IG9mIGdl dHRpbmcgYSBkZXZpY2UgaW5kZXgsIHdlIHNob3VsZCBtb3ZlIHRoaXMKPiArICogZnVuY3Rpb24g dG8gZHJtIGNvZGUsIG1heWJlLgo+ICsgKi8KPiArdm9pZCBpbnRlbF9jb25uZWN0b3JfbG9va3Vw X2FjcGlfbm9kZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICppbnRlbF9jb25uZWN0b3IpCgpOaXRw aWNrLCBJJ2QgZXhwZWN0IGEgImxvb2t1cCIgZnVuY3Rpb24gdG8gcmV0dXJuIHdoYXRldmVyIGl0 IGlzIGxvb2tpbmcKdXAsIG5vdCBtb2RpZnkgaXRzIGFyZ3VtZW50LgoKPiArewo+ICsJc3RydWN0 IGRybV9kZXZpY2UgKmRybV9kZXYgPSBpbnRlbF9jb25uZWN0b3ItPmJhc2UuZGV2Owo+ICsJc3Ry dWN0IGRldmljZSAqZGV2ID0gJmRybV9kZXYtPnBkZXYtPmRldjsKPiArCXN0cnVjdCBhY3BpX2Rl dmljZSAqY29ubl9kZXY7Cj4gKwl1NjQgY29ubl9hZGRyOwo+ICsKPiArCS8qCj4gKwkgKiBSZXBv cHVsYXRlIEFDUEkgSURzIGZvciBhbGwgY29ubmVjdG9ycyBpcyBuZWVkZWQgYmVjYXVzZSB0aGUg ZGlzcGxheQo+ICsJICogaW5kZXggbWF5IGhhdmUgY2hhbmdlZCBhcyBhIHJlc3VsdCBvZiBob3Rw bHVnZ2luZyBhbmQgdW5wbHVnZ2luZwo+ICsJICogY29ubmVjdG9ycwo+ICsJICovCgpJIHRoaW5r IHRoYXQgY2FuIG9ubHkgYmUgdHJ1ZSBmb3IgRFAgTVNULiBGb3IgZXZlcnl0aGluZyBlbHNlLCBJ IGRvbid0CnRoaW5rIHNvLiBBbnl3YXksIHdoeSBhcmUgd2UgZG9pbmcgaXQgaGVyZSB0aGVuLCBk ZXBlbmRpbmcgb24gd2hldGhlcgpzb21lb25lIGNhbGxzIHRoaXMgZnVuY3Rpb24gb3Igbm90PyBJ ZiBpdCBtYXR0ZXJzLCB3ZSBzaG91bGQgYmUgZG9pbmcKdGhpcyB3aGVuZXZlciB0aGVyZSdzIGEg Y2hhbmNlIHRoZXkndmUgY2hhbmdlZCwgcmlnaHQ/Cgo+ICsJaW50ZWxfcG9wdWxhdGVfYWNwaV9p ZHNfZm9yX2FsbF9jb25uZWN0b3JzKGRybV9kZXYpOwo+ICsKPiArCS8qIEJ1aWxkIHRoZSBfQURS IHRvIGxvb2sgZm9yICovCj4gKwljb25uX2FkZHIgPSBpbnRlbF9jb25uZWN0b3ItPmFjcGlfZGV2 aWNlX2lkOwo+ICsJY29ubl9hZGRyIHw9IEFDUElfREVWSUNFX0lEX1NDSEVNRTsKPiArCWNvbm5f YWRkciB8PSBBQ1BJX0JJT1NfQ0FOX0RFVEVDVDsKPiArCj4gKwlEUk1fREVWX0lORk8oZGV2LCAi TG9va2luZyBmb3IgY29ubmVjdG9yIEFDUEkgbm9kZSBhdCBfQURSPSVsbFhcbiIsCj4gKwkJICAg ICBjb25uX2FkZHIpOwo+ICsKPiArCS8qIExvb2sgdXAgdGhlIGNvbm5lY3RvciBkZXZpY2UsIHVu ZGVyIHRoZSBQQ0kgZGV2aWNlICovCj4gKwljb25uX2RldiA9IGFjcGlfZmluZF9jaGlsZF9kZXZp Y2UoQUNQSV9DT01QQU5JT04oZGV2KSwgY29ubl9hZGRyLAo+ICsJCQkJCSAgZmFsc2UpOwo+ICsJ aW50ZWxfY29ubmVjdG9yLT5hY3BpX2hhbmRsZSA9IGNvbm5fZGV2ID8gY29ubl9kZXYtPmhhbmRs ZSA6IE5VTEw7CgpXaHkgZG9uJ3Qgd2UgZG8gdGhpcyBhcyBwYXJ0IG9mCmludGVsX3BvcHVsYXRl X2FjcGlfaWRzX2Zvcl9hbGxfY29ubmVjdG9ycygpIG9yIHdoYXRldmVyIGl0J2xsIGJlCmNhbGxl ZD8KCj4gK30KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9hY3BpLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2FjcGkuaAo+IGlu ZGV4IDhmNmQ4NTBkZjZmYS4uNjFhNDM5MmZhYzRhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZGlzcGxheS9pbnRlbF9hY3BpLmgKPiBAQCAtOSwxNCArOSwxNiBAQAo+ICAjaW5jbHVkZSAi aW50ZWxfZGlzcGxheV90eXBlcy5oIgo+ICAKPiAgI2lmZGVmIENPTkZJR19BQ1BJCj4gK3ZvaWQg aW50ZWxfY29ubmVjdG9yX2xvb2t1cF9hY3BpX25vZGUoc3RydWN0IGludGVsX2Nvbm5lY3RvciAq Y29ubmVjdG9yKTsKPiAgdm9pZCBpbnRlbF9yZWdpc3Rlcl9kc21faGFuZGxlcih2b2lkKTsKPiAg dm9pZCBpbnRlbF91bnJlZ2lzdGVyX2RzbV9oYW5kbGVyKHZvaWQpOwo+ICB2b2lkIGludGVsX3Bv cHVsYXRlX2FjcGlfaWRzX2Zvcl9hbGxfY29ubmVjdG9ycyhzdHJ1Y3QgZHJtX2RldmljZSAqZHJt X2Rldik7Cj4gICNlbHNlCj4gK3N0YXRpYyBpbmxpbmUgdm9pZAo+ICtpbnRlbF9jb25uZWN0b3Jf bG9va3VwX2FjcGlfbm9kZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpIHsgcmV0 dXJuOyB9Cj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBpbnRlbF9yZWdpc3Rlcl9kc21faGFuZGxlcih2 b2lkKSB7IHJldHVybjsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQgaW50ZWxfdW5yZWdpc3Rlcl9k c21faGFuZGxlcih2b2lkKSB7IHJldHVybjsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQKPiAtc3Rh dGljIGlubGluZSB2b2lkCgpXaG9vcHMuCgo+ICBpbnRlbF9wb3B1bGF0ZV9hY3BpX2lkc19mb3Jf YWxsX2Nvbm5lY3RvcnMoc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXYpIHsgfQo+ICAjZW5kaWYg LyogQ09ORklHX0FDUEkgKi8KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2Rpc3BsYXkvaW50ZWxfZGlzcGxheV90eXBlcy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kaXNwbGF5X3R5cGVzLmgKPiBpbmRleCA0NDlhYmFlYTYxOWYuLmMyNzA2YWZj MDY5YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rp c3BsYXlfdHlwZXMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf ZGlzcGxheV90eXBlcy5oCj4gQEAgLTQwMCw2ICs0MDAsOSBAQCBzdHJ1Y3QgaW50ZWxfY29ubmVj dG9yIHsKPiAgCS8qIEFDUEkgZGV2aWNlIGlkIGZvciBBQ1BJIGFuZCBkcml2ZXIgY29vcGVyYXRp b24gKi8KPiAgCXUzMiBhY3BpX2RldmljZV9pZDsKPiAgCj4gKwkvKiBBQ1BJIGhhbmRsZSBjb3Jy ZXNwb25kaW5nIHRvIHRoaXMgY29ubmVjdG9yIGRpc3BsYXksIGlmIGZvdW5kICovCj4gKwl2b2lk ICphY3BpX2hhbmRsZTsKPiArCj4gIAkvKiBSZWFkcyBvdXQgdGhlIGN1cnJlbnQgaHcsIHJldHVy bmluZyB0cnVlIGlmIHRoZSBjb25uZWN0b3IgaXMgZW5hYmxlZAo+ICAJICogYW5kIGFjdGl2ZSAo aS5lLiBkcG1zIE9OIHN0YXRlKS4gKi8KPiAgCWJvb2wgKCpnZXRfaHdfc3RhdGUpKHN0cnVjdCBp bnRlbF9jb25uZWN0b3IgKik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHAu Ywo+IGluZGV4IGY4NjU2MTUxNzJhNS4uNGZhYzQwOGE0Mjk5IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHAuYwo+IEBAIC00NSw2ICs0NSw3IEBACj4gICNpbmNsdWRl ICJpOTE1X2RlYnVnZnMuaCIKPiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4gICNpbmNsdWRlICJp OTE1X3RyYWNlLmgiCj4gKyNpbmNsdWRlICJpbnRlbF9hY3BpLmgiCj4gICNpbmNsdWRlICJpbnRl bF9hdG9taWMuaCIKPiAgI2luY2x1ZGUgImludGVsX2F1ZGlvLmgiCj4gICNpbmNsdWRlICJpbnRl bF9jb25uZWN0b3IuaCIKPiBAQCAtNjMzMyw2ICs2MzM0LDcgQEAgaW50ZWxfZHBfYWRkX3Byb3Bl cnRpZXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgc3RydWN0IGRybV9jb25uZWN0b3IgKmNv bm5lY3QKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShjb25uZWN0b3ItPmRldik7Cj4gIAllbnVtIHBvcnQgcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGlu dGVsX2RwKS0+YmFzZS5wb3J0Owo+ICsJc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxfY29u bmVjdG9yID0gdG9faW50ZWxfY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gIAo+ICAJaWYgKCFJU19H NFgoZGV2X3ByaXYpICYmIHBvcnQgIT0gUE9SVF9BKQo+ICAJCWludGVsX2F0dGFjaF9mb3JjZV9h dWRpb19wcm9wZXJ0eShjb25uZWN0b3IpOwo+IEBAIC02MzU0LDYgKzYzNTYsOCBAQCBpbnRlbF9k cF9hZGRfcHJvcGVydGllcyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBzdHJ1Y3QgZHJtX2Nv bm5lY3RvciAqY29ubmVjdAo+ICAKPiAgCQljb25uZWN0b3ItPnN0YXRlLT5zY2FsaW5nX21vZGUg PSBEUk1fTU9ERV9TQ0FMRV9BU1BFQ1Q7Cj4gIAo+ICsJCS8qIExvb2t1cCB0aGUgQUNQSSBub2Rl IGNvcnJlc3BvbmRpbmcgdG8gdGhlIGNvbm5lY3RvciAqLwo+ICsJCWludGVsX2Nvbm5lY3Rvcl9s b29rdXBfYWNwaV9ub2RlKGludGVsX2Nvbm5lY3Rvcik7CgpUaGlzIGlzIGFuIG9kZCBwbGFjZSB0 byBkbyB0aGlzLCBpc24ndCBpdD8gSXQncyBvbmx5IGNhbGxlZCBvbmNlLCBidXQKeW91IHNheSB0 aGUgYWNwaSBpZCBtYXkgY2hhbmdlIGF0IGhvdHBsdWcuCgpCUiwKSmFuaS4KCj4gIAl9Cj4gIH0K Ci0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92739C432C3 for ; Wed, 20 Nov 2019 14:51:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EC66206DA for ; Wed, 20 Nov 2019 14:51:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EC66206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DBFD06EA5C; Wed, 20 Nov 2019 14:50:59 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AA986EA5C; Wed, 20 Nov 2019 14:50:58 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 06:50:57 -0800 X-IronPort-AV: E=Sophos;i="5.69,222,1571727600"; d="scan'208";a="200739584" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 06:50:49 -0800 From: Jani Nikula To: Rajat Jain , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , Joonas Lahtinen , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= , Chris Wilson , Imre Deak , =?utf-8?Q?Jos=C3=A9?= Roberto de Souza , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, gregkh@linuxfoundation.org, mathewk@google.com, Daniel Thompson , Jonathan Corbet , Pavel Machek , seanpaul@google.com, Duncan Laurie , jsbarnes@google.com, Thierry Reding In-Reply-To: <20191104194147.185642-2-rajatja@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191023001206.15741-1-rajatja@google.com> <20191104194147.185642-1-rajatja@google.com> <20191104194147.185642-2-rajatja@google.com> Date: Wed, 20 Nov 2019 16:50:46 +0200 Message-ID: <87tv6ywqih.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Lookup and attach ACPI device node for connectors X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rajat Jain , rajatxjain@gmail.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191120145046.wkPg3nSxlrFL4uJz6UpLa8En5SJ0TNnhh_qO24fMjNU@z> T24gTW9uLCAwNCBOb3YgMjAxOSwgUmFqYXQgSmFpbiA8cmFqYXRqYUBnb29nbGUuY29tPiB3cm90 ZToKPiBMb29rdXAgYW5kIGF0dGFjaCBBQ1BJIG5vZGVzIGZvciBpbnRlbCBjb25uZWN0b3JzLiBU aGUgbG9va3VwIGlzIGRvbmUKPiBpbiBjb21wbGlhbmNlIHdpdGggQUNQSSBTcGVjIDYuMwo+IGh0 dHBzOi8vdWVmaS5vcmcvc2l0ZXMvZGVmYXVsdC9maWxlcy9yZXNvdXJjZXMvQUNQSV82XzNfZmlu YWxfSmFuMzAucGRmCj4gKFJlZjogUGFnZXMgMTExOSAtIDExMjMpLgo+Cj4gVGhpcyBjYW4gYmUg dXNlZnVsIGZvciBhbnkgY29ubmVjdG9yIHNwZWNpZmljIHBsYXRmb3JtIHByb3BlcnRpZXMuIChU aGlzCj4gd2lsbCBiZSB1c2VkIGZvciBwcml2YWN5IHNjcmVlbiBpbiBuZXh0IHBhdGNoKS4KPgo+ IFNpZ25lZC1vZmYtYnk6IFJhamF0IEphaW4gPHJhamF0amFAZ29vZ2xlLmNvbT4KPiBDaGFuZ2Ut SWQ6IEk3OThlNzA3MTRhNDQwMjU1NGM4Y2QyYThlNTgyNjgzNTNmNzU4MTRmCj4gLS0tCj4gdjI6 IGZvcm1lZCBieSBzcGxpdHRpbmcgdGhlIG9yaWdpbmFsIHBhdGNoIGludG8gQUNQSSBsb29rdXAs IGFuZCBwcml2YWN5Cj4gICAgIHNjcmVlbiBwcm9wZXJ0eS4gQWxzbyBtb3ZlIGl0IGludG8gaTkx NSBub3cgdGhhdCBJIGZvdW5kIGV4aXN0aW5nIGNvZGUKPiAgICAgaW4gaTkxNSB0aGF0IGNhbiBi ZSByZS11c2VkLgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5j ICAgICB8IDUwICsrKysrKysrKysrKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9hY3BpLmggICAgIHwgIDQgKy0KPiAgLi4uL2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfZGlzcGxheV90eXBlcy5oICAgIHwgIDMgKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kcC5jICAgICAgIHwgIDQgKysKPiAgNCBmaWxlcyBjaGFuZ2VkLCA2MCBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5 L2ludGVsX2FjcGkuYwo+IGluZGV4IDc0OGQ5YjMxMjVkZC4uMGMxMDUxNjQzMGIxIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMKPiBAQCAtMjQzLDMgKzI0 Myw1MyBAQCB2b2lkIGludGVsX3BvcHVsYXRlX2FjcGlfaWRzX2Zvcl9hbGxfY29ubmVjdG9ycyhz dHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldikKPiAgCX0KPiAgCWRybV9jb25uZWN0b3JfbGlzdF9p dGVyX2VuZCgmY29ubl9pdGVyKTsKPiAgfQo+ICsKPiArLyoKPiArICogUmVmOiBBQ1BJIFNwZWMg Ni4zCj4gKyAqIGh0dHBzOi8vdWVmaS5vcmcvc2l0ZXMvZGVmYXVsdC9maWxlcy9yZXNvdXJjZXMv QUNQSV82XzNfZmluYWxfSmFuMzAucGRmCj4gKyAqIFBhZ2VzIDExMTkgLSAxMTIzIGRlc2NyaWJl LCB3aGF0IEkgYmVsaWV2ZSwgYSBzdGFuZGFyZCB3YXkgb2YKPiArICogaWRlbnRpZnlpbmcgLyBh ZGRyZXNzaW5nICJkaXNwbGF5IHBhbmVscyIgaW4gdGhlIEFDUEkuIEl0IHByb3ZpZGVzCj4gKyAq IGEgd2F5IGZvciB0aGUgQUNQSSB0byBkZWZpbmUgZGV2aWNlcyBmb3IgdGhlIGRpc3BsYXkgcGFu ZWxzIGF0dGFjaGVkCj4gKyAqIHRvIHRoZSBzeXN0ZW0uIEl0IHRodXMgcHJvdmlkZXMgYSB3YXkg Zm9yIHRoZSBCSU9TIHRvIGV4cG9ydCBhbnkgcGFuZWwKPiArICogc3BlY2lmaWMgcHJvcGVydGll cyB0byB0aGUgc3lzdGVtIHZpYSBBQ1BJIChsaWtlIGRldmljZSB0cmVlcykuCj4gKyAqCj4gKyAq IFRoZSBmb2xsb3dpbmcgZnVuY3Rpb25zIGxvb2tzIHVwIHRoZSBBQ1BJIG5vZGUgZm9yIGEgY29u bmVjdG9yIGFuZCByZXR1cm5zCj4gKyAqIGl0LiBUZWNobmljYWxseSBpdCBpcyBpbmRlcGVuZGVu dCBmcm9tIHRoZSBpOTE1IGNvZGUsIGFuZAo+ICsgKiBpZGVhbGx5IG1heSBiZSBjYWxsZWQgZm9y IGFsbCBjb25uZWN0b3JzLiBJdCBpcyBnZW5lcmFsbHkgYSBnb29kIGlkZWEgdG8KPiArICogYmUg YWJsZSB0byBhdHRhY2ggYW4gQUNQSSBub2RlIHRvIGRlc2NyaWJlIGFueXRoaW5nIGlmIG5lZWRl ZC4gKFRoaXMgY2FuCj4gKyAqIGhlbHAgaW4gZnV0dXJlIGZvciBvdGhlciBwYW5lbCBzcGVjaWZp YyBmZWF0dXJlcyBtYXliZSkuIEhvd2V2ZXIsIGl0Cj4gKyAqIG5lZWRzIGFuIGFjcGkgZGV2aWNl IElEIHdoaWNoIGlzIGJ1aWxkIHVzaW5nIGFuIGluZGV4IHdpdGhpbiBhIHBhcnRpY3VsYXIKPiAr ICogdHlwZSBvZiBwb3J0IChSZWYgdG8gdGhlIHBhZ2VzIG9mIHNwZWMgbWVudGlvbmVkIGFib3Zl LCBhbmQgdG8gY29kZSBpbgo+ICsgKiBpbnRlbF9wb3B1bGF0ZV9hY3BpX2lkc19mb3JfYWxsX2Nv bm5lY3RvcnMoKSkuIFRoaXMgZGV2aWNlIGluZGV4Cj4gKyAqIHVuZm9ydHVuYXRlbHkgaXMgbm90 IGF2YWlsYWJsZSBpbiBEUk0gY29kZSwgc28gY3VycmVudGx5IGl0cyBjYWxsIGlzCj4gKyAqIG9y aWdpbmF0ZWQgZnJvbSBpOTE1IGRyaXZlci4gSWYgaW4gZnV0dXJlIHRoaXMgaXMgdXNlZnVsIGZv ciBvdGhlciBkcml2ZXJzCj4gKyAqIGFuZCB3ZSBjYW4gZmluZCBhIGdlbmVyaWMgd2F5IG9mIGdl dHRpbmcgYSBkZXZpY2UgaW5kZXgsIHdlIHNob3VsZCBtb3ZlIHRoaXMKPiArICogZnVuY3Rpb24g dG8gZHJtIGNvZGUsIG1heWJlLgo+ICsgKi8KPiArdm9pZCBpbnRlbF9jb25uZWN0b3JfbG9va3Vw X2FjcGlfbm9kZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICppbnRlbF9jb25uZWN0b3IpCgpOaXRw aWNrLCBJJ2QgZXhwZWN0IGEgImxvb2t1cCIgZnVuY3Rpb24gdG8gcmV0dXJuIHdoYXRldmVyIGl0 IGlzIGxvb2tpbmcKdXAsIG5vdCBtb2RpZnkgaXRzIGFyZ3VtZW50LgoKPiArewo+ICsJc3RydWN0 IGRybV9kZXZpY2UgKmRybV9kZXYgPSBpbnRlbF9jb25uZWN0b3ItPmJhc2UuZGV2Owo+ICsJc3Ry dWN0IGRldmljZSAqZGV2ID0gJmRybV9kZXYtPnBkZXYtPmRldjsKPiArCXN0cnVjdCBhY3BpX2Rl dmljZSAqY29ubl9kZXY7Cj4gKwl1NjQgY29ubl9hZGRyOwo+ICsKPiArCS8qCj4gKwkgKiBSZXBv cHVsYXRlIEFDUEkgSURzIGZvciBhbGwgY29ubmVjdG9ycyBpcyBuZWVkZWQgYmVjYXVzZSB0aGUg ZGlzcGxheQo+ICsJICogaW5kZXggbWF5IGhhdmUgY2hhbmdlZCBhcyBhIHJlc3VsdCBvZiBob3Rw bHVnZ2luZyBhbmQgdW5wbHVnZ2luZwo+ICsJICogY29ubmVjdG9ycwo+ICsJICovCgpJIHRoaW5r IHRoYXQgY2FuIG9ubHkgYmUgdHJ1ZSBmb3IgRFAgTVNULiBGb3IgZXZlcnl0aGluZyBlbHNlLCBJ IGRvbid0CnRoaW5rIHNvLiBBbnl3YXksIHdoeSBhcmUgd2UgZG9pbmcgaXQgaGVyZSB0aGVuLCBk ZXBlbmRpbmcgb24gd2hldGhlcgpzb21lb25lIGNhbGxzIHRoaXMgZnVuY3Rpb24gb3Igbm90PyBJ ZiBpdCBtYXR0ZXJzLCB3ZSBzaG91bGQgYmUgZG9pbmcKdGhpcyB3aGVuZXZlciB0aGVyZSdzIGEg Y2hhbmNlIHRoZXkndmUgY2hhbmdlZCwgcmlnaHQ/Cgo+ICsJaW50ZWxfcG9wdWxhdGVfYWNwaV9p ZHNfZm9yX2FsbF9jb25uZWN0b3JzKGRybV9kZXYpOwo+ICsKPiArCS8qIEJ1aWxkIHRoZSBfQURS IHRvIGxvb2sgZm9yICovCj4gKwljb25uX2FkZHIgPSBpbnRlbF9jb25uZWN0b3ItPmFjcGlfZGV2 aWNlX2lkOwo+ICsJY29ubl9hZGRyIHw9IEFDUElfREVWSUNFX0lEX1NDSEVNRTsKPiArCWNvbm5f YWRkciB8PSBBQ1BJX0JJT1NfQ0FOX0RFVEVDVDsKPiArCj4gKwlEUk1fREVWX0lORk8oZGV2LCAi TG9va2luZyBmb3IgY29ubmVjdG9yIEFDUEkgbm9kZSBhdCBfQURSPSVsbFhcbiIsCj4gKwkJICAg ICBjb25uX2FkZHIpOwo+ICsKPiArCS8qIExvb2sgdXAgdGhlIGNvbm5lY3RvciBkZXZpY2UsIHVu ZGVyIHRoZSBQQ0kgZGV2aWNlICovCj4gKwljb25uX2RldiA9IGFjcGlfZmluZF9jaGlsZF9kZXZp Y2UoQUNQSV9DT01QQU5JT04oZGV2KSwgY29ubl9hZGRyLAo+ICsJCQkJCSAgZmFsc2UpOwo+ICsJ aW50ZWxfY29ubmVjdG9yLT5hY3BpX2hhbmRsZSA9IGNvbm5fZGV2ID8gY29ubl9kZXYtPmhhbmRs ZSA6IE5VTEw7CgpXaHkgZG9uJ3Qgd2UgZG8gdGhpcyBhcyBwYXJ0IG9mCmludGVsX3BvcHVsYXRl X2FjcGlfaWRzX2Zvcl9hbGxfY29ubmVjdG9ycygpIG9yIHdoYXRldmVyIGl0J2xsIGJlCmNhbGxl ZD8KCj4gK30KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9hY3BpLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2FjcGkuaAo+IGlu ZGV4IDhmNmQ4NTBkZjZmYS4uNjFhNDM5MmZhYzRhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZGlzcGxheS9pbnRlbF9hY3BpLmgKPiBAQCAtOSwxNCArOSwxNiBAQAo+ICAjaW5jbHVkZSAi aW50ZWxfZGlzcGxheV90eXBlcy5oIgo+ICAKPiAgI2lmZGVmIENPTkZJR19BQ1BJCj4gK3ZvaWQg aW50ZWxfY29ubmVjdG9yX2xvb2t1cF9hY3BpX25vZGUoc3RydWN0IGludGVsX2Nvbm5lY3RvciAq Y29ubmVjdG9yKTsKPiAgdm9pZCBpbnRlbF9yZWdpc3Rlcl9kc21faGFuZGxlcih2b2lkKTsKPiAg dm9pZCBpbnRlbF91bnJlZ2lzdGVyX2RzbV9oYW5kbGVyKHZvaWQpOwo+ICB2b2lkIGludGVsX3Bv cHVsYXRlX2FjcGlfaWRzX2Zvcl9hbGxfY29ubmVjdG9ycyhzdHJ1Y3QgZHJtX2RldmljZSAqZHJt X2Rldik7Cj4gICNlbHNlCj4gK3N0YXRpYyBpbmxpbmUgdm9pZAo+ICtpbnRlbF9jb25uZWN0b3Jf bG9va3VwX2FjcGlfbm9kZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpIHsgcmV0 dXJuOyB9Cj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBpbnRlbF9yZWdpc3Rlcl9kc21faGFuZGxlcih2 b2lkKSB7IHJldHVybjsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQgaW50ZWxfdW5yZWdpc3Rlcl9k c21faGFuZGxlcih2b2lkKSB7IHJldHVybjsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQKPiAtc3Rh dGljIGlubGluZSB2b2lkCgpXaG9vcHMuCgo+ICBpbnRlbF9wb3B1bGF0ZV9hY3BpX2lkc19mb3Jf YWxsX2Nvbm5lY3RvcnMoc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXYpIHsgfQo+ICAjZW5kaWYg LyogQ09ORklHX0FDUEkgKi8KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2Rpc3BsYXkvaW50ZWxfZGlzcGxheV90eXBlcy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kaXNwbGF5X3R5cGVzLmgKPiBpbmRleCA0NDlhYmFlYTYxOWYuLmMyNzA2YWZj MDY5YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rp c3BsYXlfdHlwZXMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf ZGlzcGxheV90eXBlcy5oCj4gQEAgLTQwMCw2ICs0MDAsOSBAQCBzdHJ1Y3QgaW50ZWxfY29ubmVj dG9yIHsKPiAgCS8qIEFDUEkgZGV2aWNlIGlkIGZvciBBQ1BJIGFuZCBkcml2ZXIgY29vcGVyYXRp b24gKi8KPiAgCXUzMiBhY3BpX2RldmljZV9pZDsKPiAgCj4gKwkvKiBBQ1BJIGhhbmRsZSBjb3Jy ZXNwb25kaW5nIHRvIHRoaXMgY29ubmVjdG9yIGRpc3BsYXksIGlmIGZvdW5kICovCj4gKwl2b2lk ICphY3BpX2hhbmRsZTsKPiArCj4gIAkvKiBSZWFkcyBvdXQgdGhlIGN1cnJlbnQgaHcsIHJldHVy bmluZyB0cnVlIGlmIHRoZSBjb25uZWN0b3IgaXMgZW5hYmxlZAo+ICAJICogYW5kIGFjdGl2ZSAo aS5lLiBkcG1zIE9OIHN0YXRlKS4gKi8KPiAgCWJvb2wgKCpnZXRfaHdfc3RhdGUpKHN0cnVjdCBp bnRlbF9jb25uZWN0b3IgKik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHAu Ywo+IGluZGV4IGY4NjU2MTUxNzJhNS4uNGZhYzQwOGE0Mjk5IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHAuYwo+IEBAIC00NSw2ICs0NSw3IEBACj4gICNpbmNsdWRl ICJpOTE1X2RlYnVnZnMuaCIKPiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4gICNpbmNsdWRlICJp OTE1X3RyYWNlLmgiCj4gKyNpbmNsdWRlICJpbnRlbF9hY3BpLmgiCj4gICNpbmNsdWRlICJpbnRl bF9hdG9taWMuaCIKPiAgI2luY2x1ZGUgImludGVsX2F1ZGlvLmgiCj4gICNpbmNsdWRlICJpbnRl bF9jb25uZWN0b3IuaCIKPiBAQCAtNjMzMyw2ICs2MzM0LDcgQEAgaW50ZWxfZHBfYWRkX3Byb3Bl cnRpZXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgc3RydWN0IGRybV9jb25uZWN0b3IgKmNv bm5lY3QKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShjb25uZWN0b3ItPmRldik7Cj4gIAllbnVtIHBvcnQgcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGlu dGVsX2RwKS0+YmFzZS5wb3J0Owo+ICsJc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxfY29u bmVjdG9yID0gdG9faW50ZWxfY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gIAo+ICAJaWYgKCFJU19H NFgoZGV2X3ByaXYpICYmIHBvcnQgIT0gUE9SVF9BKQo+ICAJCWludGVsX2F0dGFjaF9mb3JjZV9h dWRpb19wcm9wZXJ0eShjb25uZWN0b3IpOwo+IEBAIC02MzU0LDYgKzYzNTYsOCBAQCBpbnRlbF9k cF9hZGRfcHJvcGVydGllcyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBzdHJ1Y3QgZHJtX2Nv bm5lY3RvciAqY29ubmVjdAo+ICAKPiAgCQljb25uZWN0b3ItPnN0YXRlLT5zY2FsaW5nX21vZGUg PSBEUk1fTU9ERV9TQ0FMRV9BU1BFQ1Q7Cj4gIAo+ICsJCS8qIExvb2t1cCB0aGUgQUNQSSBub2Rl IGNvcnJlc3BvbmRpbmcgdG8gdGhlIGNvbm5lY3RvciAqLwo+ICsJCWludGVsX2Nvbm5lY3Rvcl9s b29rdXBfYWNwaV9ub2RlKGludGVsX2Nvbm5lY3Rvcik7CgpUaGlzIGlzIGFuIG9kZCBwbGFjZSB0 byBkbyB0aGlzLCBpc24ndCBpdD8gSXQncyBvbmx5IGNhbGxlZCBvbmNlLCBidXQKeW91IHNheSB0 aGUgYWNwaSBpZCBtYXkgY2hhbmdlIGF0IGhvdHBsdWcuCgpCUiwKSmFuaS4KCj4gIAl9Cj4gIH0K Ci0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D37A3C432C0 for ; Wed, 20 Nov 2019 14:51:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAD13206DA for ; Wed, 20 Nov 2019 14:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731837AbfKTOvL (ORCPT ); Wed, 20 Nov 2019 09:51:11 -0500 Received: from mga01.intel.com ([192.55.52.88]:19629 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728049AbfKTOvL (ORCPT ); Wed, 20 Nov 2019 09:51:11 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 06:50:57 -0800 X-IronPort-AV: E=Sophos;i="5.69,222,1571727600"; d="scan'208";a="200739584" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 06:50:49 -0800 From: Jani Nikula To: Rajat Jain , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , Joonas Lahtinen , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= , Chris Wilson , Imre Deak , =?utf-8?Q?Jos=C3=A9?= Roberto de Souza , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, gregkh@linuxfoundation.org, mathewk@google.com, Daniel Thompson , Jonathan Corbet , Pavel Machek , seanpaul@google.com, Duncan Laurie , jsbarnes@google.com, Thierry Reding Cc: Rajat Jain , rajatxjain@gmail.com Subject: Re: [PATCH v2 2/3] drm/i915: Lookup and attach ACPI device node for connectors In-Reply-To: <20191104194147.185642-2-rajatja@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191023001206.15741-1-rajatja@google.com> <20191104194147.185642-1-rajatja@google.com> <20191104194147.185642-2-rajatja@google.com> Date: Wed, 20 Nov 2019 16:50:46 +0200 Message-ID: <87tv6ywqih.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Nov 2019, Rajat Jain wrote: > Lookup and attach ACPI nodes for intel connectors. The lookup is done > in compliance with ACPI Spec 6.3 > https://uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf > (Ref: Pages 1119 - 1123). > > This can be useful for any connector specific platform properties. (This > will be used for privacy screen in next patch). > > Signed-off-by: Rajat Jain > Change-Id: I798e70714a4402554c8cd2a8e58268353f75814f > --- > v2: formed by splitting the original patch into ACPI lookup, and privacy > screen property. Also move it into i915 now that I found existing code > in i915 that can be re-used. > > drivers/gpu/drm/i915/display/intel_acpi.c | 50 +++++++++++++++++++ > drivers/gpu/drm/i915/display/intel_acpi.h | 4 +- > .../drm/i915/display/intel_display_types.h | 3 ++ > drivers/gpu/drm/i915/display/intel_dp.c | 4 ++ > 4 files changed, 60 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c > index 748d9b3125dd..0c10516430b1 100644 > --- a/drivers/gpu/drm/i915/display/intel_acpi.c > +++ b/drivers/gpu/drm/i915/display/intel_acpi.c > @@ -243,3 +243,53 @@ void intel_populate_acpi_ids_for_all_connectors(struct drm_device *drm_dev) > } > drm_connector_list_iter_end(&conn_iter); > } > + > +/* > + * Ref: ACPI Spec 6.3 > + * https://uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf > + * Pages 1119 - 1123 describe, what I believe, a standard way of > + * identifying / addressing "display panels" in the ACPI. It provides > + * a way for the ACPI to define devices for the display panels attached > + * to the system. It thus provides a way for the BIOS to export any panel > + * specific properties to the system via ACPI (like device trees). > + * > + * The following functions looks up the ACPI node for a connector and returns > + * it. Technically it is independent from the i915 code, and > + * ideally may be called for all connectors. It is generally a good idea to > + * be able to attach an ACPI node to describe anything if needed. (This can > + * help in future for other panel specific features maybe). However, it > + * needs an acpi device ID which is build using an index within a particular > + * type of port (Ref to the pages of spec mentioned above, and to code in > + * intel_populate_acpi_ids_for_all_connectors()). This device index > + * unfortunately is not available in DRM code, so currently its call is > + * originated from i915 driver. If in future this is useful for other drivers > + * and we can find a generic way of getting a device index, we should move this > + * function to drm code, maybe. > + */ > +void intel_connector_lookup_acpi_node(struct intel_connector *intel_connector) Nitpick, I'd expect a "lookup" function to return whatever it is looking up, not modify its argument. > +{ > + struct drm_device *drm_dev = intel_connector->base.dev; > + struct device *dev = &drm_dev->pdev->dev; > + struct acpi_device *conn_dev; > + u64 conn_addr; > + > + /* > + * Repopulate ACPI IDs for all connectors is needed because the display > + * index may have changed as a result of hotplugging and unplugging > + * connectors > + */ I think that can only be true for DP MST. For everything else, I don't think so. Anyway, why are we doing it here then, depending on whether someone calls this function or not? If it matters, we should be doing this whenever there's a chance they've changed, right? > + intel_populate_acpi_ids_for_all_connectors(drm_dev); > + > + /* Build the _ADR to look for */ > + conn_addr = intel_connector->acpi_device_id; > + conn_addr |= ACPI_DEVICE_ID_SCHEME; > + conn_addr |= ACPI_BIOS_CAN_DETECT; > + > + DRM_DEV_INFO(dev, "Looking for connector ACPI node at _ADR=%llX\n", > + conn_addr); > + > + /* Look up the connector device, under the PCI device */ > + conn_dev = acpi_find_child_device(ACPI_COMPANION(dev), conn_addr, > + false); > + intel_connector->acpi_handle = conn_dev ? conn_dev->handle : NULL; Why don't we do this as part of intel_populate_acpi_ids_for_all_connectors() or whatever it'll be called? > +} > diff --git a/drivers/gpu/drm/i915/display/intel_acpi.h b/drivers/gpu/drm/i915/display/intel_acpi.h > index 8f6d850df6fa..61a4392fac4a 100644 > --- a/drivers/gpu/drm/i915/display/intel_acpi.h > +++ b/drivers/gpu/drm/i915/display/intel_acpi.h > @@ -9,14 +9,16 @@ > #include "intel_display_types.h" > > #ifdef CONFIG_ACPI > +void intel_connector_lookup_acpi_node(struct intel_connector *connector); > void intel_register_dsm_handler(void); > void intel_unregister_dsm_handler(void); > void intel_populate_acpi_ids_for_all_connectors(struct drm_device *drm_dev); > #else > +static inline void > +intel_connector_lookup_acpi_node(struct intel_connector *connector) { return; } > static inline void intel_register_dsm_handler(void) { return; } > static inline void intel_unregister_dsm_handler(void) { return; } > static inline void > -static inline void Whoops. > intel_populate_acpi_ids_for_all_connectors(struct drm_device *drm_dev) { } > #endif /* CONFIG_ACPI */ > > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > index 449abaea619f..c2706afc069b 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -400,6 +400,9 @@ struct intel_connector { > /* ACPI device id for ACPI and driver cooperation */ > u32 acpi_device_id; > > + /* ACPI handle corresponding to this connector display, if found */ > + void *acpi_handle; > + > /* Reads out the current hw, returning true if the connector is enabled > * and active (i.e. dpms ON state). */ > bool (*get_hw_state)(struct intel_connector *); > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index f865615172a5..4fac408a4299 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -45,6 +45,7 @@ > #include "i915_debugfs.h" > #include "i915_drv.h" > #include "i915_trace.h" > +#include "intel_acpi.h" > #include "intel_atomic.h" > #include "intel_audio.h" > #include "intel_connector.h" > @@ -6333,6 +6334,7 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connect > { > struct drm_i915_private *dev_priv = to_i915(connector->dev); > enum port port = dp_to_dig_port(intel_dp)->base.port; > + struct intel_connector *intel_connector = to_intel_connector(connector); > > if (!IS_G4X(dev_priv) && port != PORT_A) > intel_attach_force_audio_property(connector); > @@ -6354,6 +6356,8 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connect > > connector->state->scaling_mode = DRM_MODE_SCALE_ASPECT; > > + /* Lookup the ACPI node corresponding to the connector */ > + intel_connector_lookup_acpi_node(intel_connector); This is an odd place to do this, isn't it? It's only called once, but you say the acpi id may change at hotplug. BR, Jani. > } > } -- Jani Nikula, Intel Open Source Graphics Center