Re: [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC

From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	tbm@cyrius.com, linux-arm-kernel@lists.infradead.org,
	Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC
Date: Tue, 27 Aug 2019 15:47:54 +0200	[thread overview]
Message-ID: <87tva2zpmd.fsf@FE-laptop> (raw)
In-Reply-To: <20190731223233.GA15900@taurus.defre.kleine-koenig.org>

Hi Uwe Kleine-König,

> The internal RTC doesn't work, loading the driver only yields
>
> 	rtc-mv f1010300.rtc: internal RTC not ticking
>
> . So disable it.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>

Applied on mvebu/dt with both acked-by

Thanks,

Gregory

> ---
> Hello,
>
> This patch is (one) result of a discussion on the rtc list. v1 was sent
> there only. This v2 is just a resend to the mvebu maintainers.
>
> Alexandre Belloni said to v1: Seems good to me then.
>
> This sounds a bit like an ack, but I didn't add it as it was not
> explicit.
>
> Best regards
> Uwe
>
>  arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> index a88eb22070a1..994cabcf4b51 100644
> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> @@ -104,3 +104,11 @@
>  &pcie0 {
>  	status = "okay";
>  };
> +
> +&rtc {
> +	/*
> +	 * There is a s35390a available on the i2c bus, the internal rtc isn't
> +	 * working (probably no crystal assembled).
> +	 */
> +	status = "disabled";
> +};
> -- 
> 2.20.1

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel