From: Nathan Lynch <nathanl@linux.ibm.com>
To: Aravinda Prasad <aravinda@linux.vnet.ibm.com>
Cc: naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] powerpc/pseries: Fix maximum memory value
Date: Fri, 28 Jun 2019 12:27:20 -0500 [thread overview]
Message-ID: <87tvc9sjrb.fsf@linux.ibm.com> (raw)
In-Reply-To: <156170480663.26214.11212383510892156924.stgit@aravinda>
Aravinda Prasad <aravinda@linux.vnet.ibm.com> writes:
> Calculating the maximum memory based on the number of lmbs
> and lmb size does not account for the RMA region. Hence
> use memory_hotplug_max(), which already accounts for the
> RMA region, to fetch the maximum memory value. Thanks to
> Nathan Lynch for suggesting the memory_hotplug_max()
> function.
Well, I hope I haven't led you astray... will it give you the desired
result on a kernel configured without memory hotplug support, booted in
an LPAR with some huge pages configured?
If so, then
Acked-by: Nathan Lynch <nathanl@linux.ibm.com>
It would likely help with review and future maintenance if the semantics
and intended use of the MaxMem field are made a little more
explicit. For example, is it supposed to include persistent memory?
Perhaps a follow-up patch could address this. Or maybe I'm overthinking
it.
next prev parent reply other threads:[~2019-06-28 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 6:53 [PATCH v2] powerpc/pseries: Fix maximum memory value Aravinda Prasad
2019-06-28 17:27 ` Nathan Lynch [this message]
2019-06-28 17:38 ` Naveen N. Rao
2019-06-28 18:19 ` Nathan Lynch
2019-07-04 11:13 ` Michael Ellerman
2019-07-04 11:30 ` Aravinda Prasad
2019-07-01 4:03 ` Aravinda Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvc9sjrb.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=aravinda@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.