From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Pingfan Liu <kernelfans@gmail.com>, linux-mm@kvack.org
Cc: Pingfan Liu <kernelfans@gmail.com>,
Ira Weiny <ira.weiny@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <willy@infradead.org>,
John Hubbard <jhubbard@nvidia.com>,
Keith Busch <keith.busch@intel.com>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast()
Date: Tue, 11 Jun 2019 21:45:31 +0530 [thread overview]
Message-ID: <87tvcwhzdo.fsf@linux.ibm.com> (raw)
In-Reply-To: <1559725820-26138-1-git-send-email-kernelfans@gmail.com>
Pingfan Liu <kernelfans@gmail.com> writes:
> As for FOLL_LONGTERM, it is checked in the slow path
> __gup_longterm_unlocked(). But it is not checked in the fast path, which
> means a possible leak of CMA page to longterm pinned requirement through
> this crack.
Shouldn't we disallow FOLL_LONGTERM with get_user_pages fastpath? W.r.t
dax check we need vma to ensure whether a long term pin is allowed or not.
If FOLL_LONGTERM is specified we should fallback to slow path.
-aneesh
next prev parent reply other threads:[~2019-06-11 16:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 9:10 [PATCHv3 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast() Pingfan Liu
2019-06-05 9:10 ` [PATCHv3 2/2] mm/gup: rename nr as nr_pinned " Pingfan Liu
2019-06-05 21:49 ` [PATCHv3 1/2] mm/gup: fix omission of check on FOLL_LONGTERM " Andrew Morton
2019-06-06 2:19 ` Pingfan Liu
2019-06-06 21:17 ` John Hubbard
2019-06-07 6:10 ` Pingfan Liu
2019-06-11 12:29 ` Pingfan Liu
2019-06-11 13:52 ` Christoph Hellwig
2019-06-11 19:49 ` John Hubbard
2019-06-11 16:47 ` Ira Weiny
2019-06-12 14:10 ` Pingfan Liu
2019-06-11 16:15 ` Aneesh Kumar K.V [this message]
2019-06-11 16:29 ` Weiny, Ira
2019-06-12 13:54 ` Pingfan Liu
2019-06-12 23:50 ` Ira Weiny
2019-06-13 10:48 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvcwhzdo.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jhubbard@nvidia.com \
--cc=keith.busch@intel.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.