From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 2/5] reset: Add acquired flag to of_reset_control_array_get() Date: Wed, 20 Mar 2019 08:51:34 +0200 Message-ID: <87tvfyujgp.fsf@linux.intel.com> References: <20190221152557.8534-1-thierry.reding@gmail.com> <20190221152557.8534-2-thierry.reding@gmail.com> <1553013476.6482.6.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: In-Reply-To: <1553013476.6482.6.camel@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Philipp Zabel , Thierry Reding Cc: Jonathan Hunter , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org List-Id: linux-tegra@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Philipp Zabel writes: > On Thu, 2019-02-21 at 16:25 +0100, Thierry Reding wrote: >> From: Thierry Reding >>=20 >> In order to be able to request an array of reset controls in acquired or >> released mode, add the acquired flag to of_reset_control_array_get() and >> pass the flag to subsequent calls of __of_reset_control_get(). >>=20 >> Signed-off-by: Thierry Reding >> --- >> drivers/reset/core.c | 9 ++++++--- >> drivers/usb/dwc3/dwc3-of-simple.c | 3 ++- >> include/linux/reset.h | 14 ++++++++------ >> 3 files changed, 16 insertions(+), 10 deletions(-) >>=20 >> diff --git a/drivers/reset/core.c b/drivers/reset/core.c >> index 1e8a42b16f23..f94da91c22af 100644 >> --- a/drivers/reset/core.c >> +++ b/drivers/reset/core.c >> @@ -830,12 +830,15 @@ static int of_reset_control_get_count(struct devic= e_node *node) >> * @np: device node for the device that requests the reset controls arr= ay >> * @shared: whether reset controls are shared or not >> * @optional: whether it is optional to get the reset controls >> + * @acquired: only one reset control may be acquired for a given contro= ller >> + * and ID >> * >> * Returns pointer to allocated reset_control_array on success or >> * error on failure >> */ >> struct reset_control * >> -of_reset_control_array_get(struct device_node *np, bool shared, bool op= tional) >> +of_reset_control_array_get(struct device_node *np, bool shared, bool op= tional, >> + bool acquired) >> { >> struct reset_control_array *resets; >> struct reset_control *rstc; >> @@ -851,7 +854,7 @@ of_reset_control_array_get(struct device_node *np, b= ool shared, bool optional) >>=20=20 >> for (i =3D 0; i < num; i++) { >> rstc =3D __of_reset_control_get(np, NULL, i, shared, optional, >> - true); >> + acquired); >> if (IS_ERR(rstc)) >> goto err_rst; >> resets->rstc[i] =3D rstc; >> @@ -898,7 +901,7 @@ devm_reset_control_array_get(struct device *dev, boo= l shared, bool optional) >> if (!devres) >> return ERR_PTR(-ENOMEM); >>=20=20 >> - rstc =3D of_reset_control_array_get(dev->of_node, shared, optional); >> + rstc =3D of_reset_control_array_get(dev->of_node, shared, optional, tr= ue); >> if (IS_ERR(rstc)) { >> devres_free(devres); >> return rstc; >> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-o= f-simple.c >> index 4c2771c5e727..67ce2037472d 100644 >> --- a/drivers/usb/dwc3/dwc3-of-simple.c >> +++ b/drivers/usb/dwc3/dwc3-of-simple.c >> @@ -107,7 +107,8 @@ static int dwc3_of_simple_probe(struct platform_devi= ce *pdev) >> simple->pulse_resets =3D true; >> } >>=20=20 >> - simple->resets =3D of_reset_control_array_get(np, shared_resets, true); >> + simple->resets =3D of_reset_control_array_get(np, shared_resets, true, >> + true); > > Felipe, could I get your acked-by to merge this through the reset tree? > > dwc3-of-simple is a bit of a special case because it calls > of_reset_control_array_get directly instead of through the > of_reset_control_array_get_shared/exclusive wrappers. Sure thing: Acked-by: Felipe Balbi =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlyR4vYACgkQzL64meEa mQZ9Kw/+I1IrdMF3FmYc9NjB4bNdvHKB258C5wIFM4ypdDdQCA0KO07hw0qnJlwM tVZ+n6fWSkH1bjRFULVFmejpflOWav8PirMepFIt5Arn0CJSSOwW7NLyfjy/fFT9 sZy1vlDPnim/EbVCVhc5VJiHNeofs8o1EXAmxJAPAot2PEBbsbcfIDfdMXxMgskm 9To/jMd1OW5p+EugOicpIPz3lzZdPHu9MzmVXc294oS7/To2xO/kCnvDckfG7sk/ oyylqx79LolmI4f4j0XkX2Poz7NTXYjbM88qpoDWX1phntVd6WGi4Sjhe2Vgu7e9 6oabn/3Ws/+lWZM38hloiWxowS2o0ZwxLnGL7R22HUlmlatahz5lOUrNqLvFDvTI Du0B4obhZTfkG9AS5sq/hFIGiIqyFCs1D4OBnBuooF/tf73K48p1Mv1YryPIRIfu 5vZCNNEyMB2iRIOfSow5etSPZgijEXH50AgQZg3aDViLBZQDKqWFFYjc0RioxaC1 lzAK7QmlIMdlrsP3fl65jj/WPrg6el1/3oM4lyThDVOr3Tdllk3nUiyTRPwew87d zdZPgQKXV93xvJ3SbwXJ78wQI3ZwrsXxaxbijI/g3BDbd25ivWTRffx7dYet3LoK qVo5EsdILA5nntmGqfNM6umJwqB4kLyIA31p5bYtI+fDXomDDCA= =gvkl -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/5] reset: Add acquired flag to of_reset_control_array_get() From: Felipe Balbi Message-Id: <87tvfyujgp.fsf@linux.intel.com> Date: Wed, 20 Mar 2019 08:51:34 +0200 To: Philipp Zabel , Thierry Reding Cc: Jonathan Hunter , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org List-ID: UGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4gd3JpdGVzOgoKPiBPbiBUaHUs IDIwMTktMDItMjEgYXQgMTY6MjUgKzAxMDAsIFRoaWVycnkgUmVkaW5nIHdyb3RlOgo+PiBGcm9t OiBUaGllcnJ5IFJlZGluZyA8dHJlZGluZ0BudmlkaWEuY29tPgo+PiAKPj4gSW4gb3JkZXIgdG8g YmUgYWJsZSB0byByZXF1ZXN0IGFuIGFycmF5IG9mIHJlc2V0IGNvbnRyb2xzIGluIGFjcXVpcmVk IG9yCj4+IHJlbGVhc2VkIG1vZGUsIGFkZCB0aGUgYWNxdWlyZWQgZmxhZyB0byBvZl9yZXNldF9j b250cm9sX2FycmF5X2dldCgpIGFuZAo+PiBwYXNzIHRoZSBmbGFnIHRvIHN1YnNlcXVlbnQgY2Fs bHMgb2YgX19vZl9yZXNldF9jb250cm9sX2dldCgpLgo+PiAKPj4gU2lnbmVkLW9mZi1ieTogVGhp ZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL3Jlc2V0 L2NvcmUuYyAgICAgICAgICAgICAgfCAgOSArKysrKystLS0KPj4gIGRyaXZlcnMvdXNiL2R3YzMv ZHdjMy1vZi1zaW1wbGUuYyB8ICAzICsrLQo+PiAgaW5jbHVkZS9saW51eC9yZXNldC5oICAgICAg ICAgICAgIHwgMTQgKysrKysrKystLS0tLS0KPj4gIDMgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0 aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9yZXNl dC9jb3JlLmMgYi9kcml2ZXJzL3Jlc2V0L2NvcmUuYwo+PiBpbmRleCAxZThhNDJiMTZmMjMuLmY5 NGRhOTFjMjJhZiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9yZXNldC9jb3JlLmMKPj4gKysrIGIv ZHJpdmVycy9yZXNldC9jb3JlLmMKPj4gQEAgLTgzMCwxMiArODMwLDE1IEBAIHN0YXRpYyBpbnQg b2ZfcmVzZXRfY29udHJvbF9nZXRfY291bnQoc3RydWN0IGRldmljZV9ub2RlICpub2RlKQo+PiAg ICogQG5wOiBkZXZpY2Ugbm9kZSBmb3IgdGhlIGRldmljZSB0aGF0IHJlcXVlc3RzIHRoZSByZXNl dCBjb250cm9scyBhcnJheQo+PiAgICogQHNoYXJlZDogd2hldGhlciByZXNldCBjb250cm9scyBh cmUgc2hhcmVkIG9yIG5vdAo+PiAgICogQG9wdGlvbmFsOiB3aGV0aGVyIGl0IGlzIG9wdGlvbmFs IHRvIGdldCB0aGUgcmVzZXQgY29udHJvbHMKPj4gKyAqIEBhY3F1aXJlZDogb25seSBvbmUgcmVz ZXQgY29udHJvbCBtYXkgYmUgYWNxdWlyZWQgZm9yIGEgZ2l2ZW4gY29udHJvbGxlcgo+PiArICog ICAgICAgICAgICBhbmQgSUQKPj4gICAqCj4+ICAgKiBSZXR1cm5zIHBvaW50ZXIgdG8gYWxsb2Nh dGVkIHJlc2V0X2NvbnRyb2xfYXJyYXkgb24gc3VjY2VzcyBvcgo+PiAgICogZXJyb3Igb24gZmFp bHVyZQo+PiAgICovCj4+ICBzdHJ1Y3QgcmVzZXRfY29udHJvbCAqCj4+IC1vZl9yZXNldF9jb250 cm9sX2FycmF5X2dldChzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wLCBib29sIHNoYXJlZCwgYm9vbCBv cHRpb25hbCkKPj4gK29mX3Jlc2V0X2NvbnRyb2xfYXJyYXlfZ2V0KHN0cnVjdCBkZXZpY2Vfbm9k ZSAqbnAsIGJvb2wgc2hhcmVkLCBib29sIG9wdGlvbmFsLAo+PiArCQkJICAgYm9vbCBhY3F1aXJl ZCkKPj4gIHsKPj4gIAlzdHJ1Y3QgcmVzZXRfY29udHJvbF9hcnJheSAqcmVzZXRzOwo+PiAgCXN0 cnVjdCByZXNldF9jb250cm9sICpyc3RjOwo+PiBAQCAtODUxLDcgKzg1NCw3IEBAIG9mX3Jlc2V0 X2NvbnRyb2xfYXJyYXlfZ2V0KHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAsIGJvb2wgc2hhcmVkLCBi b29sIG9wdGlvbmFsKQo+PiAgCj4+ICAJZm9yIChpID0gMDsgaSA8IG51bTsgaSsrKSB7Cj4+ICAJ CXJzdGMgPSBfX29mX3Jlc2V0X2NvbnRyb2xfZ2V0KG5wLCBOVUxMLCBpLCBzaGFyZWQsIG9wdGlv bmFsLAo+PiAtCQkJCQkgICAgICB0cnVlKTsKPj4gKwkJCQkJICAgICAgYWNxdWlyZWQpOwo+PiAg CQlpZiAoSVNfRVJSKHJzdGMpKQo+PiAgCQkJZ290byBlcnJfcnN0Owo+PiAgCQlyZXNldHMtPnJz dGNbaV0gPSByc3RjOwo+PiBAQCAtODk4LDcgKzkwMSw3IEBAIGRldm1fcmVzZXRfY29udHJvbF9h cnJheV9nZXQoc3RydWN0IGRldmljZSAqZGV2LCBib29sIHNoYXJlZCwgYm9vbCBvcHRpb25hbCkK Pj4gIAlpZiAoIWRldnJlcykKPj4gIAkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4+ICAKPj4g LQlyc3RjID0gb2ZfcmVzZXRfY29udHJvbF9hcnJheV9nZXQoZGV2LT5vZl9ub2RlLCBzaGFyZWQs IG9wdGlvbmFsKTsKPj4gKwlyc3RjID0gb2ZfcmVzZXRfY29udHJvbF9hcnJheV9nZXQoZGV2LT5v Zl9ub2RlLCBzaGFyZWQsIG9wdGlvbmFsLCB0cnVlKTsKPj4gIAlpZiAoSVNfRVJSKHJzdGMpKSB7 Cj4+ICAJCWRldnJlc19mcmVlKGRldnJlcyk7Cj4+ICAJCXJldHVybiByc3RjOwo+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy91c2IvZHdjMy9kd2MzLW9mLXNpbXBsZS5jIGIvZHJpdmVycy91c2IvZHdj My9kd2MzLW9mLXNpbXBsZS5jCj4+IGluZGV4IDRjMjc3MWM1ZTcyNy4uNjdjZTIwMzc0NzJkIDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL3VzYi9kd2MzL2R3YzMtb2Ytc2ltcGxlLmMKPj4gKysrIGIv ZHJpdmVycy91c2IvZHdjMy9kd2MzLW9mLXNpbXBsZS5jCj4+IEBAIC0xMDcsNyArMTA3LDggQEAg c3RhdGljIGludCBkd2MzX29mX3NpbXBsZV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpw ZGV2KQo+PiAgCQlzaW1wbGUtPnB1bHNlX3Jlc2V0cyA9IHRydWU7Cj4+ICAJfQo+PiAgCj4+IC0J c2ltcGxlLT5yZXNldHMgPSBvZl9yZXNldF9jb250cm9sX2FycmF5X2dldChucCwgc2hhcmVkX3Jl c2V0cywgdHJ1ZSk7Cj4+ICsJc2ltcGxlLT5yZXNldHMgPSBvZl9yZXNldF9jb250cm9sX2FycmF5 X2dldChucCwgc2hhcmVkX3Jlc2V0cywgdHJ1ZSwKPj4gKwkJCQkJCSAgICB0cnVlKTsKPgo+IEZl bGlwZSwgY291bGQgSSBnZXQgeW91ciBhY2tlZC1ieSB0byBtZXJnZSB0aGlzIHRocm91Z2ggdGhl IHJlc2V0IHRyZWU/Cj4KPiBkd2MzLW9mLXNpbXBsZSBpcyBhIGJpdCBvZiBhIHNwZWNpYWwgY2Fz ZSBiZWNhdXNlIGl0IGNhbGxzCj4gb2ZfcmVzZXRfY29udHJvbF9hcnJheV9nZXQgZGlyZWN0bHkg aW5zdGVhZCBvZiB0aHJvdWdoIHRoZQo+IG9mX3Jlc2V0X2NvbnRyb2xfYXJyYXlfZ2V0X3NoYXJl ZC9leGNsdXNpdmUgd3JhcHBlcnMuCgpTdXJlIHRoaW5nOgoKQWNrZWQtYnk6IEZlbGlwZSBCYWxi aSA8ZmVsaXBlLmJhbGJpQGxpbnV4LmludGVsLmNvbT4K