From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:40883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1P0A-00083g-UL for qemu-devel@nongnu.org; Wed, 06 Mar 2019 00:21:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1P09-0001AL-T4 for qemu-devel@nongnu.org; Wed, 06 Mar 2019 00:21:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48126) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1P09-0001A7-KU for qemu-devel@nongnu.org; Wed, 06 Mar 2019 00:21:57 -0500 From: Markus Armbruster References: <20190305181602.9051-1-dgilbert@redhat.com> <20190305181602.9051-11-dgilbert@redhat.com> <84195982-1d8f-0bae-5136-6443a1f63c2a@redhat.com> Date: Wed, 06 Mar 2019 06:21:51 +0100 In-Reply-To: <84195982-1d8f-0bae-5136-6443a1f63c2a@redhat.com> (Eric Blake's message of "Tue, 5 Mar 2019 12:47:50 -0600") Message-ID: <87tvgg1ssw.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PULL 10/21] migration: Create socket-address parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org, quintela@redhat.com, peterx@redhat.com, marcel.apfelbaum@gmail.com, wei.w.wang@intel.com, yury-kotov@yandex-team.ru, chen.zhang@intel.com Eric Blake writes: > On 3/5/19 12:15 PM, Dr. David Alan Gilbert (git) wrote: >> From: Juan Quintela >> >> It will be used to store the uri parameters. We want this only for >> tcp, so we don't set it for other uris. We need it to know what port >> is migration running. >> >> Reviewed-by: Dr. David Alan Gilbert >> Signed-off-by: Juan Quintela >> >> -- >> > > This was not the usual '---' divider, and hence: > >> This used to be uri parameter, but it has so many troubles to >> reproduce that it don't just make sense. >> >> This used to be a port parameter. I was asked to move to >> SocketAddress, done. >> I also merged the setting of the migration tcp port in this one >> because now I need to free the address, and this makes it easier. >> This used to be x-socket-address with a single direction, now it is a >> list of addresses. >> Move SocketAddress_to_str here. I used to try to generalize the one >> in chardev/char-socket.c, but it is not worth it. >> >> Free string (eric) >> Handle VSOCK address nicely (not that migration can use them yet). >> Remove useless breaks (dave) >> rename socket_address to socket_address_list to avoid confusion >> Update to 4.0 (eric) >> Put a comment indicating that there is a problem on the qapi >> generator (markus). > > ...all this got included, even if it was perhaps not intended. > >> Message-Id: <20190227105128.1655-3-quintela@redhat.com> >> >> Signed-off-by: Dr. David Alan Gilbert > > At any rate, it certainly looks odd to split *-by: tags by so much text. > >> +++ b/qapi/sockets.json >> @@ -152,3 +152,21 @@ >> 'unix': 'UnixSocketAddress', >> 'vsock': 'VsockSocketAddress', >> 'fd': 'String' } } >> + >> +## >> +# @DummyStruct: >> +# >> +# Both block-core and migration needs SocketAddressList >> +# I am open to comments about how to share it >> +# >> +# @dummy-list: A dummy list >> +# >> +# FIXME: This shouldn't be needed, but this struct has two users, and >> +# current qapi generator generates it on the 1st place that uses it, >> +# so the second user don't see it. Putting it here it is seen in both >> +# sides. > > If Markus' pull request lands first, we don't need this. > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg01185.html It did: merge commit a3e3b0a7bd5. Please drop this hunk, either in a respin or in a follow-up patch. A respin would give you a chance to clean up the commit message.