From: Felipe Balbi <balbi@kernel.org>
To: Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: John Youn <john.youn@synopsys.com>
Subject: usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing
Date: Mon, 14 Jan 2019 10:14:46 +0200 [thread overview]
Message-ID: <87tvibmz9l.fsf@linux.intel.com> (raw)
Hi,
Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes:
> Hi Greg, Filipe,
>
> On 12/12/2018 4:44 PM, Minas Harutyunyan wrote:
>> To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register
>> require to write 1. This bit is implemented as "Write to clear".
>>
>> Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert
>> interrupt")
>>
>> Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
>> ---
>> drivers/usb/dwc2/gadget.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
>> index 68ad75a7460d..55ef3cc2701b 100644
>> --- a/drivers/usb/dwc2/gadget.c
>> +++ b/drivers/usb/dwc2/gadget.c
>> @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
>>
>> if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
>> dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
>> - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
>> + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
>> dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG);
>> }
>> }
>>
>
> Sorry for last minute fix of this stupid bug.
> Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert
> interrupt handler."
And where is that?
next reply other threads:[~2019-01-14 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 8:14 Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-14 8:57 usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing Felipe Balbi
2019-01-14 8:43 Minas Harutyunyan
2018-12-12 12:49 Minas Harutyunyan
2018-12-12 12:44 Minas Harutyunyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvibmz9l.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.youn@synopsys.com \
--cc=linux-usb@vger.kernel.org \
--cc=minas.harutyunyan@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.