From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH v4 1/2] drm: Add drm_any_plane_has_format()
Date: Mon, 29 Oct 2018 16:00:04 -0700
Message-ID: <87tvl4s6iz.fsf@anholt.net>
References: <20181029183453.28541-1-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1710507324=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <20181029183453.28541-1-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
List-Id: dri-devel@lists.freedesktop.org

--===============1710507324==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ville Syrjala <ville.syrjala@linux.intel.com> writes:

> From: Ville Syrj=C3=A4l=C3=A4 <ville.syrjala@linux.intel.com>
>
> Add a function to check whether there is at least one plane that
> supports a specific format and modifier combination. Drivers can
> use this to reject unsupported formats/modifiers in .fb_create().
>
> v2: Accept anyformat if the driver doesn't do planes (Eric)
>     s/planes_have_format/any_plane_has_format/ (Eric)
>     Check the modifier as well since we already have a function
>     that does both
> v3: Don't do the check in the core since we may not know the
>     modifier yet, instead export the function and let drivers
>     call it themselves
>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: Ville Syrj=C3=A4l=C3=A4 <ville.syrjala@linux.intel.com>
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

I don't particularly see the point in having FB creation duplicate the
validation that atomic check will eventually do, and it means that FB
creation cost scales with plane count, but if i915's going to do this,
it seems reasonable for them.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlvXkPQACgkQtdYpNtH8
nugUZw/+OkRfdP5xJuTM3YNblnr02SO0EcZUPUWXk/phPyZmkQkSMzMoAEHrKOuB
9tH6lqKjjaQ6hyYL68YdeLu9hNEOebJxEx0PTZmz25GcMFidT3CWJP13ZkKiqyp8
o0eaiiRt1jbkz6ui8FkBdMR5qd6IIXIUWayemHCUVzUkcZVu6d8IBoeY0liJiINA
QHjV8M9sNhIWpCi4Bcak8Bxexcxk71hd+4DxyE/STq2t1zkt0sMzgI9JUtd26xYm
bDiJS1NWbk0m+064aQr1o5c/SBI5zyjWK2i/xzILc4U46L7W59qzFhndvGCmp2qS
e8lwrhZoQ5aOQ31Tt6/MYUoNOJf/96tAKQuSSISMOWyzMBqjuhprwiLuF7bTj3e1
CykBW3PTAczBj7bjKuGi+wHl4Gq0d3pmpZGnb3Dz2UNw8oX1x1RpgfV5Gou1+7g6
ahEGMTM9wGMPg4xqd5zW5lX0/YviRMyfgdQZxzzCWkPHl83caN6WLcqTTn2w2naJ
QM5uPTNE6kZCy/Nm4noxH5lMKpdLXARrtVBivLt/UkZDyCwhPZUI1MVjtFWDpfSw
upU7rSxMlANZOVmS4zzgiW5uYcj4p5lxhZgfvzVsIWBsYpWpJrPWIzjsxKmNjY8M
Uk7DGPCdQRdu5DHJaAUX89u2AOgjQpixtLso+AZgiv8MA08gjOU=
=+JW+
-----END PGP SIGNATURE-----
--=-=-=--

--===============1710507324==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==

--===============1710507324==--