All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, jonathan.cameron@huawei.com,
	pierre-moana.levesque@parrot.com
Subject: Re: [PATCH v2 2/2] iio: light: isl29501: Add support for the ISL29501 ToF sensor.
Date: Thu, 28 Jun 2018 15:47:42 +0200	[thread overview]
Message-ID: <87tvpnt43l.fsf@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1806272103130.5231@vps.pmeerw.net>


Hi Peter,

Thanks for your comments.

>
> there is no call to register_read() which is unlocked, maybe move the 
> locking into the function?

Sure, I will lock/unlock mutexes in register_read and register_write
functions. 

>> +		.channel = ISL29501_MAGNITUDE_CHANNEL,
>
> .channel not needed?

I use this channel field to distinguish between channels of the same
type in read_raw and write_raw functions so I'd rather keep it, unless
there is a better way?

> 3.14 is a poor approximation :)
>
>> +		*val2 = 6553600;

Indeed :)

I'll use IIO_VAL_INT_PLUS_NANO to express this with the best
possible precision.

I'll post a v3 soon taking your remarks into account.

Mathieu

  reply	other threads:[~2018-06-28 13:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19 10:16 [PATCH 1/2] iio: Add channel for Phase Mathieu Othacehe
2018-06-19 10:16 ` [PATCH 2/2] iio: light: isl29501: Add support for the ISL29501 ToF sensor Mathieu Othacehe
2018-06-22 17:25   ` Jonathan Cameron
2018-06-27  8:05     ` [PATCH v2 1/2] iio: Add channel for Phase Mathieu Othacehe
2018-06-27  8:05       ` [PATCH v2 2/2] iio: light: isl29501: Add support for the ISL29501 ToF sensor Mathieu Othacehe
2018-06-27 19:45         ` Peter Meerwald-Stadler
2018-06-28 13:47           ` Mathieu Othacehe [this message]
2018-06-22 17:15 ` [PATCH 1/2] iio: Add channel for Phase Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvpnt43l.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=pierre-moana.levesque@parrot.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.