From: Markus Armbruster <armbru@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block/crypto: Simplify block_crypto_{open, create}_opts_init()
Date: Tue, 26 Jun 2018 19:41:41 +0200 [thread overview]
Message-ID: <87tvppcune.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20180626144659.GC3964@dhcp-200-186.str.redhat.com> (Kevin Wolf's message of "Tue, 26 Jun 2018 16:46:59 +0200")
Kevin Wolf <kwolf@redhat.com> writes:
> Am 14.06.2018 um 16:29 hat Markus Armbruster geschrieben:
>> block_crypto_open_opts_init() and block_crypto_create_opts_init()
>> contain a virtual visit of QCryptoBlockOptions and
>> QCryptoBlockCreateOptions less member "format", respectively.
>>
>> Change their callers to put member "format" in the QDict, so they can
>> use the generated visitors for these types instead.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> This doesn't seem to apply cleanly any more. Can you rebase?
v2 sent.
prev parent reply other threads:[~2018-06-26 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 14:29 [Qemu-devel] [PATCH] block/crypto: Simplify block_crypto_{open, create}_opts_init() Markus Armbruster
2018-06-18 21:44 ` Eric Blake
2018-06-26 14:46 ` Kevin Wolf
2018-06-26 17:41 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvppcune.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.