From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v3 4/4] drm/vc4: Add CTM support Date: Tue, 17 Apr 2018 15:00:54 -0700 Message-ID: <87tvs97asp.fsf@anholt.net> References: <1523479755-20812-1-git-send-email-stschake@gmail.com> <1523479755-20812-5-git-send-email-stschake@gmail.com> <87a7u26g96.fsf@anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1702350463==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 615D36E189 for ; Tue, 17 Apr 2018 22:00:58 +0000 (UTC) In-Reply-To: <87a7u26g96.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: airlied@linux.ie, linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Stefan Schake List-Id: dri-devel@lists.freedesktop.org --===============1702350463== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Eric Anholt writes: > [ Unknown signature status ] > Stefan Schake writes: > >> The hardware has a single block for applying a CTM prior to gamma lut. >> It can be fed with pixels from one of our CRTC at a time and uses a >> matrix with S0.9 scalars. Use private atomic state to reject attempts >> from userland to apply CTM for more than one CRTC at a time and reject >> matrices with scalars that we can't approximate without integer bits. >> >> Signed-off-by: Stefan Schake >> --- >> v3: New in the series > > Patch 2-3 get my r-b, and I've sent Stefan a small series of fixups for > the modeset locking as was patiently explained to me by danvet. With > that, it'll have my r-b, and hopefully danvet can confirm that it's what > he meant :) I've pushed 1-3, and danvet confirmed that the squash fixes looked good to him. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlrWbpYACgkQtdYpNtH8 nuiUcRAAuR4lJpQPawnVDn6VSYhJvjQ03qUmKfdPPMargIkrQ/DGjmZvUVfjFXXb xAb2Z6GFm6nQiCeISEAsFtqw1uN3arucAWoVuGpWetaEYSWh7ImiToEvLP6ISOGq 7f4xmxhPgs9rDFI0MoA/D81IBDgtpvfSWeOTvnSaxE0DrbkeMOvD0EVcZ/q3S9OX Yx1BT70qEjuRq1p8M8QxC8maWWMGXxmSdGQOsKZEMdqLopcbcwhNmtrEh0ds3u71 j1jopSsq/5qVC3lZlCaVM9OBLnhqNvepSFlI3XnqXgDMIvRkgdJjixAvq2d2RlHe xffKNhIPlqueKdTnRmtxLk6pz9ocnvJD+LNVfegKDoC38GYyw+zQZegdIsryeq70 21En4Ro+KcIvpHrha4z8iWZ/TFomOaoALY0rFjwHNzSUpMCqXdfs2/QYaW+PVHr0 8o1YO0pN9A+JXmmq83FePMmEUv1XyqIuENs+IGVlcWUX860OXAx1RrTHOEc4kB3Q aUVnK2+u7s7UZUgZRg4SzZZ1EoXNLjtSC6mF7rAzAtbkZYdjUSKNzJ8o0pPRgyPX aa3zAVTs/O0n5xyQDsuJP8zWJJLQPlusItUtPq92s70YZEixp3FhN1/XLkPzOIhJ 3ddE2nvbxQvnSlj7PUQdIAbly35/bC1DFFErVeJx/vcVnalAQA0= =bTqY -----END PGP SIGNATURE----- --=-=-=-- --===============1702350463== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1702350463==--