From: Jani Nikula <jani.nikula@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Tvrtko Ursulin <tvrtko@ursulin.net>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/i915: Remove hole and padding from intel_shared_dpll
Date: Thu, 15 Mar 2018 13:16:32 +0200 [thread overview]
Message-ID: <87tvthlhbj.fsf@intel.com> (raw)
In-Reply-To: <20180314163132.4130-1-lucas.demarchi@intel.com>
On Wed, 14 Mar 2018, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Reorder fields so we save 8 bytes per instance: this removes a 4-bytes
> hole after enum intel_dpll_id and a 4-bytes padding.
Does GCC have anything like the Clang -Wpadded option to warn us about
alignment holes and padding? Certainly it would be too noisy to run all
the time anyway, but it seems a bit tedious to have to do this by
hand. We could run it every once in a while to catch the worst
offenders.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-15 11:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 16:31 [PATCH] drm/i915: Remove hole and padding from intel_shared_dpll Lucas De Marchi
2018-03-14 17:06 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-14 17:19 ` [PATCH] " Ville Syrjälä
2018-03-15 8:01 ` Lucas De Marchi
2018-03-15 9:54 ` Ville Syrjälä
2018-03-15 18:07 ` Lucas De Marchi
2018-03-15 18:12 ` Ville Syrjälä
2018-03-15 1:03 ` ✓ Fi.CI.IGT: success for " Patchwork
2018-03-15 11:16 ` Jani Nikula [this message]
2018-03-15 18:02 ` [PATCH] " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvthlhbj.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=tvrtko@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.