From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v2 2/2] drm/panel: Add device_link from panel device to drm device Date: Wed, 28 Feb 2018 10:14:20 -0800 Message-ID: <87tvu1f0cj.fsf@anholt.net> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0485504346==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C5F56EAD1 for ; Wed, 28 Feb 2018 18:14:23 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, tomi.valkeinen@ti.com, thierry.reding@gmail.com, Jyri Sarha List-Id: dri-devel@lists.freedesktop.org --===============0485504346== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Jyri Sarha writes: > Add device_link from panel device (supplier) to drm device (consumer) > with DL_FLAG_AUTOREMOVE when drm_panel_attach() is called. Currently > the master drm driver is not protected against the attached. The > device_link with DL_FLAG_AUTOREMOVE should make sure the drm device is > unbound before the panel driver becomes unavailable. > > The device_link is removed when drm_panel_detach() is called. The > drm_panel_detach() should be called by the panel driver it self when > it is removed. Otherwise the both driver are racing to delete the same > link. I think this paragraph wants to be: The device_link is removed when drm_panel_detach() is called. The drm_panel_detach() should be called by the consumer DRM driver, not the panel driver, otherwise both drivers are racing to delete the same link. Other than that, these patches are: Reviewed-by: Eric Anholt (though you'll probably want to wait a bit for Thierry to look at them too) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlqW8X0ACgkQtdYpNtH8 nuicDg//eRHduz6vDjVK9rB6c0pJjacaUpG7T/+QYz5nAulwc4JTqLBK8nGjFQ6+ RXkAces96PE1FXLWzMerFbbhrCNML3cQ0tmh5e52atfBuYyfu42mPKSSYkNjuRgl 8sgdW0hlYWz/pnOcu6pHKEdwum+D0v0Qejd3iKTCc/o+0PQfR2FGkEKnc0WjaMA2 Jf5Q2zgcB/pohTnZTJUDZLOyjDh693rhNTuZEyp2qpygcTiIZV5WyXzqYQSOXNJS TZ7KdmGiV2swFF178viBqR7SCylmBzr7p1/hUAk51lWaruyWZDr0eMzknMlpF4Xh kiDaNrMsbq5Qp5yRrdBbOgc/n7fG4UnVH7mOsAc8eHLPNGt0owt1vzI9QkIgsY2Z dJ8DYNAomfRrtV9bKUwDAa6sGjm7HnX4O2XA8X4OdZuaIvVRBCgkHkQKSdzZb805 O3DzJBIlRJYZuOwdEJtaHbhguQwNz2bi38OK/P+2+AG3ALvnaIxTGGGxP548BGQw GIajQgjv+G/JYHmfCO2CWzaA3u5yPUM/ueUJZNuIAInncy4Utb1i/mPmNu4ZVcFf qLuAKIkgAkn/HZi8cgmlTR6ySUq/8uJ1OOOk8ivtGlOGX14G/AoekGMfOGwMPUXH pldC6xt+v9eKJSSfZiZC5U+ShB6dT8FqW6FfKzhCx4jyXhX6Y48= =9rNH -----END PGP SIGNATURE----- --=-=-=-- --===============0485504346== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0485504346==--