From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Xinming Hu <huxm@marvell.com>,
Linux Wireless <linux-wireless@vger.kernel.org>,
Dmitry Torokhov <dtor@google.com>,
"rajatja\@google.com" <rajatja@google.com>,
Zhiyuan Yang <yangzy@marvell.com>, Tim Song <songtao@marvell.com>,
Cathy Luo <cluo@marvell.com>, James Cao <jcao@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
Ellie Reeves <ellierevves@gmail.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] mwifiex: cancel pcie/sdio work in remove/shutdown handler
Date: Sat, 13 Jan 2018 11:54:53 +0200 [thread overview]
Message-ID: <87tvvqqe1e.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180112190644.GC102880@google.com> (Brian Norris's message of "Fri, 12 Jan 2018 11:06:45 -0800")
Brian Norris <briannorris@chromium.org> writes:
> On Thu, Jan 11, 2018 at 06:25:09PM -0800, Brian Norris wrote:
>> Anyway, I'll do my own testing and then submit my patch properly.
>
> OK, so I definitely confirmed: if your patch does anything, it
> introduces a new deadlock possibility. Just trigger a Wifi timeout or
> reset from within remove(), and you'll see the work event get stuck in
> pci_reset_function(), while remove() gets stuck at cancel_work_sync().
>
> I also confirmed that my patch resolves this problem.
>
> I'll send the revert + my patch now.
Great, thanks. I didn't had a chance to do the revert yet but I'll now
apply your revert instead.
--
Kalle Valo
next prev parent reply other threads:[~2018-01-13 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 12:30 Re: Re: [PATCH] mwifiex: cancel pcie/sdio work in remove/shutdown handler Xinming Hu
2018-01-12 2:25 ` Brian Norris
2018-01-12 19:06 ` Brian Norris
2018-01-13 9:54 ` Kalle Valo [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-13 11:27 Xinming Hu
2018-01-08 18:11 ` Brian Norris
2018-01-09 7:39 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvvqqe1e.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=dtor@google.com \
--cc=ellierevves@gmail.com \
--cc=gbhat@marvell.com \
--cc=hch@lst.de \
--cc=huxm@marvell.com \
--cc=jcao@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rajatja@google.com \
--cc=songtao@marvell.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.