From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/3] ARM: dts: mvebu: add sdram controller node to Armada-38x From: Gregory CLEMENT Message-Id: <87tvvu6ro6.fsf@free-electrons.com> Date: Wed, 10 Jan 2018 09:31:37 +0100 To: Chris Packham Cc: jlu@pengutronix.de, linux@armlinux.org.uk, bp@alien8.de, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Mark Rutland , devicetree@vger.kernel.org List-ID: SGkgQ2hyaXMsCiAKIE9uIG1hci4sIGphbnYuIDA5IDIwMTgsIENocmlzIFBhY2toYW0gPGNocmlz LnBhY2toYW1AYWxsaWVkdGVsZXNpcy5jby5uej4gd3JvdGU6Cgo+IFRoZSBBcm1hZGEtMzh4IHVz ZXMgYW4gU0RSQU0gY29udHJvbGxlciB0aGF0IGlzIGNvbXBhdGlibGUgd2l0aCB0aGUKPiBBcm1h ZGEtWFAuIFRoZSBrZXkgZGlmZmVyZW5jZSBpcyB0aGUgd2lkdGggb2YgdGhlIGJ1cyAoWFAgaXMg NjQvMzIsIDM4eAo+IGlzIDMyLzE2KS4gVGhlIFNEUkFNIGNvbnRyb2xsZXIgcmVnaXN0ZXJzIGFy ZSB0aGUgc2FtZSBiZXR3ZWVuIHRoZSB0d28KPiBTb0NzLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hy aXMgUGFja2hhbSA8Y2hyaXMucGFja2hhbUBhbGxpZWR0ZWxlc2lzLmNvLm56Pgo+IC0tLQo+ICBh cmNoL2FybS9ib290L2R0cy9hcm1hZGEtMzh4LmR0c2kgfCA1ICsrKysrCj4gIDEgZmlsZSBjaGFu Z2VkLCA1IGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9h cm1hZGEtMzh4LmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9hcm1hZGEtMzh4LmR0c2kKPiBpbmRl eCAwMGZmNTQ5ZDRlMzkuLjZkMzRjNWVjMTc4ZiAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9ib290 L2R0cy9hcm1hZGEtMzh4LmR0c2kKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9hcm1hZGEtMzh4 LmR0c2kKPiBAQCAtMTM4LDYgKzEzOCwxMSBAQAo+ICAJCQkjc2l6ZS1jZWxscyA9IDwxPjsKPiAg CQkJcmFuZ2VzID0gPDAgTUJVU19JRCgweGYwLCAweDAxKSAwIDB4MTAwMDAwPjsKPiAgCj4gKwkJ CXNkcmFtY0AxNDAwIHsKCkNvdWxkIHlvdSBhZGQgYSBsYWJlbD8gVGhhbmtzIHRvIHRoaXMgaXQg d291bGQgYmUgcG9zc2libGUgdG8KZW5hYmxlL2Rpc2FibGUgaXQgYXQgYm9hcmQgbGV2ZWwgaW4g YSBlc2F5IHdheS4KCj4gKwkJCQljb21wYXRpYmxlID0gIm1hcnZlbGwsYXJtYWRhLXhwLXNkcmFt LWNvbnRyb2xsZXIiOwo+ICsJCQkJcmVnID0gPDB4MTQwMCAweDUwMD47CgpXaGF0IGFib3V0IGFk ZGluZyBzdGF0dXMgPSAiZGlzYWJsZWQiID8KClRoYW5rcyB0byB0aGlzIHdlIGNhbiBlbmFibGUg aXQgYXQgYm9hcmQgbGV2ZWwgb25seSBpZiB3ZSByZWFsbHkgd2FudAppdCwgaXQgd291bGQgYXZv aWQgbmFzdHkgcmVncmVzc2lvbiBvbiBib2FyZHMgdGhhdCBkb24ndCBuZWVkIGl0LCBpZiBhbgpp c3N1ZSBvY2N1cnMuIFVubGVzcyB5b3UgYXJlIHN1cmUgdGhhdCBpdCBpcyBjb21wbGV0ZWx5IHNh ZmUgdG8gZW5hYmxlCml0IGZvciBldmVyeW9uZS4KClRoYW5rcywKCkdyZWdvcnkKCgo+ICsJCQl9 Owo+ICsKPiAgCQkJTDI6IGNhY2hlLWNvbnRyb2xsZXJAODAwMCB7Cj4gIAkJCQljb21wYXRpYmxl ID0gImFybSxwbDMxMC1jYWNoZSI7Cj4gIAkJCQlyZWcgPSA8MHg4MDAwIDB4MTAwMD47Cj4gLS0g Cj4gMi4xNS4xCj4K From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 10 Jan 2018 09:31:37 +0100 Subject: [PATCH 2/3] ARM: dts: mvebu: add sdram controller node to Armada-38x In-Reply-To: <20180108223158.21930-3-chris.packham@alliedtelesis.co.nz> (Chris Packham's message of "Tue, 9 Jan 2018 11:31:57 +1300") References: <20180108223158.21930-1-chris.packham@alliedtelesis.co.nz> <20180108223158.21930-3-chris.packham@alliedtelesis.co.nz> Message-ID: <87tvvu6ro6.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chris, On mar., janv. 09 2018, Chris Packham wrote: > The Armada-38x uses an SDRAM controller that is compatible with the > Armada-XP. The key difference is the width of the bus (XP is 64/32, 38x > is 32/16). The SDRAM controller registers are the same between the two > SoCs. > > Signed-off-by: Chris Packham > --- > arch/arm/boot/dts/armada-38x.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index 00ff549d4e39..6d34c5ec178f 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -138,6 +138,11 @@ > #size-cells = <1>; > ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>; > > + sdramc at 1400 { Could you add a label? Thanks to this it would be possible to enable/disable it at board level in a esay way. > + compatible = "marvell,armada-xp-sdram-controller"; > + reg = <0x1400 0x500>; What about adding status = "disabled" ? Thanks to this we can enable it at board level only if we really want it, it would avoid nasty regression on boards that don't need it, if an issue occurs. Unless you are sure that it is completely safe to enable it for everyone. Thanks, Gregory > + }; > + > L2: cache-controller at 8000 { > compatible = "arm,pl310-cache"; > reg = <0x8000 0x1000>; > -- > 2.15.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 2/3] ARM: dts: mvebu: add sdram controller node to Armada-38x Date: Wed, 10 Jan 2018 09:31:37 +0100 Message-ID: <87tvvu6ro6.fsf@free-electrons.com> References: <20180108223158.21930-1-chris.packham@alliedtelesis.co.nz> <20180108223158.21930-3-chris.packham@alliedtelesis.co.nz> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20180108223158.21930-3-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> (Chris Packham's message of "Tue, 9 Jan 2018 11:31:57 +1300") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chris Packham Cc: jlu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Chris, On mar., janv. 09 2018, Chris Packham wrote: > The Armada-38x uses an SDRAM controller that is compatible with the > Armada-XP. The key difference is the width of the bus (XP is 64/32, 38x > is 32/16). The SDRAM controller registers are the same between the two > SoCs. > > Signed-off-by: Chris Packham > --- > arch/arm/boot/dts/armada-38x.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index 00ff549d4e39..6d34c5ec178f 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -138,6 +138,11 @@ > #size-cells = <1>; > ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>; > > + sdramc@1400 { Could you add a label? Thanks to this it would be possible to enable/disable it at board level in a esay way. > + compatible = "marvell,armada-xp-sdram-controller"; > + reg = <0x1400 0x500>; What about adding status = "disabled" ? Thanks to this we can enable it at board level only if we really want it, it would avoid nasty regression on boards that don't need it, if an issue occurs. Unless you are sure that it is completely safe to enable it for everyone. Thanks, Gregory > + }; > + > L2: cache-controller@8000 { > compatible = "arm,pl310-cache"; > reg = <0x8000 0x1000>; > -- > 2.15.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751356AbeAJIbx (ORCPT + 1 other); Wed, 10 Jan 2018 03:31:53 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:54555 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbeAJIbt (ORCPT ); Wed, 10 Jan 2018 03:31:49 -0500 From: Gregory CLEMENT To: Chris Packham Cc: jlu@pengutronix.de, linux@armlinux.org.uk, bp@alien8.de, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: dts: mvebu: add sdram controller node to Armada-38x References: <20180108223158.21930-1-chris.packham@alliedtelesis.co.nz> <20180108223158.21930-3-chris.packham@alliedtelesis.co.nz> Date: Wed, 10 Jan 2018 09:31:37 +0100 In-Reply-To: <20180108223158.21930-3-chris.packham@alliedtelesis.co.nz> (Chris Packham's message of "Tue, 9 Jan 2018 11:31:57 +1300") Message-ID: <87tvvu6ro6.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Chris, On mar., janv. 09 2018, Chris Packham wrote: > The Armada-38x uses an SDRAM controller that is compatible with the > Armada-XP. The key difference is the width of the bus (XP is 64/32, 38x > is 32/16). The SDRAM controller registers are the same between the two > SoCs. > > Signed-off-by: Chris Packham > --- > arch/arm/boot/dts/armada-38x.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index 00ff549d4e39..6d34c5ec178f 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -138,6 +138,11 @@ > #size-cells = <1>; > ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>; > > + sdramc@1400 { Could you add a label? Thanks to this it would be possible to enable/disable it at board level in a esay way. > + compatible = "marvell,armada-xp-sdram-controller"; > + reg = <0x1400 0x500>; What about adding status = "disabled" ? Thanks to this we can enable it at board level only if we really want it, it would avoid nasty regression on boards that don't need it, if an issue occurs. Unless you are sure that it is completely safe to enable it for everyone. Thanks, Gregory > + }; > + > L2: cache-controller@8000 { > compatible = "arm,pl310-cache"; > reg = <0x8000 0x1000>; > -- > 2.15.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com