From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Fri, 27 Oct 2017 18:45:17 +0000 Subject: Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() Message-Id: <87tvyke8g2.fsf@intel.com> List-Id: References: <7d5e68c7-2d64-0131-1a08-eeb4e03cc113@users.sourceforge.net> <9fafa688-f699-c587-ef77-840efa71bf76@users.sourceforge.net> In-Reply-To: <9fafa688-f699-c587-ef77-840efa71bf76@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, David Airlie , Laurent Pinchart Cc: kernel-janitors@vger.kernel.org, LKML On Tue, 24 Oct 2017, SF Markus Elfring wrote: > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle software. Please also look into the GCC software, which will detect that your patch does not compile. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:52351 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbdJ0Spy (ORCPT ); Fri, 27 Oct 2017 14:45:54 -0400 From: Jani Nikula To: SF Markus Elfring , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, David Airlie , Laurent Pinchart Cc: kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() In-Reply-To: <9fafa688-f699-c587-ef77-840efa71bf76@users.sourceforge.net> References: <7d5e68c7-2d64-0131-1a08-eeb4e03cc113@users.sourceforge.net> <9fafa688-f699-c587-ef77-840efa71bf76@users.sourceforge.net> Date: Fri, 27 Oct 2017 21:45:17 +0300 Message-ID: <87tvyke8g2.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Tue, 24 Oct 2017, SF Markus Elfring wrote: > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle software. Please also look into the GCC software, which will detect that your patch does not compile. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() Date: Fri, 27 Oct 2017 21:45:17 +0300 Message-ID: <87tvyke8g2.fsf@intel.com> References: <7d5e68c7-2d64-0131-1a08-eeb4e03cc113@users.sourceforge.net> <9fafa688-f699-c587-ef77-840efa71bf76@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F4756E9D2 for ; Fri, 27 Oct 2017 18:45:54 +0000 (UTC) In-Reply-To: <9fafa688-f699-c587-ef77-840efa71bf76@users.sourceforge.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: SF Markus Elfring , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, David Airlie , Laurent Pinchart Cc: kernel-janitors@vger.kernel.org, LKML List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyNCBPY3QgMjAxNywgU0YgTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291 cmNlZm9yZ2UubmV0PiB3cm90ZToKPiBBZGQgYSBqdW1wIHRhcmdldCBzbyB0aGF0IGEgYml0IG9m IGV4Y2VwdGlvbiBoYW5kbGluZyBjYW4gYmUgYmV0dGVyIHJldXNlZAo+IGF0IHRoZSBlbmQgb2Yg dGhpcyBmdW5jdGlvbi4KPgo+IFRoaXMgaXNzdWUgd2FzIGRldGVjdGVkIGJ5IHVzaW5nIHRoZSBD b2NjaW5lbGxlIHNvZnR3YXJlLgoKUGxlYXNlIGFsc28gbG9vayBpbnRvIHRoZSBHQ0Mgc29mdHdh cmUsIHdoaWNoIHdpbGwgZGV0ZWN0IHRoYXQgeW91cgpwYXRjaCBkb2VzIG5vdCBjb21waWxlLgoK QlIsCkphbmkuCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kg Q2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=