From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZylS-0005Ft-CW for qemu-devel@nongnu.org; Tue, 25 Jul 2017 08:16:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZylP-0005PB-7h for qemu-devel@nongnu.org; Tue, 25 Jul 2017 08:16:38 -0400 Received: from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231]:38750) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZylO-0005NN-WF for qemu-devel@nongnu.org; Tue, 25 Jul 2017 08:16:35 -0400 Received: by mail-wr0-x231.google.com with SMTP id f21so61752400wrf.5 for ; Tue, 25 Jul 2017 05:16:34 -0700 (PDT) References: <20170720134716.13049-1-alex.bennee@linaro.org> <20170720134716.13049-2-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Tue, 25 Jul 2017 13:16:32 +0100 Message-ID: <87tw20d84f.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH for 2.10 1/3] docker: ensure NOUSER for travis images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: peter.maydell@linaro.org, famz@redhat.com, qemu-devel@nongnu.org Philippe Mathieu-Daudé writes: > On 07/20/2017 10:47 AM, Alex Bennée wrote: >> While adding the current user is a useful default behaviour for >> creating new images it is not appropriate for Travis which already has >> a default user. >> >> Signed-off-by: Alex Bennée >> --- >> tests/docker/Makefile.include | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include >> index aaab1a4208..d7dafdbd27 100644 >> --- a/tests/docker/Makefile.include >> +++ b/tests/docker/Makefile.include >> @@ -71,6 +71,7 @@ docker-image-debian-ppc64el-cross: docker-image-debian9 >> docker-image-debian-s390x-cross: docker-image-debian9 >> docker-image-debian-win32-cross: docker-image-debian8-mxe >> docker-image-debian-win64-cross: docker-image-debian8-mxe >> +docker-image-travis: NOUSER=1 > > Cool you kept it ordered :) > > I'm surprised we need to install the full LaTeX stack to be able to > compile the device-tree-compiler... Hmm I think installing build-deps is a little extreme as we are not re-building the device-tree-compiler but using it. > > Reading > https://docs.travis-ci.com/user/environment-variables#default-environment-variables > I think it'd be a better match if we also use those default > environment variables, at least: > > DEBIAN_FRONTEND=noninteractive > LANG=en_US.UTF-8 > LC_ALL=en_US.UTF-8 > > what do you think? Sure - it does reduce the noise somewhat. > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > >> # Expand all the pre-requistes for each docker image and test >> combination >> $(foreach i,$(DOCKER_IMAGES), \ >> -- Alex Bennée