From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Daniel Vetter" <daniel.vetter@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel@lists.freedesktop.org,
Bastien Nocera <hadess@hadess.net>
Subject: Re: [PATCH 2/2] drm/i915: Deal with upside-down mounted LCD panels
Date: Mon, 08 May 2017 11:25:36 +0300 [thread overview]
Message-ID: <87tw4vah6n.fsf@intel.com> (raw)
In-Reply-To: <20170507091056.3406-2-hdegoede@redhat.com>
On Sun, 07 May 2017, Hans de Goede <hdegoede@redhat.com> wrote:
> @@ -1403,6 +1410,31 @@ static inline u32 intel_plane_ggtt_offset(const struct intel_plane_state *state)
> return i915_ggtt_offset(state->vma);
> }
>
> +static inline unsigned int
> +intel_plane_get_rotation(const struct intel_plane_state *plane_state)
> +{
Random drive-by bikeshed, is this really worth the inline?
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-05-08 8:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-07 9:10 [PATCH 1/2] drm/i915: intel_crtc_page_flip: Add intel_state local variable Hans de Goede
2017-05-07 9:10 ` [PATCH 2/2] drm/i915: Deal with upside-down mounted LCD panels Hans de Goede
2017-05-08 8:25 ` Jani Nikula [this message]
2017-05-08 8:57 ` Hans de Goede
2017-05-08 10:44 ` Ville Syrjälä
2017-05-08 11:12 ` Hans de Goede
2017-05-08 12:27 ` Chris Wilson
2017-05-08 12:33 ` Hans de Goede
2017-05-08 16:25 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw4vah6n.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.