From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings Date: Sat, 22 Apr 2017 15:40:32 +1000 Message-ID: <87tw5hyp7z.fsf@concordia.ellerman.id.au> References: <18f3784fe7bf463595f7261fb4e8e9fd6548b0d5.1492815938.git.shuahkh@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from ozlabs.org ([103.22.144.67]:56523 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1041294AbdDVFkf (ORCPT ); Sat, 22 Apr 2017 01:40:35 -0400 In-Reply-To: <18f3784fe7bf463595f7261fb4e8e9fd6548b0d5.1492815938.git.shuahkh@osg.samsung.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: shuah@kernel.org, bamvor.zhangjian@linaro.org, benh@kernel.crashing.org, paulus@samba.org, dvhart@infradead.org Cc: Shuah Khan , viro@zeniv.linux.org.uk, emilio.lopez@collabora.co.uk, mingo@kernel.org, luto@kernel.org, dave.hansen@linux.intel.com, dsafonov@virtuozzo.com, rkrcmar@redhat.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Shuah Khan writes: > Add override for lib.mk clean to fix the following warnings from clean > target run. > > Makefile:8: warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > Signed-off-by: Shuah Khan > --- > tools/testing/selftests/splice/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/splice/Makefile b/tools/testing/selftests/splice/Makefile > index 559512c..3f967ba 100644 > --- a/tools/testing/selftests/splice/Makefile > +++ b/tools/testing/selftests/splice/Makefile > @@ -4,5 +4,6 @@ all: $(TEST_PROGS) $(EXTRA) > > include ../lib.mk > > -clean: > +override define CLEAN > rm -fr $(EXTRA) > +endef Could just be: EXTRA_CLEAN := $(EXTRA) cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3w91fT6CrRzDqHj for ; Sat, 22 Apr 2017 15:40:33 +1000 (AEST) From: Michael Ellerman To: Shuah Khan , shuah@kernel.org, bamvor.zhangjian@linaro.org, benh@kernel.crashing.org, paulus@samba.org, dvhart@infradead.org Cc: Shuah Khan , viro@zeniv.linux.org.uk, emilio.lopez@collabora.co.uk, mingo@kernel.org, luto@kernel.org, dave.hansen@linux.intel.com, dsafonov@virtuozzo.com, rkrcmar@redhat.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings In-Reply-To: <18f3784fe7bf463595f7261fb4e8e9fd6548b0d5.1492815938.git.shuahkh@osg.samsung.com> References: <18f3784fe7bf463595f7261fb4e8e9fd6548b0d5.1492815938.git.shuahkh@osg.samsung.com> Date: Sat, 22 Apr 2017 15:40:32 +1000 Message-ID: <87tw5hyp7z.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Shuah Khan writes: > Add override for lib.mk clean to fix the following warnings from clean > target run. > > Makefile:8: warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > Signed-off-by: Shuah Khan > --- > tools/testing/selftests/splice/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/splice/Makefile b/tools/testing/selftests/splice/Makefile > index 559512c..3f967ba 100644 > --- a/tools/testing/selftests/splice/Makefile > +++ b/tools/testing/selftests/splice/Makefile > @@ -4,5 +4,6 @@ all: $(TEST_PROGS) $(EXTRA) > > include ../lib.mk > > -clean: > +override define CLEAN > rm -fr $(EXTRA) > +endef Could just be: EXTRA_CLEAN := $(EXTRA) cheers