From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH v3] drm/i915: Refactor tests for validity
	of	RING_TAIL
Date: Mon, 27 Mar 2017 16:57:44 +0300
Message-ID: <87tw6ex1nr.fsf@gaia.fi.intel.com>
References: <20170327130009.4678-3-chris@chris-wilson.co.uk>
 <20170327131412.20293-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 165B06E205
 for <intel-gfx@lists.freedesktop.org>; Mon, 27 Mar 2017 13:58:38 +0000 (UTC)
In-Reply-To: <20170327131412.20293-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gV2hpbHN0
IEkgbGlrZSBoYXZpbmcgdGhlIGFzc2VydGlvbnMgY2xlYXJseSB2aXNpYmxlIGluIHRoZSBjb2Rl
LCB0aGV5Cj4gYXJlIHF1aXRlIHJlcGV0aXRpb3VzISBBcyB3ZSBmaW5kIG5ldyBsaW1pdHMgd2Ug
d2FudCB0byBpbmNvcnBvcmF0ZSBpbnRvCj4gdGhlIHNldCBvZiBhc3NlcnRpb25zLCBpdCBtYWtl
IHNlbnNlIHRvIHJlZmFjdG9yIHRoZW0gdG8gYSBjb21tb24KPiByb3V0aW5lLgo+Cj4gdjI6IEFk
ZCBhIGd1YyBob2xkb3V0Lgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0Bj
aHJpcy13aWxzb24uY28udWs+Cj4gUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28u
dXJzdWxpbkBpbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9w
cGFsYUBpbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19z
dWJtaXNzaW9uLmMgfCAgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAg
ICAgICAgICAgfCAxMiArKysrLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
cmluZ2J1ZmZlci5jICAgIHwgIDkgKysrLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX3JpbmdidWZmZXIuaCAgICB8IDExICsrKysrKysrKysrCj4gIDQgZmlsZXMgY2hhbmdlZCwg
MTkgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gaW5kZXggOTkxZTc2ZTEwZjgyLi42MTkzYWQ3ZWRj
ZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv
bi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4g
QEAgLTQ4MSw3ICs0ODEsNyBAQCBzdGF0aWMgdm9pZCBndWNfd3FfaXRlbV9hcHBlbmQoc3RydWN0
IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50LAo+ICAKPiAgCS8qIFRoZSBHdUMgZmlybXdhcmUgd2Fu
dHMgdGhlIHRhaWwgaW5kZXggaW4gUVdvcmRzLCBub3QgYnl0ZXMgKi8KPiAgCXRhaWwgPSBycS0+
dGFpbDsKPiAtCUdFTV9CVUdfT04odGFpbCAmIDcpOwo+ICsJYXNzZXJ0X3JpbmdfdGFpbF92YWxp
ZChycS0+cmluZywgcnEtPnRhaWwpOwo+ICAJdGFpbCA+Pj0gMzsKPiAgCUdFTV9CVUdfT04odGFp
bCA+IFdRX1JJTkdfVEFJTF9NQVgpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGlu
ZGV4IDM5Y2I4NGE1ZDRlNC4uYjBjM2EwMjliNTkyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
bHJjLmMKPiBAQCAtMzI2LDggKzMyNiw3IEBAIHN0YXRpYyB1NjQgZXhlY2xpc3RzX3VwZGF0ZV9j
b250ZXh0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEpCj4gIAkJcnEtPmN0eC0+cHBn
dHQgPzogcnEtPmk5MTUtPm1tLmFsaWFzaW5nX3BwZ3R0Owo+ICAJdTMyICpyZWdfc3RhdGUgPSBj
ZS0+bHJjX3JlZ19zdGF0ZTsKPiAgCj4gLQlHRU1fQlVHX09OKCFJU19BTElHTkVEKHJxLT50YWls
LCA4KSk7Cj4gLQlHRU1fQlVHX09OKHJxLT50YWlsID49IHJxLT5yaW5nLT5zaXplKTsKPiArCWFz
c2VydF9yaW5nX3RhaWxfdmFsaWQocnEtPnJpbmcsIHJxLT50YWlsKTsKPiAgCXJlZ19zdGF0ZVtD
VFhfUklOR19UQUlMKzFdID0gcnEtPnRhaWw7Cj4gIAo+ICAJLyogVHJ1ZSAzMmIgUFBHVFQgd2l0
aCBkeW5hbWljIHBhZ2UgYWxsb2NhdGlvbjogdXBkYXRlIFBEUAo+IEBAIC0xMjgyLDggKzEyODEs
NyBAQCBzdGF0aWMgdm9pZCByZXNldF9jb21tb25fcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz
ICplbmdpbmUsCj4gIAlyZXF1ZXN0LT50YWlsID0KPiAgCQlpbnRlbF9yaW5nX3dyYXAocmVxdWVz
dC0+cmluZywKPiAgCQkJCXJlcXVlc3QtPndhX3RhaWwgLSBXQV9UQUlMX0RXT1JEUypzaXplb2Yo
dTMyKSk7Cj4gLQlHRU1fQlVHX09OKCFJU19BTElHTkVEKHJlcXVlc3QtPnRhaWwsIDgpKTsKPiAt
CUdFTV9CVUdfT04ocmVxdWVzdC0+dGFpbCA+PSByZXF1ZXN0LT5yaW5nLT5zaXplKTsKPiArCWFz
c2VydF9yaW5nX3RhaWxfdmFsaWQocmVxdWVzdC0+cmluZywgcmVxdWVzdC0+dGFpbCk7Cj4gIH0K
PiAgCj4gIHN0YXRpYyBpbnQgaW50ZWxfbG9naWNhbF9yaW5nX2VtaXRfcGRwcyhzdHJ1Y3QgZHJt
X2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSkKPiBAQCAtMTQ5NCw4ICsxNDkyLDcgQEAgc3RhdGljIHZv
aWQgZ2VuOF9lbWl0X2JyZWFkY3J1bWIoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1
ZXN0LCB1MzIgKmNzKQo+ICAJKmNzKysgPSBNSV9VU0VSX0lOVEVSUlVQVDsKPiAgCSpjcysrID0g
TUlfTk9PUDsKPiAgCXJlcXVlc3QtPnRhaWwgPSBpbnRlbF9yaW5nX29mZnNldChyZXF1ZXN0LCBj
cyk7Cj4gLQlHRU1fQlVHX09OKCFJU19BTElHTkVEKHJlcXVlc3QtPnRhaWwsIDgpKTsKPiAtCUdF
TV9CVUdfT04ocmVxdWVzdC0+dGFpbCA+PSByZXF1ZXN0LT5yaW5nLT5zaXplKTsKPiArCWFzc2Vy
dF9yaW5nX3RhaWxfdmFsaWQocmVxdWVzdC0+cmluZywgcmVxdWVzdC0+dGFpbCk7Cj4gIAo+ICAJ
Z2VuOF9lbWl0X3dhX3RhaWwocmVxdWVzdCwgY3MpOwo+ICB9Cj4gQEAgLTE1MjMsOCArMTUyMCw3
IEBAIHN0YXRpYyB2b2lkIGdlbjhfZW1pdF9icmVhZGNydW1iX3JlbmRlcihzdHJ1Y3QgZHJtX2k5
MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QsCj4gIAkqY3MrKyA9IE1JX1VTRVJfSU5URVJSVVBUOwo+
ICAJKmNzKysgPSBNSV9OT09QOwo+ICAJcmVxdWVzdC0+dGFpbCA9IGludGVsX3Jpbmdfb2Zmc2V0
KHJlcXVlc3QsIGNzKTsKPiAtCUdFTV9CVUdfT04oIUlTX0FMSUdORUQocmVxdWVzdC0+dGFpbCwg
OCkpOwo+IC0JR0VNX0JVR19PTihyZXF1ZXN0LT50YWlsID49IHJlcXVlc3QtPnJpbmctPnNpemUp
Owo+ICsJYXNzZXJ0X3JpbmdfdGFpbF92YWxpZChyZXF1ZXN0LT5yaW5nLCByZXF1ZXN0LT50YWls
KTsKPiAgCj4gIAlnZW44X2VtaXRfd2FfdGFpbChyZXF1ZXN0LCBjcyk7Cj4gIH0KPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gaW5kZXggNDc5MjFkY2JlZGIzLi42NmEy
YjhiODM5NzIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1
ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4g
QEAgLTc3NCw4ICs3NzQsNyBAQCBzdGF0aWMgdm9pZCBpOXh4X3N1Ym1pdF9yZXF1ZXN0KHN0cnVj
dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiAgCj4gIAlpOTE1X2dlbV9yZXF1ZXN0
X3N1Ym1pdChyZXF1ZXN0KTsKPiAgCj4gLQlHRU1fQlVHX09OKCFJU19BTElHTkVEKHJlcXVlc3Qt
PnRhaWwsIDgpKTsKPiAtCUdFTV9CVUdfT04ocmVxdWVzdC0+dGFpbCA+PSByZXF1ZXN0LT5yaW5n
LT5zaXplKTsKPiArCWFzc2VydF9yaW5nX3RhaWxfdmFsaWQocmVxdWVzdC0+cmluZywgcmVxdWVz
dC0+dGFpbCk7Cj4gIAlJOTE1X1dSSVRFX1RBSUwocmVxdWVzdC0+ZW5naW5lLCByZXF1ZXN0LT50
YWlsKTsKPiAgfQo+ICAKPiBAQCAtNzg3LDggKzc4Niw3IEBAIHN0YXRpYyB2b2lkIGk5eHhfZW1p
dF9icmVhZGNydW1iKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLCB1MzIgKmNzKQo+
ICAJKmNzKysgPSBNSV9VU0VSX0lOVEVSUlVQVDsKPiAgCj4gIAlyZXEtPnRhaWwgPSBpbnRlbF9y
aW5nX29mZnNldChyZXEsIGNzKTsKPiAtCUdFTV9CVUdfT04oIUlTX0FMSUdORUQocmVxLT50YWls
LCA4KSk7Cj4gLQlHRU1fQlVHX09OKHJlcS0+dGFpbCA+PSByZXEtPnJpbmctPnNpemUpOwo+ICsJ
YXNzZXJ0X3JpbmdfdGFpbF92YWxpZChyZXEtPnJpbmcsIHJlcS0+dGFpbCk7Cj4gIH0KPiAgCj4g
IHN0YXRpYyBjb25zdCBpbnQgaTl4eF9lbWl0X2JyZWFkY3J1bWJfc3ogPSA0Owo+IEBAIC04Mjcs
OCArODI1LDcgQEAgc3RhdGljIHZvaWQgZ2VuOF9yZW5kZXJfZW1pdF9icmVhZGNydW1iKHN0cnVj
dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+ICAJKmNzKysgPSBNSV9OT09QOwo+ICAKPiAg
CXJlcS0+dGFpbCA9IGludGVsX3Jpbmdfb2Zmc2V0KHJlcSwgY3MpOwo+IC0JR0VNX0JVR19PTigh
SVNfQUxJR05FRChyZXEtPnRhaWwsIDgpKTsKPiAtCUdFTV9CVUdfT04ocmVxLT50YWlsID49IHJl
cS0+cmluZy0+c2l6ZSk7Cj4gKwlhc3NlcnRfcmluZ190YWlsX3ZhbGlkKHJlcS0+cmluZywgcmVx
LT50YWlsKTsKPiAgfQo+ICAKPiAgc3RhdGljIGNvbnN0IGludCBnZW44X3JlbmRlcl9lbWl0X2Jy
ZWFkY3J1bWJfc3ogPSA4Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9yaW5nYnVmZmVyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgK
PiBpbmRleCAxN2FjNDQ5ODBkODQuLmE4MmEwODA3ZjY0ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBAQCAtNTI5LDYgKzUyOSwxNyBAQCBpbnRlbF9yaW5n
X29mZnNldChjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwgdm9pZCAqYWRk
cikKPiAgCXJldHVybiBpbnRlbF9yaW5nX3dyYXAocmVxLT5yaW5nLCBvZmZzZXQpOwo+ICB9Cj4g
IAo+ICtzdGF0aWMgaW5saW5lIHZvaWQKPiArYXNzZXJ0X3JpbmdfdGFpbF92YWxpZChjb25zdCBz
dHJ1Y3QgaW50ZWxfcmluZyAqcmluZywgdW5zaWduZWQgaW50IHRhaWwpCj4gK3sKPiArCS8qIFdl
IGNvdWxkIGNvbWJpbmUgdGhlc2UgaW50byBhIHNpbmdsZSB0YWlsIG9wZXJhdGlvbiwgYnV0IGtl
ZXBpbmcKPiArCSAqIHRoZW0gYXMgc2VwZXJhdGUgdGVzdHMgd2lsbCBoZWxwIGlkZW50aWZ5IHRo
ZSBjYXVzZSBzaG91bGQgb25lCj4gKwkgKiBldmVyIGZpcmUuCj4gKwkgKi8KPiArCUdFTV9CVUdf
T04oIUlTX0FMSUdORUQodGFpbCwgOCkpOwo+ICsJR0VNX0JVR19PTih0YWlsID49IHJpbmctPnNp
emUpOwo+ICt9Cj4gKwo+ICB2b2lkIGludGVsX3JpbmdfdXBkYXRlX3NwYWNlKHN0cnVjdCBpbnRl
bF9yaW5nICpyaW5nKTsKPiAgCj4gIHZvaWQgaW50ZWxfZW5naW5lX2luaXRfZ2xvYmFsX3NlcW5v
KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgdTMyIHNlcW5vKTsKPiAtLSAKPiAyLjEx
LjAKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g
SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm
eApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n
ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s
aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK