From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752460AbdCCSsQ (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Mar 2017 13:48:16 -0500
Received: from hurricane.the-brannons.com ([71.19.155.94]:33776 "EHLO
        hurricane.the-brannons.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752442AbdCCSsN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Mar 2017 13:48:13 -0500
From: Chris Brannon <chris@the-brannons.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kirk Reiser <kirk@reisers.ca>, William Hubbs <w.d.hubbs@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        speakup@linux-speakup.org
Subject: Re: [patch 3/3] speakup: add unicode variant of /dev/softsynth
References: <20170302015353.380944525@ens-lyon.org>
        <20170302015353.772764035@ens-lyon.org>
Date: Fri, 03 Mar 2017 10:40:11 -0800
In-Reply-To: <20170302015353.772764035@ens-lyon.org> (Samuel Thibault's
        message of "Thu, 02 Mar 2017 02:53:56 +0100")
Message-ID: <87tw7ajjas.fsf@the-brannons.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Samuel Thibault <samuel.thibault@ens-lyon.org> writes:

> This adds /dev/softsynthu, along /dev/softsynth, which emits output in
> UTF-8 encoding, thus allowing to support 16bit characters.  Most of the
> code is shared, only the read function has to behave differently in
> latin1 and in unicode mode.  Since Linux only supports 16bit characters,
> we can just hardcode the UTF-8 encoding.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>


Reviewed-by: Chris Brannon <chris@the-brannons.com>

Looks good to me.