From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2 1/3] drm/i915: Refactor wakeup of the next breadcrumb waiter Date: Fri, 03 Mar 2017 18:19:23 +0200 Message-ID: <87tw7az62c.fsf@gaia.fi.intel.com> References: <20170303121710.14497-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A9C8D6E2A2 for ; Fri, 3 Mar 2017 16:21:16 +0000 (UTC) In-Reply-To: <20170303121710.14497-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUmVmYWN0 b3IgdGhlIGNvbW1vbiB0YXNrIG9mIHVwZGF0aW5nIHRoZSBmaXJzdF93YWl0ZXIsIHNlcmlhbGlz ZWQgd2l0aAo+IHRoZSBpbnRlcnJ1cHQgaGFuZGxlci4gV2hlbiB3ZSB1cGRhdGUgdGhlIGZpcnN0 X3dhaXRlciwgd2UgYWxzbyBuZWVkIHRvCj4gd2FrZXVwIHRoZSBuZXcgYm90dG9tLWhhbGYgaW4g b3JkZXIgdG8gY29tcGxldGUgdGhlIGFjdGlvbnMgdGhhdCB3ZSBtYXkKPiBoYXZlIGRlbGVnYXRl ZCB0byBpdCAoc3VjaCBhcyBjaGVja2luZyB0aGUgaXJxLXNlcW5vIGNvaGVyZW5jeSBvciB3YWtp bmcKPiB1cCBvdGhlciBsb3dlciBwcmlvcml0eSBjb25jdXJyZW50IHdhaXRlcnMpLgo+Cj4gU2ln bmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+CgpSZXZp ZXdlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jIHwgNDggKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMo KyksIDI5IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2JyZWFkY3J1bWJzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNy dW1icy5jCj4gaW5kZXggMjM1ZDQ2NDVhNWNmLi4xY2M1MDMwNGY4MjQgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMKPiBAQCAtMjg3LDYgKzI4NywyMSBAQCBz dGF0aWMgaW5saW5lIHZvaWQgX19pbnRlbF9icmVhZGNydW1ic19maW5pc2goc3RydWN0IGludGVs X2JyZWFkY3J1bWJzICpiLAo+ICAJd2FrZV91cF9wcm9jZXNzKHdhaXQtPnRzayk7IC8qIGltcGxp Y2l0IHNtcF93bWIoKSAqLwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW5saW5lIHZvaWQgX19pbnRlbF9i cmVhZGNydW1ic19uZXh0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiArCQkJCQkg ICAgc3RydWN0IHJiX25vZGUgKm5leHQpCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9icmVhZGNydW1i cyAqYiA9ICZlbmdpbmUtPmJyZWFkY3J1bWJzOwo+ICsKPiArCUdFTV9CVUdfT04oIWItPmlycV9h cm1lZCk7Cj4gKwliLT5maXJzdF93YWl0ID0gdG9fd2FpdChuZXh0KTsKPiArCj4gKwkvKiBXZSBh bHdheXMgd2FrZSB1cCB0aGUgbmV4dCB3YWl0ZXIgdGhhdCB0YWtlcyBvdmVyIGFzIHRoZSBib3R0 b20taGFsZgo+ICsJICogYXMgd2UgbWF5IGRlbGVnYXRlIG5vdCBvbmx5IHRoZSBpcnEtc2Vxbm8g YmFycmllciB0byB0aGUgbmV4dCB3YWl0ZXIKPiArCSAqIGJ1dCBhbHNvIHRoZSB0YXNrIG9mIHdh a2luZyB1cCBjb25jdXJyZW50IHdhaXRlcnMuCj4gKwkgKi8KPiArCXdha2VfdXBfcHJvY2Vzcyh0 b193YWl0KG5leHQpLT50c2spOwo+ICt9Cj4gKwo+ICBzdGF0aWMgYm9vbCBfX2ludGVsX2VuZ2lu ZV9hZGRfd2FpdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gIAkJCQkgICAgc3Ry dWN0IGludGVsX3dhaXQgKndhaXQpCj4gIHsKPiBAQCAtMzU3LDIxICszNzIsNyBAQCBzdGF0aWMg Ym9vbCBfX2ludGVsX2VuZ2luZV9hZGRfd2FpdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUsCj4gIAkJR0VNX0JVR19PTighbmV4dCAmJiAhZmlyc3QpOwo+ICAJCWlmIChuZXh0ICYmIG5l eHQgIT0gJndhaXQtPm5vZGUpIHsKPiAgCQkJR0VNX0JVR19PTihmaXJzdCk7Cj4gLQkJCWItPmZp cnN0X3dhaXQgPSB0b193YWl0KG5leHQpOwo+IC0JCQkvKiBBcyB0aGVyZSBpcyBhIGRlbGF5IGJl dHdlZW4gcmVhZGluZyB0aGUgY3VycmVudAo+IC0JCQkgKiBzZXFubywgcHJvY2Vzc2luZyB0aGUg Y29tcGxldGVkIHRhc2tzIGFuZCBzZWxlY3RpbmcKPiAtCQkJICogdGhlIG5leHQgd2FpdGVyLCB3 ZSBtYXkgaGF2ZSBtaXNzZWQgdGhlIGludGVycnVwdAo+IC0JCQkgKiBhbmQgc28gbmVlZCBmb3Ig dGhlIG5leHQgYm90dG9tLWhhbGYgdG8gd2FrZXVwLgo+IC0JCQkgKgo+IC0JCQkgKiBBbHNvIGFz IHdlIGVuYWJsZSB0aGUgSVJRLCB3ZSBtYXkgbWlzcyB0aGUKPiAtCQkJICogaW50ZXJydXB0IGZv ciB0aGF0IHNlcW5vLCBzbyB3ZSBoYXZlIHRvIHdha2UgdXAKPiAtCQkJICogdGhlIG5leHQgYm90 dG9tLWhhbGYgaW4gb3JkZXIgdG8gZG8gYSBjb2hlcmVudCBjaGVjawo+IC0JCQkgKiBpbiBjYXNl IHRoZSBzZXFubyBwYXNzZWQuCj4gLQkJCSAqLwo+IC0JCQlfX2ludGVsX2JyZWFkY3J1bWJzX2Vu YWJsZV9pcnEoYik7Cj4gLQkJCWlmICh0ZXN0X2JpdChFTkdJTkVfSVJRX0JSRUFEQ1JVTUIsCj4g LQkJCQkgICAgICZlbmdpbmUtPmlycV9wb3N0ZWQpKQo+IC0JCQkJd2FrZV91cF9wcm9jZXNzKHRv X3dhaXQobmV4dCktPnRzayk7Cj4gKwkJCV9faW50ZWxfYnJlYWRjcnVtYnNfbmV4dChlbmdpbmUs IG5leHQpOwo+ICAJCX0KPiAgCj4gIAkJZG8gewo+IEBAIC00NzMsMjEgKzQ3NCwxMCBAQCBzdGF0 aWMgdm9pZCBfX2ludGVsX2VuZ2luZV9yZW1vdmVfd2FpdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUsCj4gIAkJCX0KPiAgCQl9Cj4gIAo+IC0JCWlmIChuZXh0KSB7Cj4gLQkJCS8qIElu IG91ciBoYXN0ZSwgd2UgbWF5IGhhdmUgY29tcGxldGVkIHRoZSBmaXJzdCB3YWl0ZXIKPiAtCQkJ ICogYmVmb3JlIHdlIGVuYWJsZWQgdGhlIGludGVycnVwdC4gRG8gc28gbm93IGFzIHdlCj4gLQkJ CSAqIGhhdmUgYSBzZWNvbmQgd2FpdGVyIGZvciBhIGZ1dHVyZSBzZXFuby4gQWZ0ZXJ3YXJkcywK PiAtCQkJICogd2UgaGF2ZSB0byB3YWtlIHVwIHRoYXQgd2FpdGVyIGluIGNhc2Ugd2UgbWlzc2Vk Cj4gLQkJCSAqIHRoZSBpbnRlcnJ1cHQsIG9yIGlmIHdlIGhhdmUgdG8gaGFuZGxlIGFuCj4gLQkJ CSAqIGV4Y2VwdGlvbiByYXRoZXIgdGhhbiBhIHNlcW5vIGNvbXBsZXRpb24uCj4gLQkJCSAqLwo+ IC0JCQliLT5maXJzdF93YWl0ID0gdG9fd2FpdChuZXh0KTsKPiAtCQkJaWYgKGItPmZpcnN0X3dh aXQtPnNlcW5vICE9IHdhaXQtPnNlcW5vKQo+IC0JCQkJX19pbnRlbF9icmVhZGNydW1ic19lbmFi bGVfaXJxKGIpOwo+IC0JCQl3YWtlX3VwX3Byb2Nlc3MoYi0+Zmlyc3Rfd2FpdC0+dHNrKTsKPiAt CQl9IGVsc2Ugewo+ICsJCWlmIChuZXh0KQo+ICsJCQlfX2ludGVsX2JyZWFkY3J1bWJzX25leHQo ZW5naW5lLCBuZXh0KTsKPiArCQllbHNlCj4gIAkJCWItPmZpcnN0X3dhaXQgPSBOVUxMOwo+IC0J CX0KPiAgCX0gZWxzZSB7Cj4gIAkJR0VNX0JVR19PTihyYl9maXJzdCgmYi0+d2FpdGVycykgPT0g JndhaXQtPm5vZGUpOwo+ICAJfQo+IC0tIAo+IDIuMTEuMAo+Cj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4g SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=