All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-cmake: pass <pkg>_CONF_ENV for the target configure step
Date: Sun, 26 Feb 2017 22:40:06 +0100	[thread overview]
Message-ID: <87tw7gljgp.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1488130968-20114-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sun, 26 Feb 2017 18:42:48 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > The Buildroot manual documents that <pkg>_CONF_ENV is passed in the
 > environment when calling cmake during the configure step. However, the
 > actual implementation in pkg-cmake passes HOST_<pkg>_CONF_ENV when
 > configuring the host variant of a cmake package, but does not pass
 > <pkg>_CONF_ENV when configuring the target variant of a cmake package.

 > This commit fixes that by passing <pkg>_CONF_ENV in the environment as
 > expected. It should not cause any behavior change, because this
 > feature is in fact not used by any package in upstream Buildroot:

 > $ grep CONF_ENV $(git grep -l cmake-package package/)
 > package/pkg-cmake.mk:$(2)_CONF_ENV			?=
 > package/pkg-cmake.mk:	$$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
 > package/pkg-cmake.mk:	$$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \

 > This issue was reported by Olivier <ovalentin@awox.com> as bug #9616.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2017-02-26 21:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-26 17:42 [Buildroot] [PATCH] pkg-cmake: pass <pkg>_CONF_ENV for the target configure step Thomas Petazzoni
2017-02-26 17:58 ` Yann E. MORIN
2017-02-26 18:02   ` Thomas Petazzoni
2017-02-26 21:40 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw7gljgp.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.