From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>, Oliver Neukum <oneukum@suse.com>
Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
thomas@winischhofer.net, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code
Date: Thu, 16 Feb 2017 22:59:47 +0200 [thread overview]
Message-ID: <87tw7t4zss.fsf@linux.intel.com> (raw)
In-Reply-To: <20170216163919.GB30538@kroah.com>
Hi,
Greg KH <gregkh@linuxfoundation.org> writes:
> On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote:
>> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva:
>> > The condition modex % 16 cannot be true when modex value is equal to
>> > 640
>> > The condition du & 0xff cannot be true when du value is equal to
>> > 0x1400
>> >
>>
>> Sorry for speaking up so late, but this is not a good idea.
>> We lose the knowledge how to do this correctly, if we want
>> to change the resolution.
>
> Given the age of this driver, I doubt that will ever happen :)
besides, the "knowledge" will always be in git history.
--
balbi
prev parent reply other threads:[~2017-02-16 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 4:01 [PATCH] drivers: usb-misc: sisusbvga: remove dead code Gustavo A. R. Silva
2017-02-16 10:28 ` Oliver Neukum
2017-02-16 16:39 ` Greg KH
2017-02-16 20:59 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw7t4zss.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.