From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cc5Ff-0002S0-Np for ath10k@lists.infradead.org; Fri, 10 Feb 2017 07:04:19 +0000 From: "Valo, Kalle" Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Date: Fri, 10 Feb 2017 07:03:56 +0000 Message-ID: <87tw82il32.fsf@kamboji.qca.qualcomm.com> References: <1486030773-30600-1-git-send-email-amadeusz.slawinski@tieto.com> <87y3xi4b28.fsf@qca.qualcomm.com> <5899DDD7.7000605@candelatech.com> In-Reply-To: <5899DDD7.7000605@candelatech.com> (Ben Greear's message of "Tue, 7 Feb 2017 06:46:47 -0800") Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Ben Greear Cc: Adrian Chadd , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , =?iso-8859-2?Q?Amadeusz_S=B3awi=F1ski?= , "ath10k@lists.infradead.org" , Linux Kernel Mailing List Ben Greear writes: > On 02/07/2017 01:14 AM, Valo, Kalle wrote: >> Adrian Chadd writes: >> >>> Removing this method makes the diff to FreeBSD larger, as "vif" in >>> FreeBSD is a different pointer. >>> >>> (Yes, I have ath10k on freebsd working and I'd like to find a way to >>> reduce the diff moving forward.) >> >> I don't like this "(void *) vif->drv_priv" style that much either but >> apparently it's commonly used in Linux wireless code and already parts >> of ath10k. So this patch just unifies the coding style. > > Surely the code compiles to the same thing, so why add a patch that > makes it more difficult for Adrian and makes the code no easier to read > for the rest of us? Because that's the coding style used already in Linux. It's great to see that parts of ath10k can be used also in other systems but in principle I'm not very fond of the idea starting to reject valid upstream patches because of driver forks. I think backports project is doing it right, it's not limiting upstream development in any way and handles all the API changes internally. Maybe FreeBSD could do something similar? -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:22560 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbdBJHEA (ORCPT ); Fri, 10 Feb 2017 02:04:00 -0500 From: "Valo, Kalle" To: Ben Greear CC: Adrian Chadd , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , =?iso-8859-2?Q?Amadeusz_S=B3awi=F1ski?= , "ath10k@lists.infradead.org" , Linux Kernel Mailing List Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Date: Fri, 10 Feb 2017 07:03:56 +0000 Message-ID: <87tw82il32.fsf@kamboji.qca.qualcomm.com> (sfid-20170210_080425_072254_4237DB14) References: <1486030773-30600-1-git-send-email-amadeusz.slawinski@tieto.com> <87y3xi4b28.fsf@qca.qualcomm.com> <5899DDD7.7000605@candelatech.com> In-Reply-To: <5899DDD7.7000605@candelatech.com> (Ben Greear's message of "Tue, 7 Feb 2017 06:46:47 -0800") Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Ben Greear writes: > On 02/07/2017 01:14 AM, Valo, Kalle wrote: >> Adrian Chadd writes: >> >>> Removing this method makes the diff to FreeBSD larger, as "vif" in >>> FreeBSD is a different pointer. >>> >>> (Yes, I have ath10k on freebsd working and I'd like to find a way to >>> reduce the diff moving forward.) >> >> I don't like this "(void *) vif->drv_priv" style that much either but >> apparently it's commonly used in Linux wireless code and already parts >> of ath10k. So this patch just unifies the coding style. > > Surely the code compiles to the same thing, so why add a patch that > makes it more difficult for Adrian and makes the code no easier to read > for the rest of us? Because that's the coding style used already in Linux. It's great to see that parts of ath10k can be used also in other systems but in principle I'm not very fond of the idea starting to reject valid upstream patches because of driver forks. I think backports project is doing it right, it's not limiting upstream development in any way and handles all the API changes internally. Maybe FreeBSD could do something similar? --=20 Kalle Valo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbdBJHEC (ORCPT ); Fri, 10 Feb 2017 02:04:02 -0500 Received: from wolverine02.qualcomm.com ([199.106.114.251]:22560 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbdBJHEA (ORCPT ); Fri, 10 Feb 2017 02:04:00 -0500 X-IronPort-AV: E=Sophos;i="5.35,139,1484035200"; d="scan'208";a="357102044" X-IronPort-AV: E=McAfee;i="5800,7501,8434"; a="1360943716" From: "Valo, Kalle" To: Ben Greear CC: Adrian Chadd , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , =?iso-8859-2?Q?Amadeusz_S=B3awi=F1ski?= , "ath10k@lists.infradead.org" , Linux Kernel Mailing List Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Thread-Topic: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Thread-Index: AQHSgSKdXhLW1W5rb0ahmbyXBxBFIw== Date: Fri, 10 Feb 2017 07:03:56 +0000 Message-ID: <87tw82il32.fsf@kamboji.qca.qualcomm.com> References: <1486030773-30600-1-git-send-email-amadeusz.slawinski@tieto.com> <87y3xi4b28.fsf@qca.qualcomm.com> <5899DDD7.7000605@candelatech.com> In-Reply-To: <5899DDD7.7000605@candelatech.com> (Ben Greear's message of "Tue, 7 Feb 2017 06:46:47 -0800") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1A74BD8006019 Ben Greear writes: > On 02/07/2017 01:14 AM, Valo, Kalle wrote: >> Adrian Chadd writes: >> >>> Removing this method makes the diff to FreeBSD larger, as "vif" in >>> FreeBSD is a different pointer. >>> >>> (Yes, I have ath10k on freebsd working and I'd like to find a way to >>> reduce the diff moving forward.) >> >> I don't like this "(void *) vif->drv_priv" style that much either but >> apparently it's commonly used in Linux wireless code and already parts >> of ath10k. So this patch just unifies the coding style. > > Surely the code compiles to the same thing, so why add a patch that > makes it more difficult for Adrian and makes the code no easier to read > for the rest of us? Because that's the coding style used already in Linux. It's great to see that parts of ath10k can be used also in other systems but in principle I'm not very fond of the idea starting to reject valid upstream patches because of driver forks. I think backports project is doing it right, it's not limiting upstream development in any way and handles all the API changes internally. Maybe FreeBSD could do something similar? -- Kalle Valo