diff for duplicates of <87tw8lnei3.fsf@codeaurora.org> diff --git a/a/1.txt b/N1/1.txt index c07a7d3..13796e9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,10 +1,9 @@ -Pali Roh=C3=A1r <pali.rohar@gmail.com> writes: +Pali Rohár <pali.rohar@gmail.com> writes: > NVS calibration data for wl1251 are model specific. Every one device with > wl1251 chip has different and calibrated in factory. > -> Not all wl1251 chips have own EEPROM where are calibration data stored. A= -nd +> Not all wl1251 chips have own EEPROM where are calibration data stored. And > in that case there is no "standard" place. Every device has stored them on > different place (some in rootfs file, some in dedicated nand partition, > some in another proprietary structure). @@ -17,22 +16,20 @@ nd > In case userspace helper fails request_firmware_prefer_user() still try to > load data file directly from VFS as fallback mechanism. > -> On Nokia N900 device which has wl1251 chip, NVS calibration data are stor= -ed +> On Nokia N900 device which has wl1251 chip, NVS calibration data are stored > in CAL nand partition. CAL is proprietary Nokia key/value format for nand > devices. > > With this patch it is finally possible to load correct model specific NVS > calibration data for Nokia N900. > -> Signed-off-by: Pali Roh=C3=A1r <pali.rohar@gmail.com> +> Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > --- > drivers/net/wireless/ti/wl1251/Kconfig | 1 + > drivers/net/wireless/ti/wl1251/main.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > -> diff --git a/drivers/net/wireless/ti/wl1251/Kconfig b/drivers/net/wireles= -s/ti/wl1251/Kconfig +> diff --git a/drivers/net/wireless/ti/wl1251/Kconfig b/drivers/net/wireless/ti/wl1251/Kconfig > index 7142ccf..affe154 100644 > --- a/drivers/net/wireless/ti/wl1251/Kconfig > +++ b/drivers/net/wireless/ti/wl1251/Kconfig @@ -44,17 +41,16 @@ s/ti/wl1251/Kconfig > select CRC7 > ---help--- > This will enable TI wl1251 driver support. The drivers make -> diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless= -/ti/wl1251/main.c +> diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c > index 208f062..24f8866 100644 > --- a/drivers/net/wireless/ti/wl1251/main.c > +++ b/drivers/net/wireless/ti/wl1251/main.c > @@ -110,7 +110,7 @@ static int wl1251_fetch_nvs(struct wl1251 *wl) -> struct device *dev =3D wiphy_dev(wl->hw->wiphy); +> struct device *dev = wiphy_dev(wl->hw->wiphy); > int ret; ->=20=20 -> - ret =3D request_firmware(&fw, WL1251_NVS_NAME, dev); -> + ret =3D request_firmware_prefer_user(&fw, WL1251_NVS_NAME, dev); +> +> - ret = request_firmware(&fw, WL1251_NVS_NAME, dev); +> + ret = request_firmware_prefer_user(&fw, WL1251_NVS_NAME, dev); I don't see the need for this. Just remove the default nvs file from filesystem and the fallback user helper will be always used, right? @@ -62,5 +58,5 @@ filesystem and the fallback user helper will be always used, right? Like we discussed earlier, the default nvs file should not be used by normal users. ---=20 +-- Kalle Valo diff --git a/a/content_digest b/N1/content_digest index 58dbbe2..1df3cc5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -21,13 +21,12 @@ " netdev@vger.kernel.org\0" "\00:1\0" "b\0" - "Pali Roh=C3=A1r <pali.rohar@gmail.com> writes:\n" + "Pali Roh\303\241r <pali.rohar@gmail.com> writes:\n" "\n" "> NVS calibration data for wl1251 are model specific. Every one device with\n" "> wl1251 chip has different and calibrated in factory.\n" ">\n" - "> Not all wl1251 chips have own EEPROM where are calibration data stored. A=\n" - "nd\n" + "> Not all wl1251 chips have own EEPROM where are calibration data stored. And\n" "> in that case there is no \"standard\" place. Every device has stored them on\n" "> different place (some in rootfs file, some in dedicated nand partition,\n" "> some in another proprietary structure).\n" @@ -40,22 +39,20 @@ "> In case userspace helper fails request_firmware_prefer_user() still try to\n" "> load data file directly from VFS as fallback mechanism.\n" ">\n" - "> On Nokia N900 device which has wl1251 chip, NVS calibration data are stor=\n" - "ed\n" + "> On Nokia N900 device which has wl1251 chip, NVS calibration data are stored\n" "> in CAL nand partition. CAL is proprietary Nokia key/value format for nand\n" "> devices.\n" ">\n" "> With this patch it is finally possible to load correct model specific NVS\n" "> calibration data for Nokia N900.\n" ">\n" - "> Signed-off-by: Pali Roh=C3=A1r <pali.rohar@gmail.com>\n" + "> Signed-off-by: Pali Roh\303\241r <pali.rohar@gmail.com>\n" "> ---\n" "> drivers/net/wireless/ti/wl1251/Kconfig | 1 +\n" "> drivers/net/wireless/ti/wl1251/main.c | 2 +-\n" "> 2 files changed, 2 insertions(+), 1 deletion(-)\n" ">\n" - "> diff --git a/drivers/net/wireless/ti/wl1251/Kconfig b/drivers/net/wireles=\n" - "s/ti/wl1251/Kconfig\n" + "> diff --git a/drivers/net/wireless/ti/wl1251/Kconfig b/drivers/net/wireless/ti/wl1251/Kconfig\n" "> index 7142ccf..affe154 100644\n" "> --- a/drivers/net/wireless/ti/wl1251/Kconfig\n" "> +++ b/drivers/net/wireless/ti/wl1251/Kconfig\n" @@ -67,17 +64,16 @@ "> \tselect CRC7\n" "> \t---help---\n" "> \t This will enable TI wl1251 driver support. The drivers make\n" - "> diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless=\n" - "/ti/wl1251/main.c\n" + "> diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c\n" "> index 208f062..24f8866 100644\n" "> --- a/drivers/net/wireless/ti/wl1251/main.c\n" "> +++ b/drivers/net/wireless/ti/wl1251/main.c\n" "> @@ -110,7 +110,7 @@ static int wl1251_fetch_nvs(struct wl1251 *wl)\n" - "> \tstruct device *dev =3D wiphy_dev(wl->hw->wiphy);\n" + "> \tstruct device *dev = wiphy_dev(wl->hw->wiphy);\n" "> \tint ret;\n" - ">=20=20\n" - "> -\tret =3D request_firmware(&fw, WL1251_NVS_NAME, dev);\n" - "> +\tret =3D request_firmware_prefer_user(&fw, WL1251_NVS_NAME, dev);\n" + "> \n" + "> -\tret = request_firmware(&fw, WL1251_NVS_NAME, dev);\n" + "> +\tret = request_firmware_prefer_user(&fw, WL1251_NVS_NAME, dev);\n" "\n" "I don't see the need for this. Just remove the default nvs file from\n" "filesystem and the fallback user helper will be always used, right?\n" @@ -85,7 +81,7 @@ "Like we discussed earlier, the default nvs file should not be used by\n" "normal users.\n" "\n" - "--=20\n" + "-- \n" Kalle Valo -dff9d200bb55dc41782d0ab3bbee4d52824035e9f8d79583c0332fecb1239537 +518016b5e86b4e0b6168e73bb42b36124fbd01e20f7cfd72dce160846ab541ea
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.