From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: tune down the fast link training vs boot fail Date: Thu, 15 Dec 2016 11:10:29 +0200 Message-ID: <87twa5pnga.fsf@intel.com> References: <20161213195414.28923-1-daniel.vetter@ffwll.ch> <20161213202305.GQ31595@intel.com> <20161213223722.xxgheqytlrvsi36d@phenom.ffwll.local> <87bmwer23i.fsf@intel.com> <20161215074836.5gi66urjvfvrnwvo@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F3096E094 for ; Thu, 15 Dec 2016 09:10:33 +0000 (UTC) In-Reply-To: <20161215074836.5gi66urjvfvrnwvo@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , stable@vger.kernel.org, Daniel Vetter , Linus Torvalds List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxNSBEZWMgMjAxNiwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBXZWQsIERlYyAxNCwgMjAxNiBhdCAwNDo1NjozM1BNICswMjAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gT24gV2VkLCAxNCBEZWMgMjAxNiwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZm d2xsLmNoPiB3cm90ZToKPj4gPiBPbiBUdWUsIERlYyAxMywgMjAxNiBhdCAxMDoyMzowNVBNICsw MjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4+ID4+IE9uIFR1ZSwgRGVjIDEzLCAyMDE2IGF0 IDA4OjU0OjE0UE0gKzAxMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+ID4+ID4gSXQncyBiZWVu IHVuZml4ZWQgc2luY2UgYSB3aGlsZSBhbmQgbm8gb25lIGlzIGltbWVkaWF0ZWx5IHdvcmtpbmcg b24KPj4gPj4gPiB0aGlzLiBBbmQgd2UgaGF2ZSB0aGUgRklYTUUgYWxyZWFkeS4gQW5kIG5vdyBh bHNvIGEgdGFzayBpbiB0aGUgRFAKPj4gPj4gPiB0ZWFtJ3MgYmFja2xvZy4KPj4gPj4gPiAKPj4g Pj4gPiBDYzogTGludXMgVG9ydmFsZHMgPHRvcnZhbGRzQGxpbnV4LWZvdW5kYXRpb24ub3JnPgo+ PiA+PiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4+ID4+ID4gQ2M6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4+ID4+ID4gUmVmZXJlbmNlczog aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvaW50ZWwtZ2Z4LzIwMTYtSnVs eS8xMDE5NTEuaHRtbAo+PiA+PiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmll bC52ZXR0ZXJAaW50ZWwuY29tPgo+PiA+PiA+IC0tLQo+PiA+PiA+IEhpIExpbnVzLAo+PiA+PiA+ IAo+PiA+PiA+IEZlZWwgZnJlZSB0byBhcHBseSBkaXJlY3RseSBpbiBjYXNlIGl0IGFubm95cyB0 b28gbXVjaCBhbmQgeW91IGRvbid0Cj4+ID4+ID4gd2FudCB0byB3YWl0IGZvciB5b3VyIHByZXNl bnRzIDstKQo+PiA+PiA+IAo+PiA+PiA+IENoZWVycywgRGFuaWVsCj4+ID4+ID4gLS0tCj4+ID4+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCA0ICsrLS0KPj4gPj4gPiAgMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4gPj4gPiAKPj4g Pj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPj4gPj4gPiBpbmRleCBkYjc1YmI5MjRlNDguLjZl ODc1ZDQyNjQyYSAxMDA2NDQKPj4gPj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcC5jCj4+ID4+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+PiA+ PiA+IEBAIC00MDE0LDggKzQwMTQsOCBAQCBpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1cyhzdHJ1 Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+PiA+PiA+ICAJCXJldHVybjsKPj4gPj4gPiAgCj4+ID4+ ID4gIAkvKiBGSVhNRTogd2UgbmVlZCB0byBzeW5jaHJvbml6ZSB0aGlzIHNvcnQgb2Ygc3R1ZmYg d2l0aCBoYXJkd2FyZQo+PiA+PiA+IC0JICogcmVhZG91dCAqLwo+PiA+PiA+IC0JaWYgKFdBUk5f T05fT05DRSghaW50ZWxfZHAtPmxhbmVfY291bnQpKQo+PiA+PiA+ICsJICogcmVhZG91dC4gQ3Vy cmVudGx5IGZhc3QgbGluayB0cmFpbmluZyBkb2Vzbid0IHdvcmsgb24gYm9vdC11cC4gKi8KPj4g Pj4gCj4+ID4+IHMvZmFzdCBsaW5rIHRyYWluaW5nL2xpbmsgcmV0cmFpbmluZy8gaXMgd2hhdCBJ J2QgcHV0IHRoZXJlLgo+PiA+Cj4+ID4gQWRqdXN0ZWQgLi4uCj4+ID4+IAo+PiA+PiBJJ20gYSBi aXQgc2FkIHRvIGhpZGUgaXQgYnV0IGRvZXNuJ3QgbG9vayBsaWtlIHRoZSBwcm9wZXIgc29sdXRp b24gaXMKPj4gPj4gZ29pbmcgdG8gaGFwcGVuIGFueSB0aW1lIHNvb24uCj4+ID4+IAo+PiA+PiBB Y2tlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pj4gPgo+PiA+IC4uLiBhbmQgbWVyZ2VkIHNpbmNlIENJIHNlZW1zIHRvIGFwcHJvdmUgdG9vIDst KQo+PiAKPj4gKnNpZ2gqIHlvdSBjb3VsZCd2ZSBhZGRlZCBkZWJ1ZyBsb2dnaW5nIGF0IGxlYXN0 LiBOb3cgaXQncyBwcmV0dHkgbXVjaAo+PiBndWFyYW50ZWVkIG5vYm9keSB3aWxsIGxvb2sgYXQg dGhpcy4gSXQncyBub3QgcmlnaHQgdG8gZW5kIHVwIGhlcmUKPj4gd2l0aG91dCBsaW5rIHBhcmFt cy4gOigKPgo+IEkndmUgbWFkZSBhIEpJUkEgaW50ZXJuYWxseSB0byBmaXggdGhpcyBhbmQgYXNz aWduZWQgaXQgdG8gUGF1bCBQYXJlbnRlYXUKPiBmb3IgaGFuZGxpbmcgd2l0aCBoaXMgRFAgZm9s a3MuIEJ1dCBJJ20gaGFwcHkgdG8gYWxzbyByLWIgc3RhbXAgYSBwYXRjaAo+IHRoYXQgYWRkcyBz b21lIGRlYnVnIG91dHB1dCBoZXJlIGlmIHlvdSB3YW50IHRoYXQgdG9vLiBBdCBsZWFzdCBJIHRo b3VnaHQKPiB0aGUgcHJvYmxlbSBpcyBmYWlybHkgd2VsbC11bmRlcnN0b29kLCBzbyBkaWRuJ3Qg dGhpbmsgdGhpcyB3YXMgbmVlZGVkLgoKT2gsIG9rYXkuIFRoZW4gaXQncyBqdXN0IHRoYXQgKkkq IGRpZG4ndCB1bmRlcnN0YW5kIHRoZSBwcm9ibGVtIHdlbGwuIDooCgpCUiwKSmFuaS4KCgotLSAK SmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com ([192.55.52.43]:26275 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754888AbcLOJLN (ORCPT ); Thu, 15 Dec 2016 04:11:13 -0500 From: Jani Nikula To: Daniel Vetter Cc: Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= , Daniel Vetter , Intel Graphics Development , Linus Torvalds , stable@vger.kernel.org, Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] drm/i915: tune down the fast link training vs boot fail In-Reply-To: <20161215074836.5gi66urjvfvrnwvo@phenom.ffwll.local> References: <20161213195414.28923-1-daniel.vetter@ffwll.ch> <20161213202305.GQ31595@intel.com> <20161213223722.xxgheqytlrvsi36d@phenom.ffwll.local> <87bmwer23i.fsf@intel.com> <20161215074836.5gi66urjvfvrnwvo@phenom.ffwll.local> Date: Thu, 15 Dec 2016 11:10:29 +0200 Message-ID: <87twa5pnga.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Thu, 15 Dec 2016, Daniel Vetter wrote: > On Wed, Dec 14, 2016 at 04:56:33PM +0200, Jani Nikula wrote: >> On Wed, 14 Dec 2016, Daniel Vetter wrote: >> > On Tue, Dec 13, 2016 at 10:23:05PM +0200, Ville Syrjälä wrote: >> >> On Tue, Dec 13, 2016 at 08:54:14PM +0100, Daniel Vetter wrote: >> >> > It's been unfixed since a while and no one is immediately working on >> >> > this. And we have the FIXME already. And now also a task in the DP >> >> > team's backlog. >> >> > >> >> > Cc: Linus Torvalds >> >> > Cc: stable@vger.kernel.org >> >> > Cc: Ville Syrjälä >> >> > References: https://lists.freedesktop.org/archives/intel-gfx/2016-July/101951.html >> >> > Signed-off-by: Daniel Vetter >> >> > --- >> >> > Hi Linus, >> >> > >> >> > Feel free to apply directly in case it annoys too much and you don't >> >> > want to wait for your presents ;-) >> >> > >> >> > Cheers, Daniel >> >> > --- >> >> > drivers/gpu/drm/i915/intel_dp.c | 4 ++-- >> >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> >> > >> >> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c >> >> > index db75bb924e48..6e875d42642a 100644 >> >> > --- a/drivers/gpu/drm/i915/intel_dp.c >> >> > +++ b/drivers/gpu/drm/i915/intel_dp.c >> >> > @@ -4014,8 +4014,8 @@ intel_dp_check_link_status(struct intel_dp *intel_dp) >> >> > return; >> >> > >> >> > /* FIXME: we need to synchronize this sort of stuff with hardware >> >> > - * readout */ >> >> > - if (WARN_ON_ONCE(!intel_dp->lane_count)) >> >> > + * readout. Currently fast link training doesn't work on boot-up. */ >> >> >> >> s/fast link training/link retraining/ is what I'd put there. >> > >> > Adjusted ... >> >> >> >> I'm a bit sad to hide it but doesn't look like the proper solution is >> >> going to happen any time soon. >> >> >> >> Acked-by: Ville Syrjälä >> > >> > ... and merged since CI seems to approve too ;-) >> >> *sigh* you could've added debug logging at least. Now it's pretty much >> guaranteed nobody will look at this. It's not right to end up here >> without link params. :( > > I've made a JIRA internally to fix this and assigned it to Paul Parenteau > for handling with his DP folks. But I'm happy to also r-b stamp a patch > that adds some debug output here if you want that too. At least I thought > the problem is fairly well-understood, so didn't think this was needed. Oh, okay. Then it's just that *I* didn't understand the problem well. :( BR, Jani. -- Jani Nikula, Intel Open Source Technology Center