From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7P0W-0001Mx-3v for qemu-devel@nongnu.org; Thu, 17 Nov 2016 10:53:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7P0S-0004EI-JV for qemu-devel@nongnu.org; Thu, 17 Nov 2016 10:53:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54474) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7P0S-0004Dp-Bh for qemu-devel@nongnu.org; Thu, 17 Nov 2016 10:53:44 -0500 From: Markus Armbruster References: <1478694124-15803-1-git-send-email-david@gibson.dropbear.id.au> <1478694124-15803-4-git-send-email-david@gibson.dropbear.id.au> <2c5f3568-f288-f881-34ce-76b03546bbd2@ilande.co.uk> <1589884362.11975786.1478792230830.JavaMail.zimbra@redhat.com> Date: Thu, 17 Nov 2016 16:53:40 +0100 In-Reply-To: <1589884362.11975786.1478792230830.JavaMail.zimbra@redhat.com> (Paolo Bonzini's message of "Thu, 10 Nov 2016 10:37:10 -0500 (EST)") Message-ID: <87twb6cdbv.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCHv2 3/3] Split ISA and sysbus versions of m48t59 device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Mark Cave-Ayland , veroniabahaa@gmail.com, peter maydell , proljc@gmail.com, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, agraf@suse.de, mst@redhat.com, qemu-devel@nongnu.org, borntraeger@de.ibm.com, michael@walle.cc, cornelia huck , edgar iglesias , David Gibson Paolo Bonzini writes: > ----- Original Message ----- >> From: "Mark Cave-Ayland" >> To: "Paolo Bonzini" , "David Gibson" , "edgar iglesias" >> , michael@walle.cc, proljc@gmail.com, borntraeger@de.ibm.com, "cornelia huck" >> , kbastian@mail.uni-paderborn.de, jcmvbkbc@gmail.com >> Cc: veroniabahaa@gmail.com, "peter maydell" , mst@redhat.com, armbru@redhat.com, >> qemu-devel@nongnu.org, agraf@suse.de >> Sent: Thursday, November 10, 2016 4:16:36 PM >> Subject: Re: [Qemu-devel] [PATCHv2 3/3] Split ISA and sysbus versions of m48t59 device >> >> On 10/11/16 14:57, Paolo Bonzini wrote: >> > >> > >> > On 09/11/2016 13:22, David Gibson wrote: >> >> The m48t59 device supports both ISA and direct sysbus attached versions of >> >> the device in the one .c file. This can be awkward for some embedded >> >> machine types which need the sysbus M48T59, but don't want to pull in the >> >> ISA bus code and its other dependencies. >> >> >> >> Therefore, this patch splits out the code for the ISA attached M48T59 into >> >> its own C file. It will be built when both CONFIG_M48T59 and >> >> CONFIG_ISA_BUS are enabled. >> >> >> >> Signed-off-by: David Gibson >> > >> > Who needs the ISA M48T59? Perhaps it should be a separate symbol >> > altogether. Let's document that SPARC will stop providing it in 2.9, >> > for example, if it's only a PReP thing. >> > >> > Paolo >> >> Hi Paolo, >> >> The ISA M48T59 is still actively used by the sun4u machine on >> qemu-system-sparc64. In real terms it's actually connected to the ebus, >> but for all intents and purposes it's the same as an ISA bus connected >> via a PCI bridge. > > sun4u is actually using the sysbus M48T59, and mapping it into the ebus > space: > > nvram = m48t59_init(NULL, 0, 0, NVRAM_SIZE, 1968, 59); > s = SYS_BUS_DEVICE(nvram); > memory_region_add_subregion(get_system_io(), 0x2000, > sysbus_mmio_get_region(s, 0)); As far as I can tell, only machine "prep" uses ISA M48T59. Is David's patch okay as is, Paolo?