From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH] Revert "gpio/mvebu: convert to use irq_domain_add_simple()" Date: Thu, 27 Oct 2016 09:30:32 +0200 Message-ID: <87twbyb65j.fsf@free-electrons.com> References: <1476831396-24359-1-git-send-email-jgunthorpe@obsidianresearch.com> <871szcerxl.fsf@free-electrons.com> <20161019210341.GA3746@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from up.free-electrons.com ([163.172.77.33]:58868 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752696AbcJ0Haf (ORCPT ); Thu, 27 Oct 2016 03:30:35 -0400 In-Reply-To: (Linus Walleij's message of "Mon, 24 Oct 2016 01:11:23 +0200") Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Jason Gunthorpe , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , Thomas Petazzoni , Andrew Lunn , Grant Likely , Sebastian Hesselbarth Hi Linus, On lun., oct. 24 2016, Linus Walleij wrote: > On Wed, Oct 19, 2016 at 11:03 PM, Jason Gunthorpe > wrote: > >> From 7566f05ac445b652ba7607cc1899fed10fea1c76 Mon Sep 17 00:00:00 2001 >> From: Jason Gunthorpe >> Date: Wed, 19 Oct 2016 14:57:45 -0600 >> Subject: [PATCH] gpio/mvebu: Use irq_domain_add_linear >> >> This fixes the irq allocation in this driver to not print: >> irq: Cannot allocate irq_descs @ IRQ34, assuming pre-allocated >> irq: Cannot allocate irq_descs @ IRQ66, assuming pre-allocated >> >> Which happens because the driver already called irq_alloc_descs() >> and so the change to use irq_domain_add_simple resulted in calling >> irq_alloc_descs() twice. >> >> Modernize the irq allocation in this driver to use the >> irq_domain_add_linear flow directly and eliminate the use of >> irq_domain_add_simple/legacy >> >> Fixes: ce931f571b6d ("gpio/mvebu: convert to use irq_domain_add_simple()") >> Signed-off-by: Jason Gunthorpe > > So can I just apply this? > Gregory? For me it's OK. Gregory > > Yours, > Linus Walleij -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Thu, 27 Oct 2016 09:30:32 +0200 Subject: [PATCH] Revert "gpio/mvebu: convert to use irq_domain_add_simple()" In-Reply-To: (Linus Walleij's message of "Mon, 24 Oct 2016 01:11:23 +0200") References: <1476831396-24359-1-git-send-email-jgunthorpe@obsidianresearch.com> <871szcerxl.fsf@free-electrons.com> <20161019210341.GA3746@obsidianresearch.com> Message-ID: <87twbyb65j.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Linus, On lun., oct. 24 2016, Linus Walleij wrote: > On Wed, Oct 19, 2016 at 11:03 PM, Jason Gunthorpe > wrote: > >> From 7566f05ac445b652ba7607cc1899fed10fea1c76 Mon Sep 17 00:00:00 2001 >> From: Jason Gunthorpe >> Date: Wed, 19 Oct 2016 14:57:45 -0600 >> Subject: [PATCH] gpio/mvebu: Use irq_domain_add_linear >> >> This fixes the irq allocation in this driver to not print: >> irq: Cannot allocate irq_descs @ IRQ34, assuming pre-allocated >> irq: Cannot allocate irq_descs @ IRQ66, assuming pre-allocated >> >> Which happens because the driver already called irq_alloc_descs() >> and so the change to use irq_domain_add_simple resulted in calling >> irq_alloc_descs() twice. >> >> Modernize the irq allocation in this driver to use the >> irq_domain_add_linear flow directly and eliminate the use of >> irq_domain_add_simple/legacy >> >> Fixes: ce931f571b6d ("gpio/mvebu: convert to use irq_domain_add_simple()") >> Signed-off-by: Jason Gunthorpe > > So can I just apply this? > Gregory? For me it's OK. Gregory > > Yours, > Linus Walleij -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com